tripleo

Allow to remove networks when validation is disabled

Bug #1866155 reported by Rabi Mishra
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
tripleo
Fix Released
Undecided
Rabi Mishra

Bug Description

With https://review.opendev.org/#/q/Ia97a2367770e37bf8c55f2fd04c9a9efde914a67 we added changes to ensure that networks are not inadvertently mapped to OS::Heat::None i.e when user forgets network-isolation.yaml environment in the deploy command.

However, there can be situations there is a legitimate requirement to delete networks not used in a deployment. We should probably skip that validation when --disable-validations is specified.

See original description
Rabi Mishra (rabi)
Changed in tripleo:
assignee: nobody → Rabi Mishra (rabi)
summary: - Allow to replace networks when validation is disabled
+ Allow to remove networks when validation is disabled
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-tripleoclient (master)

Fix proposed to branch: master
Review: https://review.opendev.org/711392

Changed in tripleo:
status: New → In Progress
Marios Andreou (marios-b)
description: updated
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-tripleoclient (master)

Reviewed: https://review.opendev.org/711392
Committed: https://git.openstack.org/cgit/openstack/python-tripleoclient/commit/?id=d8a7eaf88c22af6e31d27df9e5ef83a83a8f17b7
Submitter: Zuul
Branch: master

commit d8a7eaf88c22af6e31d27df9e5ef83a83a8f17b7
Author: Rabi Mishra <email address hidden>
Date: Thu Mar 5 12:32:03 2020 +0530

    Skip network check with stack env when validations disabled

    Allow for bypassing check_stack_network_matches_env_files()
    when --disable-validations is provided.

    Change-Id: Ie24163a39a68ec73ae8ea5ad1011eb3789961077
    Closes-Bug: #1866155

Changed in tripleo:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/python-tripleoclient 13.2.0

This issue was fixed in the openstack/python-tripleoclient 13.2.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-tripleoclient (stable/train)

Fix proposed to branch: stable/train
Review: https://review.opendev.org/741464

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-tripleoclient (stable/rocky)

Fix proposed to branch: stable/rocky
Review: https://review.opendev.org/741465

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-tripleoclient (stable/queens)

Fix proposed to branch: stable/queens
Review: https://review.opendev.org/741466

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-tripleoclient (stable/train)

Reviewed: https://review.opendev.org/741464
Committed: https://git.openstack.org/cgit/openstack/python-tripleoclient/commit/?id=bf17d081b87592eef775b183827a5d3b5380611c
Submitter: Zuul
Branch: stable/train

commit bf17d081b87592eef775b183827a5d3b5380611c
Author: Rabi Mishra <email address hidden>
Date: Thu Mar 5 12:32:03 2020 +0530

    Skip network check with stack env when validations disabled

    Allow for bypassing check_stack_network_matches_env_files()
    when --disable-validations is provided.

    Change-Id: Ie24163a39a68ec73ae8ea5ad1011eb3789961077
    Closes-Bug: #1866155
    (cherry picked from commit d8a7eaf88c22af6e31d27df9e5ef83a83a8f17b7)

tags: added: in-stable-train
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-tripleoclient (stable/queens)

Reviewed: https://review.opendev.org/741466
Committed: https://git.openstack.org/cgit/openstack/python-tripleoclient/commit/?id=ef338549353d568a67eba9629e9c5c275ecfa4ea
Submitter: Zuul
Branch: stable/queens

commit ef338549353d568a67eba9629e9c5c275ecfa4ea
Author: Rabi Mishra <email address hidden>
Date: Thu Mar 5 12:32:03 2020 +0530

    Skip network check with stack env when validations disabled

    Allow for bypassing check_stack_network_matches_env_files()
    when --disable-validations is provided.

    Change-Id: Ie24163a39a68ec73ae8ea5ad1011eb3789961077
    Closes-Bug: #1866155
    (cherry picked from commit d8a7eaf88c22af6e31d27df9e5ef83a83a8f17b7)

tags: added: in-stable-queens
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-tripleoclient (stable/rocky)

Reviewed: https://review.opendev.org/741465
Committed: https://git.openstack.org/cgit/openstack/python-tripleoclient/commit/?id=68f74dbcd06c91a254b678e0ee8ba0df57df3882
Submitter: Zuul
Branch: stable/rocky

commit 68f74dbcd06c91a254b678e0ee8ba0df57df3882
Author: Rabi Mishra <email address hidden>
Date: Thu Mar 5 12:32:03 2020 +0530

    Skip network check with stack env when validations disabled

    Allow for bypassing check_stack_network_matches_env_files()
    when --disable-validations is provided.

    Change-Id: Ie24163a39a68ec73ae8ea5ad1011eb3789961077
    Closes-Bug: #1866155
    (cherry picked from commit d8a7eaf88c22af6e31d27df9e5ef83a83a8f17b7)

tags: added: in-stable-rocky
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/python-tripleoclient 12.4.0

This issue was fixed in the openstack/python-tripleoclient 12.4.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/python-tripleoclient rocky-eol

This issue was fixed in the openstack/python-tripleoclient rocky-eol release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/python-tripleoclient queens-eol

This issue was fixed in the openstack/python-tripleoclient queens-eol release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.