VipMap - Missing parameter in network/ports/net_vip_map_external.j2.yaml

[Harald Jensås]

overcloud.j2.yaml pass ControlPlaneSubnetCidr as parameter to OS::TripleO::Network::Ports::NetVipMap

 VipMap:
    type: OS::TripleO::Network::Ports::NetVipMap
    properties:
      ControlPlaneIp: {get_attr: [ControlVirtualIP, fixed_ips, 0, ip_address]}
      ControlPlaneSubnetCidr:
        if:
          - ctlplane_subnet_cidr_set
          - {get_param: ControlPlaneSubnetCidr}
          - {str_split: ['/', {get_attr: [ControlVirtualIP, subnets, 0, cidr]}, 1]}

When overridding with:

resource_registry:
  OS::TripleO::Network::Ports::NetVipMap: ./overcloud/network/ports/net_vip_map_external.yaml

The net_vip_map_external.yaml does not have the ControlPlaneSubnetCidr parameter.
This cause:
  ERROR: Property error: resources.VipMap.properties: Unknown Property ControlPlaneSubnetCidr

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/710120

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/710120
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=6167279363fe8e69115d707ae77d4a05006e9e05
Submitter: Zuul
Branch: master

commit 6167279363fe8e69115d707ae77d4a05006e9e05
Author: Harald Jensås <email address hidden>
Date: Wed Feb 26 19:58:19 2020 +0100

    ControlPlaneSubnetCidr in net_vip_map_external

    network/ports/net_vip_map_external.j2.yaml needs the
    ControlPlaneSubnetCidr parameter, since the resource
    in overcloud.yaml is passing the property.

    Change-Id: Ide91bd5956bcbbec36d865865c32cc6430d59a49
    Closes-Bug: #1864912

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/train
Review: https://review.opendev.org/713548

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/stein
Review: https://review.opendev.org/713549

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/713549
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=78de0c32c52ede1165db6183352ce847f0172d54
Submitter: Zuul
Branch: stable/stein

commit 78de0c32c52ede1165db6183352ce847f0172d54
Author: Harald Jensås <email address hidden>
Date: Wed Feb 26 19:58:19 2020 +0100

    ControlPlaneSubnetCidr in net_vip_map_external

    network/ports/net_vip_map_external.j2.yaml needs the
    ControlPlaneSubnetCidr parameter, since the resource
    in overcloud.yaml is passing the property.

    Change-Id: Ide91bd5956bcbbec36d865865c32cc6430d59a49
    Closes-Bug: #1864912
    (cherry picked from commit 6167279363fe8e69115d707ae77d4a05006e9e05)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/713548
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=0e6720a1994ecc6070b93a740ee46fd147372a11
Submitter: Zuul
Branch: stable/train

commit 0e6720a1994ecc6070b93a740ee46fd147372a11
Author: Harald Jensås <email address hidden>
Date: Wed Feb 26 19:58:19 2020 +0100

    ControlPlaneSubnetCidr in net_vip_map_external

    network/ports/net_vip_map_external.j2.yaml needs the
    ControlPlaneSubnetCidr parameter, since the resource
    in overcloud.yaml is passing the property.

    Change-Id: Ide91bd5956bcbbec36d865865c32cc6430d59a49
    Closes-Bug: #1864912
    (cherry picked from commit 6167279363fe8e69115d707ae77d4a05006e9e05)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 12.2.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 11.4.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates stein-eol release.