diskimage-builder fails at virtualenv setup

[John Smart]

Steps to reproduce
==================
1. yum install diskimage-builder (centos-openstack-rocky)
2. I followed this manual 'https://docs.openstack.org/heat/latest/template_guide/software_deployment.html#software-deployment-resources'.

Expected result
===============
Successful creation of cloud image.

Actual result
=============
2020-02-13 14:47:01.459 | + virtualenv --setuptools /opt/stack/venvs/os-collect-config
2020-02-13 14:47:01.639 | usage: virtualenv [--version] [--with-traceback] [-v | -q] [--discovery {builtin}] [-p py] [--creator {builtin,cpython2-posix}] [--seeder {app-data,pip}] [--no-seed] [--activators comma_separated_list] [--clear] [--system-site-packages]
2020-02-13 14:47:01.639 | [--symlinks | --copies] [--download | --no-download] [--extra-search-dir d [d ...]] [--pip version] [--setuptools version] [--wheel version] [--no-pip] [--no-setuptools] [--no-wheel] [--clear-app-data] [--symlink-app-data]
2020-02-13 14:47:01.639 | [--prompt prompt] [-h]
2020-02-13 14:47:01.639 | dest
2020-02-13 14:47:01.639 | virtualenv: error: too few arguments

After removing '--setuptools' option in 'tripleo-image-elements/elements/os-apply-config/install.d/os-apply-config-source-install/10-os-apply-config' it does not fail with message 'virtualenv: error: too few arguments':

example:

2020-02-13 14:46:49.858 | + virtualenv /opt/stack/venvs/os-apply-config
2020-02-13 14:46:50.471 | created virtual environment in 495ms CPython2Posix(dest=/opt/stack/venvs/os-apply-config, clear=False, global=False) with seeder FromAppData pip=latest setuptools=latest wheel=latest app_data_dir=/root/.local/share/virtualenv/seed-v1 via=copy

Environment
===========
1. Exact version of OpenStack you are running. See the following
  rocky

CentOS Linux release 7.6.1810
3.10.0-957.1.3.el7.x86_64

diskimage-builder.noarch 2.16.0-1.el7 @centos-openstack-rocky

Logs & Configs
==============
http://paste.openstack.org/show/789531/

[Andreas Florath (ansreas)]

Same problem here with Debian Buster and Ubuntu Bionic.

 2020-02-24 08:32:46.813 | Attempting uninstall: virtualenv
 2020-02-24 08:32:46.815 | Found existing installation: virtualenv 15.1.0
 2020-02-24 08:32:46.816 | Uninstalling virtualenv-15.1.0:
 2020-02-24 08:32:46.817 | Successfully uninstalled virtualenv-15.1.0
 2020-02-24 08:32:46.923 | Successfully installed appdirs-1.4.3 configparser-4.0.2 contextlib2-0.6.0.post1 distlib-0.3.0 filelock-3.0.12 importlib-metadata-1.5.0 importlib-resources-1.0.2 pathlib2-2.3.5 scandir-1.10.0 six-1.14.0 typing-3.7.4.1 virtualenv-20.0.5 zipp-1.2.0

 2020-02-24 08:32:47.066 | dib-run-parts 10-debian-networking completed
 2020-02-24 08:32:47.066 | dib-run-parts Running /tmp/in_target.d/install.d/10-os-apply-config
 2020-02-24 08:32:47.073 | ++ get-pip-manifest os-apply-config
 2020-02-24 08:32:47.076 | + name=os-apply-config
 2020-02-24 08:32:47.076 | + build_manifest=/etc/dib-manifests/dib-manifests-pip/dib-pip-build-manifest-os_apply_config
 2020-02-24 08:32:47.076 | + [[ -f /etc/dib-manifests/dib-manifests-pip/dib-pip-build-manifest-os_apply_config ]]
 2020-02-24 08:32:47.076 | + manifest=
 2020-02-24 08:32:47.077 | + virtualenv --setuptools /opt/stack/venvs/os-apply-config
 2020-02-24 08:32:47.187 | usage: virtualenv [--version] [--with-traceback] [-v | -q] [--discovery {builtin}] [-p py] [--creator {builtin,cpython2-posix}] [--seeder {app-data,pip}] [--no-seed] [--activators comma_separated_list] [--clear] [--system-site-packages]
 2020-02-24 08:32:47.187 | [--symlinks | --copies] [--download | --no-download] [--extra-search-dir d [d ...]] [--pip version] [--setuptools version] [--wheel version] [--no-pip] [--no-setuptools] [--no-wheel] [--clear-app-data] [--symlink-app-data]
 2020-02-24 08:32:47.187 | [--prompt prompt] [-h]
 2020-02-24 08:32:47.187 | dest
 2020-02-24 08:32:47.187 | virtualenv: error: too few arguments

[Andreas Florath (ansreas)]

Hint: the '--setuptools' parameter in virtualenv changed.

15.1.0:

  --setuptools DEPRECATED. Retained only for backward compatibility.
                        This option has no effect.

20.0.5:

  --setuptools version setuptools version to install, bundle for bundled (default: latest)

So removing '--setuptools' completely looks like a possible solution here.

[wes hayutin (weshayutin)]

Perhaps this log would help?
https://storage.gra.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_0b4/712045/1/gate/tripleo-buildimage-overcloud-full-centos-7/0b44df1/build_images.sh