problem in how ceph_ansible_inherits_calling_ansible_environment

[John Fulton]

When ceph_ansible_inherits_calling_ansible_environment [1] is used it should only pass environment variables from the calling ansible to the called ansible which satisfy the expression ANSIBLE_*

However, CI runs from [2] show that an environment variable not matching that pattern arrived in the call. E.g. we saw 'SUDO_COMMAND=/bin/sh -c echo BECOME-SUCCESS-absoeucktxpqbohexiwnnaooumjifuvk ;' when it shouldn't be there.

The filter on line 54 [1] appears to be broken and should be fixed.

[1] https://review.opendev.org/#/c/674706/4/tripleo_ansible/roles/tripleo-ceph-common/tasks/main.yml@54
[2] https://review.opendev.org/#/c/705775/

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/706041

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/706041
Committed: https://git.openstack.org/cgit/openstack/tripleo-ansible/commit/?id=b5fc16aea638489e414f247287049ef6af43dcae
Submitter: Zuul
Branch: master

commit b5fc16aea638489e414f247287049ef6af43dcae
Author: John Fulton <email address hidden>
Date: Wed Feb 5 11:50:15 2020 -0500

    Pass only variables starting with ANSIBLE

    When config-download runs ceph-ansible it does so by calling
    Ansible from within Ansible. We all ANSIBLE_* environment
    variables to the nested Ansible execution. However there was
    a bug where any variable containing ANSILBE was included, not
    just those starting with ANSIBLE. This fix ensures we filter
    out only variables starting with ANSIBLE.

    Change-Id: I9f3e18dcf520ee7ac6370a49d0ae003a192d9bd3
    Closes-Bug: 1862031

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/train
Review: https://review.opendev.org/706524

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/706524
Committed: https://git.openstack.org/cgit/openstack/tripleo-ansible/commit/?id=924cc11a6e5b6ce883241b61692d0f0dfd252197
Submitter: Zuul
Branch: stable/train

commit 924cc11a6e5b6ce883241b61692d0f0dfd252197
Author: John Fulton <email address hidden>
Date: Wed Feb 5 11:50:15 2020 -0500

    Pass only variables starting with ANSIBLE

    When config-download runs ceph-ansible it does so by calling
    Ansible from within Ansible. We all ANSIBLE_* environment
    variables to the nested Ansible execution. However there was
    a bug where any variable containing ANSILBE was included, not
    just those starting with ANSIBLE. This fix ensures we filter
    out only variables starting with ANSIBLE.

    Change-Id: I9f3e18dcf520ee7ac6370a49d0ae003a192d9bd3
    Closes-Bug: 1862031
    (cherry picked from commit b5fc16aea638489e414f247287049ef6af43dcae)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-ansible 1.2.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-ansible 0.5.0 release.