commit 024afc22a07d94b186fff2d99f2600c9bc170034
Author: Alex Schultz <email address hidden>
Date: Tue May 19 10:38:10 2020 -0600
Improve facter cache reliability
We don't need to be caching EC2 metadata in our facter runs because we
don't use this. By leaving this on, it can cause problems when run on
VMs in a cloud that might support EC2. By having this enabled, we can
see deployments failing to configure nodes because it timesout:
2020-05-13 22:38:30.574339 ERROR puppetlabs.facter - EC2 user data
request failed: Timeout was reached
Additionally if facter fails to generate the cache, the subsequent
puppet runs will fail. This change also added retries to the facter
cache call to ensure that we should be able to generate the cache if an
external fact call fails for some reason.
NOTE: The master patch for this is against tripleo-ansible
Closes-Bug: #1861917
Change-Id: Iaaed0dcf747ca4a08f8e200b43d0f2259ad0ed39
(cherry-picked from c3b57d6a6c26acf35168fea7303fc485e1dcd13f)
Reviewed: https:/ /review. opendev. org/729326 /git.openstack. org/cgit/ openstack/ tripleo- heat-templates/ commit/ ?id=024afc22a07 d94b186fff2d99f 2600c9bc170034
Committed: https:/
Submitter: Zuul
Branch: stable/train
commit 024afc22a07d94b 186fff2d99f2600 c9bc170034
Author: Alex Schultz <email address hidden>
Date: Tue May 19 10:38:10 2020 -0600
Improve facter cache reliability
We don't need to be caching EC2 metadata in our facter runs because we
don't use this. By leaving this on, it can cause problems when run on
VMs in a cloud that might support EC2. By having this enabled, we can
see deployments failing to configure nodes because it timesout:
2020-05-13 22:38:30.574339 ERROR puppetlabs.facter - EC2 user data
request failed: Timeout was reached
Additionally if facter fails to generate the cache, the subsequent
puppet runs will fail. This change also added retries to the facter
cache call to ensure that we should be able to generate the cache if an
external fact call fails for some reason.
NOTE: The master patch for this is against tripleo-ansible
Closes-Bug: #1861917 a08f8e200b43d0f 2259ad0ed39 35168fea7303fc4 85e1dcd13f)
Change-Id: Iaaed0dcf747ca4
(cherry-picked from c3b57d6a6c26acf