hiera not updated in the early stage of the update.

Bug #1861799 reported by Sofer Athlan-Guyot on 2020-02-04
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
tripleo
Critical
Sofer Athlan-Guyot

Bug Description

Hi,

we don't update hiera data before the update task, only during converge.

This can cause issues, one of them in that sidecar container definition is not updated with the new tag which can cause problem later on.

Fix proposed to branch: master
Review: https://review.opendev.org/705642

Changed in tripleo:
status: Triaged → In Progress
Changed in tripleo:
milestone: none → ussuri-2
wes hayutin (weshayutin) on 2020-02-10
Changed in tripleo:
milestone: ussuri-2 → ussuri-3

Change abandoned by Brent Eagles (<email address hidden>) on branch: master
Review: https://review.opendev.org/707393
Reason: mistakenly proposed to master - afaict this isn't a problem here because of systemd wrappers.

 Originally tracked there https://bugzilla.redhat.com/show_bug.cgi?id=1801763. TL;DR, patch tested on OSP16 and working as expected.

Reviewed: https://review.opendev.org/705642
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=536230b323e5c3ac41e6ed990360317cdb5bc702
Submitter: Zuul
Branch: master

commit 536230b323e5c3ac41e6ed990360317cdb5bc702
Author: Sofer Athlan-Guyot <email address hidden>
Date: Tue Feb 4 12:11:15 2020 +0100

    [update] Ensure we get fresh hiera data before running update_steps.

    We need to make sure that the hiera data are fresh before the update
    step so that anyone using those data during those steps are seeing the
    latest information from heat.

    Factor out the hiera generation and include it in deployment and
    update playbooks.

    The double tasks definition in the deployment playbook seemed to be
    redundant so It has been removed.

    Change-Id: I6b6c676880ccc8cbed23af135e5865c222a8f1d0
    Closes-Bug: #1861799

Changed in tripleo:
status: In Progress → Fix Released

Change abandoned by Brent Eagles (<email address hidden>) on branch: stable/train
Review: https://review.opendev.org/707395
Reason: rendered unnecessary by https://review.opendev.org/#/c/705642/

Reviewed: https://review.opendev.org/707230
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=aa365ee1177a07c27e057f67efdf2ad8d418c82a
Submitter: Zuul
Branch: stable/train

commit aa365ee1177a07c27e057f67efdf2ad8d418c82a
Author: Sofer Athlan-Guyot <email address hidden>
Date: Tue Feb 4 12:11:15 2020 +0100

    [update] Ensure we get fresh hiera data before running update_steps.

    We need to make sure that the hiera data are fresh before the update
    step so that anyone using those data during those steps are seeing the
    latest information from heat.

    Factor out the hiera generation and include it in deployment and
    update playbooks.

    The double tasks definition in the deployment playbook seemed to be
    redundant so It has been removed.

    Change-Id: I6b6c676880ccc8cbed23af135e5865c222a8f1d0
    Closes-Bug: #1861799
    With some adjustment:
    (cherry picked from commit 536230b323e5c3ac41e6ed990360317cdb5bc702)

tags: added: in-stable-train
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.