VFs are used in dhcp-all-interfaces list

Bug #1861473 reported by Saravanan KR
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
tripleo
Fix Released
Medium
Saravanan KR

Bug Description

In case of any failure in running os-net-config, the fallback mechanism in THT will trigger dhcp on all interfaces (inclduing VFs). VFs should not be used for dhcp-all-interfaces.

See https://bugzilla.redhat.com/show_bug.cgi?id=1794318 for additional details.

Saravanan KR (skramaja)
Changed in tripleo:
assignee: nobody → Saravanan KR (skramaja)
milestone: none → ussuri-2
importance: Undecided → Medium
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tripleo-heat-templates (master)

Fix proposed to branch: master
Review: https://review.opendev.org/705157

Changed in tripleo:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-heat-templates (master)

Reviewed: https://review.opendev.org/705157
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=bc014864282372e74839aefd6d7a444a20643af3
Submitter: Zuul
Branch: master

commit bc014864282372e74839aefd6d7a444a20643af3
Author: Saravanan KR <email address hidden>
Date: Thu Jan 30 21:21:02 2020 +0530

    Ignore SR-IOV VFs on dhcp_all_interfaces list

    When os-net-config fails, it will trigger the configure_safe_defaults
    function, which will enable dhcp on all interfaces which has link up
    and having a valid mac address. SR-IOV VFs will also fall in this
    list, ignore VFs in the dhcp all list.
    Closes-Bug: #1861473

    Change-Id: I563f42dc417ce5e403310ea33b969e19d16ad68f

Changed in tripleo:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tripleo-heat-templates (stable/train)

Fix proposed to branch: stable/train
Review: https://review.opendev.org/705602

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tripleo-heat-templates (stable/stein)

Fix proposed to branch: stable/stein
Review: https://review.opendev.org/705603

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tripleo-heat-templates (stable/rocky)

Fix proposed to branch: stable/rocky
Review: https://review.opendev.org/705604

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tripleo-heat-templates (stable/queens)

Fix proposed to branch: stable/queens
Review: https://review.opendev.org/705605

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-heat-templates (stable/train)

Reviewed: https://review.opendev.org/705602
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=b2de751d73a7136e3785f4f9b3919c6612928d8a
Submitter: Zuul
Branch: stable/train

commit b2de751d73a7136e3785f4f9b3919c6612928d8a
Author: Saravanan KR <email address hidden>
Date: Thu Jan 30 21:21:02 2020 +0530

    Ignore SR-IOV VFs on dhcp_all_interfaces list

    When os-net-config fails, it will trigger the configure_safe_defaults
    function, which will enable dhcp on all interfaces which has link up
    and having a valid mac address. SR-IOV VFs will also fall in this
    list, ignore VFs in the dhcp all list.
    Closes-Bug: #1861473

    Change-Id: I563f42dc417ce5e403310ea33b969e19d16ad68f
    (cherry picked from commit bc014864282372e74839aefd6d7a444a20643af3)

tags: added: in-stable-train
tags: added: in-stable-queens
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-heat-templates (stable/queens)

Reviewed: https://review.opendev.org/705605
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=d4c8e6a26b16d5700fa56772b2dd6610157ee05e
Submitter: Zuul
Branch: stable/queens

commit d4c8e6a26b16d5700fa56772b2dd6610157ee05e
Author: Saravanan KR <email address hidden>
Date: Thu Jan 30 21:21:02 2020 +0530

    Ignore SR-IOV VFs on dhcp_all_interfaces list

    When os-net-config fails, it will trigger the configure_safe_defaults
    function, which will enable dhcp on all interfaces which has link up
    and having a valid mac address. SR-IOV VFs will also fall in this
    list, ignore VFs in the dhcp all list.
    Closes-Bug: #1861473

    Change-Id: I563f42dc417ce5e403310ea33b969e19d16ad68f
    (cherry picked from commit bc014864282372e74839aefd6d7a444a20643af3)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-heat-templates (stable/stein)

Reviewed: https://review.opendev.org/705603
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=c45c2ba14c94659245a3d6d11807adcf71fe914e
Submitter: Zuul
Branch: stable/stein

commit c45c2ba14c94659245a3d6d11807adcf71fe914e
Author: Saravanan KR <email address hidden>
Date: Thu Jan 30 21:21:02 2020 +0530

    Ignore SR-IOV VFs on dhcp_all_interfaces list

    When os-net-config fails, it will trigger the configure_safe_defaults
    function, which will enable dhcp on all interfaces which has link up
    and having a valid mac address. SR-IOV VFs will also fall in this
    list, ignore VFs in the dhcp all list.
    Closes-Bug: #1861473

    Change-Id: I563f42dc417ce5e403310ea33b969e19d16ad68f
    (cherry picked from commit bc014864282372e74839aefd6d7a444a20643af3)

tags: added: in-stable-stein
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-heat-templates (stable/rocky)

Reviewed: https://review.opendev.org/705604
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=0188cea1fcf88ebf0c8e58cbc467d1c7023ac14d
Submitter: Zuul
Branch: stable/rocky

commit 0188cea1fcf88ebf0c8e58cbc467d1c7023ac14d
Author: Saravanan KR <email address hidden>
Date: Thu Jan 30 21:21:02 2020 +0530

    Ignore SR-IOV VFs on dhcp_all_interfaces list

    When os-net-config fails, it will trigger the configure_safe_defaults
    function, which will enable dhcp on all interfaces which has link up
    and having a valid mac address. SR-IOV VFs will also fall in this
    list, ignore VFs in the dhcp all list.
    Closes-Bug: #1861473

    Change-Id: I563f42dc417ce5e403310ea33b969e19d16ad68f
    (cherry picked from commit bc014864282372e74839aefd6d7a444a20643af3)

tags: added: in-stable-rocky
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/tripleo-heat-templates 12.1.0

This issue was fixed in the openstack/tripleo-heat-templates 12.1.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/tripleo-heat-templates 11.4.0

This issue was fixed in the openstack/tripleo-heat-templates 11.4.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/tripleo-heat-templates rocky-eol

This issue was fixed in the openstack/tripleo-heat-templates rocky-eol release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/tripleo-heat-templates queens-eol

This issue was fixed in the openstack/tripleo-heat-templates queens-eol release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/tripleo-heat-templates stein-eol

This issue was fixed in the openstack/tripleo-heat-templates stein-eol release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.