undercloud container registry does not properly support oci containers

[Alex Schultz]

Older buildah versions used to create the docker format by default but this has changed to be oci in more recent builds (buildah-1.11.6-4.module+el8.1.1+5259+bcdd613a.x86_64). The undercloud registry only currently supports docker formatted containers so when an oci one is pushed, the metadata is not correct for podman to fetch the container. When podman attempts to pull the image, it fails with:

(undercloud) [cloud-user@undercloud ~]$ sudo podman pull docker://undercloud.ctlplane.localdomain:8787/foo/foo:latest
Trying to pull docker://undercloud.ctlplane.localdomain:8787/foo/foo:latest...
  unsupported docker v2s2 media type: ""
Error: error pulling image "docker://undercloud.ctlplane.localdomain:8787/foo/foo:latest": unable to pull docker://undercloud.ctlplane.localdomain:8787/foo/foo:latest: unable to pull image: Error initializing image from source docker://undercloud.ctlplane.localdomain:8787/foo/foo:latest: unsupported docker v2s2 media type: "

This impacts the ansible-role-tripleo-modify-image workflow via ContainerImagePrepare.

This can be worked around by always specifying "--format docker" when doing buildah builds.

This impacts CI as we use this code to update the containers with the latest version of packages.

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.opendev.org/703859

[Waldemar Znoinski (wznoinsk)]

FYI: as a (early) test I've applied https://review.opendev.org/#/c/703846/1 on top of a downstream OSP 16 CI undercloud:

[root@undercloud-0 tripleo-modify-image]# patch -p1 < 1e10b22.diff
patching file tasks/yum_install_buildah.yml
patching file tasks/yum_update_buildah.yml
Hunk #1 succeeded at 137 (offset -5 lines).
patching file vars/main.yml

which was failing before and now it is passing the 'podman pull' succesfully

good work, thanks!

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/703859
Committed: https://git.openstack.org/cgit/openstack/tripleo-common/commit/?id=39f0f369b947120ebc5faa80946621065d1fae10
Submitter: Zuul
Branch: master

commit 39f0f369b947120ebc5faa80946621065d1fae10
Author: Alex Schultz <email address hidden>
Date: Wed Jan 22 12:10:58 2020 -0700

    Force docker format

    Newer versions of buildah create OCI containers but the undercloud
    registry does not support the OCI container metadata format so these
    cannot be used with newer podman. For now this can be worked around by
    explicitly passing --format docker when running buildah build related
    commands.

    Change-Id: I25c7a239add99e2d4dac433794d6ca92a58942b6
    Related-Bug: #1860585

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: stable/train
Review: https://review.opendev.org/703996

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: stable/stein
Review: https://review.opendev.org/703997

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/703996
Committed: https://git.openstack.org/cgit/openstack/tripleo-common/commit/?id=6fc665cbb679a157280ae5e24a5fddf7ff7a17dc
Submitter: Zuul
Branch: stable/train

commit 6fc665cbb679a157280ae5e24a5fddf7ff7a17dc
Author: Alex Schultz <email address hidden>
Date: Wed Jan 22 12:10:58 2020 -0700

    Force docker format

    Newer versions of buildah create OCI containers but the undercloud
    registry does not support the OCI container metadata format so these
    cannot be used with newer podman. For now this can be worked around by
    explicitly passing --format docker when running buildah build related
    commands.

    Change-Id: I25c7a239add99e2d4dac433794d6ca92a58942b6
    Related-Bug: #1860585
    (cherry picked from commit 39f0f369b947120ebc5faa80946621065d1fae10)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/703997
Committed: https://git.openstack.org/cgit/openstack/tripleo-common/commit/?id=5575f381aabb19de76315a8a060825e5270f5ec0
Submitter: Zuul
Branch: stable/stein

commit 5575f381aabb19de76315a8a060825e5270f5ec0
Author: Alex Schultz <email address hidden>
Date: Wed Jan 22 12:10:58 2020 -0700

    Force docker format

    Newer versions of buildah create OCI containers but the undercloud
    registry does not support the OCI container metadata format so these
    cannot be used with newer podman. For now this can be worked around by
    explicitly passing --format docker when running buildah build related
    commands.

    Change-Id: I25c7a239add99e2d4dac433794d6ca92a58942b6
    Related-Bug: #1860585
    (cherry picked from commit 39f0f369b947120ebc5faa80946621065d1fae10)

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/tripleo-common/+/810312

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/tripleo-common/+/810312
Committed: https://opendev.org/openstack/tripleo-common/commit/e252328bf5a1134bfb236bfc84ce9c7b4597b5a7
Submitter: "Zuul (22348)"
Branch: master

commit e252328bf5a1134bfb236bfc84ce9c7b4597b5a7
Author: Alex Schultz <email address hidden>
Date: Tue Sep 21 13:31:10 2021 -0600

    Allow for OCI manifests

    We always convert to docker metadata for the undercloud, but we need to
    be able to handle OCI source manifests from a remote registry. We
    previously added support to handle the conversion however it wasn't
    complete since we only request docker manifests from remote registries.

    Change-Id: I3ca3d7c08d08525ead15c50d2e44c9db310859e7
    Related-Bug: #1860585

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/tripleo-common/+/812511

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/tripleo-common/+/812511
Committed: https://opendev.org/openstack/tripleo-common/commit/3f2853b9a2e6f7de16bf928721aa2b3b4fa5c801
Submitter: "Zuul (22348)"
Branch: master

commit 3f2853b9a2e6f7de16bf928721aa2b3b4fa5c801
Author: Alex Schultz <email address hidden>
Date: Tue Oct 5 08:12:50 2021 -0600

    Revert "Revert "Allow for OCI manifests""

    Add support for OCI manifests and includes a fix to handle the
    schemaVersion 1 metadata which is used by the prometheus
    containers upstream.

    This reverts commit b2f76f8514baefb57e10c9a5562457b651ec29af.

    Change-Id: I352cd33578eeb447d3a36cbca7767b1bfd5de7aa
    Depends-On: https://review.opendev.org/c/openstack/tripleo-ci/+/812506
    Related-Bug: #1860585

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: stable/wallaby
Review: https://review.opendev.org/c/openstack/tripleo-common/+/812961

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: stable/victoria
Review: https://review.opendev.org/c/openstack/tripleo-common/+/812962

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: stable/ussuri
Review: https://review.opendev.org/c/openstack/tripleo-common/+/812963

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: stable/train
Review: https://review.opendev.org/c/openstack/tripleo-common/+/812964

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/tripleo-common/+/812961
Committed: https://opendev.org/openstack/tripleo-common/commit/93bd4e1dbc495eaae97f5767cd07d3332c60dc9c
Submitter: "Zuul (22348)"
Branch: stable/wallaby

commit 93bd4e1dbc495eaae97f5767cd07d3332c60dc9c
Author: Alex Schultz <email address hidden>
Date: Tue Oct 5 08:12:50 2021 -0600

    Revert "Revert "Allow for OCI manifests""

    Add support for OCI manifests and includes a fix to handle the
    schemaVersion 1 metadata which is used by the prometheus
    containers upstream.

    This reverts commit b2f76f8514baefb57e10c9a5562457b651ec29af.

    Change-Id: I352cd33578eeb447d3a36cbca7767b1bfd5de7aa
    Depends-On: https://review.opendev.org/c/openstack/tripleo-ci/+/812506
    Related-Bug: #1860585
    (cherry picked from commit 3f2853b9a2e6f7de16bf928721aa2b3b4fa5c801)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/tripleo-common/+/812964
Committed: https://opendev.org/openstack/tripleo-common/commit/5c40e366b323d03d0767977f9f7d66ee3a26ac3f
Submitter: "Zuul (22348)"
Branch: stable/train

commit 5c40e366b323d03d0767977f9f7d66ee3a26ac3f
Author: Alex Schultz <email address hidden>
Date: Tue Oct 5 08:12:50 2021 -0600

    Revert "Revert "Allow for OCI manifests""

    Add support for OCI manifests and includes a fix to handle the
    schemaVersion 1 metadata which is used by the prometheus
    containers upstream.

    This reverts commit b2f76f8514baefb57e10c9a5562457b651ec29af.

    Change-Id: I352cd33578eeb447d3a36cbca7767b1bfd5de7aa
    Depends-On: https://review.opendev.org/c/openstack/tripleo-ci/+/812506
    Related-Bug: #1860585
    (cherry picked from commit 3f2853b9a2e6f7de16bf928721aa2b3b4fa5c801)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/tripleo-common/+/812962
Committed: https://opendev.org/openstack/tripleo-common/commit/8a22b25d8e3ca51c53122579d6f9b78a3305aa77
Submitter: "Zuul (22348)"
Branch: stable/victoria

commit 8a22b25d8e3ca51c53122579d6f9b78a3305aa77
Author: Alex Schultz <email address hidden>
Date: Tue Oct 5 08:12:50 2021 -0600

    Revert "Revert "Allow for OCI manifests""

    Add support for OCI manifests and includes a fix to handle the
    schemaVersion 1 metadata which is used by the prometheus
    containers upstream.

    This reverts commit b2f76f8514baefb57e10c9a5562457b651ec29af.

    Change-Id: I352cd33578eeb447d3a36cbca7767b1bfd5de7aa
    Depends-On: https://review.opendev.org/c/openstack/tripleo-ci/+/812506
    Related-Bug: #1860585
    (cherry picked from commit 3f2853b9a2e6f7de16bf928721aa2b3b4fa5c801)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/tripleo-common/+/812963
Committed: https://opendev.org/openstack/tripleo-common/commit/25d9a7eb4457eca359a1c3ea3fe3e4f9c798f0fb
Submitter: "Zuul (22348)"
Branch: stable/ussuri

commit 25d9a7eb4457eca359a1c3ea3fe3e4f9c798f0fb
Author: Alex Schultz <email address hidden>
Date: Tue Oct 5 08:12:50 2021 -0600

    Revert "Revert "Allow for OCI manifests""

    Add support for OCI manifests and includes a fix to handle the
    schemaVersion 1 metadata which is used by the prometheus
    containers upstream.

    This reverts commit b2f76f8514baefb57e10c9a5562457b651ec29af.

    Change-Id: I352cd33578eeb447d3a36cbca7767b1bfd5de7aa
    Depends-On: https://review.opendev.org/c/openstack/tripleo-ci/+/812506
    Related-Bug: #1860585
    (cherry picked from commit 3f2853b9a2e6f7de16bf928721aa2b3b4fa5c801)