CinderCronDbPurgeMaxDelay is not applied

[Takashi Kajinami]

In the latest tripleo-heat-templates, we have CinderCronDbPurgeMaxDelay to configure Max Delay in cinder cronb purge job.

deployment/cinder/cinder-base.yaml
~~~
  CinderCronDbPurgeMaxDelay:
    type: string
    description: >
        Cron to move deleted instances to another table - Max Delay
    default: '3600'
~~~

The parameter should have 3600 by default, but it is not applied on controllers.
~~~
[heat-admin@controller-0 ~]$ sudo cat /var/lib/config-data/puppet-generated/cinder/var/spool/cron/cinder
# HEADER: This file was autogenerated at 2020-01-18 10:53:55 +0000 by puppet.
# HEADER: While it can still be managed manually, it is definitely not recommended.
# HEADER: Note particularly that the comments starting with 'Puppet Name' should
# HEADER: not be deleted, as doing so could cause duplicate cron jobs.
# Puppet Name: cinder-manage db purge
PATH=/bin:/usr/bin:/usr/sbin SHELL=/bin/sh
1 0 * * * cinder-manage db purge 30 >>/var/log/cinder/cinder-rowsflush.log 2>&1
~~~

I actually observed this in stable/queens, but I see that wrong parameter passed in t-h-t even in current master.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/703725

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/train
Review: https://review.opendev.org/703726

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/stein
Review: https://review.opendev.org/703727

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/rocky
Review: https://review.opendev.org/703728

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/queens
Review: https://review.opendev.org/703729

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/703725
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=fa52709a871492b60f140e387044e24b1973594f
Submitter: Zuul
Branch: master

commit fa52709a871492b60f140e387044e24b1973594f
Author: Takashi Kajinami <email address hidden>
Date: Wed Jan 22 13:12:04 2020 +0900

    Fix incorrect parameter to set max delay in cinder db purge cron

    Closes-bug: #1860505
    Change-Id: I5ed014fb1061379d7a7a8686d289c1303941dce9

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/703726
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=fa67cb17afde833b7a714dcf9bfd3376a7800c34
Submitter: Zuul
Branch: stable/train

commit fa67cb17afde833b7a714dcf9bfd3376a7800c34
Author: Takashi Kajinami <email address hidden>
Date: Wed Jan 22 13:12:04 2020 +0900

    Fix incorrect parameter to set max delay in cinder db purge cron

    Closes-bug: #1860505
    Change-Id: I5ed014fb1061379d7a7a8686d289c1303941dce9
    (cherry picked from commit fa52709a871492b60f140e387044e24b1973594f)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/703729
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=9d8e735fb5c1d4df4928c274df1ddd3ba3b151b4
Submitter: Zuul
Branch: stable/queens

commit 9d8e735fb5c1d4df4928c274df1ddd3ba3b151b4
Author: Takashi Kajinami <email address hidden>
Date: Wed Jan 22 13:12:04 2020 +0900

    Fix incorrect parameter to set max delay in cinder db purge cron

    Closes-bug: #1860505
    Change-Id: I5ed014fb1061379d7a7a8686d289c1303941dce9
    (cherry picked from commit fa52709a871492b60f140e387044e24b1973594f)
    (cherry picked from commit fa67cb17afde833b7a714dcf9bfd3376a7800c34)
    (cherry picked from commit 7c837f11fcbc5bb7499a6a25757d8961b2d60a8d)
    (cherry picked from commit 10e7dd8fab9bcea594e85ab12bb55c92803f9da2)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/703728
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=10e7dd8fab9bcea594e85ab12bb55c92803f9da2
Submitter: Zuul
Branch: stable/rocky

commit 10e7dd8fab9bcea594e85ab12bb55c92803f9da2
Author: Takashi Kajinami <email address hidden>
Date: Wed Jan 22 13:12:04 2020 +0900

    Fix incorrect parameter to set max delay in cinder db purge cron

    Closes-bug: #1860505
    Change-Id: I5ed014fb1061379d7a7a8686d289c1303941dce9
    (cherry picked from commit fa52709a871492b60f140e387044e24b1973594f)
    (cherry picked from commit fa67cb17afde833b7a714dcf9bfd3376a7800c34)
    (cherry picked from commit 7c837f11fcbc5bb7499a6a25757d8961b2d60a8d)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/703727
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=1eb86c3fe849ceeb4bba3d5bbe9009583d0f30a6
Submitter: Zuul
Branch: stable/stein

commit 1eb86c3fe849ceeb4bba3d5bbe9009583d0f30a6
Author: Takashi Kajinami <email address hidden>
Date: Wed Jan 22 13:12:04 2020 +0900

    Fix incorrect parameter to set max delay in cinder db purge cron

    Closes-bug: #1860505
    Depends-on: https://review.opendev.org/#/c/704267/
    Change-Id: I5ed014fb1061379d7a7a8686d289c1303941dce9
    (cherry picked from commit fa52709a871492b60f140e387044e24b1973594f)
    (cherry picked from commit fa67cb17afde833b7a714dcf9bfd3376a7800c34)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 12.1.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 11.4.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates rocky-eol release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates queens-eol release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates stein-eol release.