[Queens only] Upgrade tasks can't stop auditd service

[Jose Luis Franco]

This issue is created as an upstream track for the BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1793063

When upgrading the Controller nodes from Pike to Queens one of the upgrade tasks failed during the stoppage of the auditd service:

2020-01-18 02:00:44,890 p=136626 u=mistral | TASK [Stop and disable openstack-aodh-notifier service] ************************
2020-01-18 02:00:44,891 p=136626 u=mistral | Saturday 18 January 2020 02:00:44 +0000 (0:00:00.301) 0:07:25.806 ******
2020-01-18 02:00:44,982 p=136626 u=mistral | skipping: [fws-shk01-fcn03] => {"changed": false, "skip_reason": "Conditional result was False"}
2020-01-18 02:00:44,996 p=136626 u=mistral | skipping: [fws-shk01-fcn02] => {"changed": false, "skip_reason": "Conditional result was False"}
2020-01-18 02:00:45,083 p=136626 u=mistral | TASK [Stop auditd service] *****************************************************
2020-01-18 02:00:45,084 p=136626 u=mistral | Saturday 18 January 2020 02:00:45 +0000 (0:00:00.193) 0:07:25.999 ******
2020-01-18 02:00:45,398 p=136626 u=mistral | fatal: [fws-shk01-fcn03]: FAILED! => {"changed": false, "msg": "Unable to stop service auditd: Failed to stop auditd.service: Operation refused, unit auditd.service may be requested by dependency only (it is configured to refuse manual start/stop).\nSee system logs and 'systemctl status auditd.service' for details.\n"}
2020-01-18 02:00:45,475 p=136626 u=mistral | fatal: [fws-shk01-fcn02]: FAILED! => {"changed": false, "msg": "Unable to stop service auditd: Failed to stop auditd.service: Operation refused, unit auditd.service may be requested by dependency only (it is configured to refuse manual start/stop).\nSee system logs and 'systemctl status auditd.service' for details.\n"}
2020-01-18 02:00:45,479 p=136626 u=mistral | PLAY RECAP *********************************************************************
2020-01-18 02:00:45,479 p=136626 u=mistral | fws-shk01-fcn01 : ok=185 changed=86 unreachable=0 failed=1
2020-01-18 02:00:45,479 p=136626 u=mistral | fws-shk01-fcn02 : ok=188 changed=83 unreachable=0 failed=1
2020-01-18 02:00:45,479 p=136626 u=mistral | fws-shk01-fcn03 : ok=188 changed=83 unreachable=0 failed=1
2020-01-18 02:00:45,479 p=136626 u=mistral | Saturday 18 January 2020 02:00:45 +0000 (0:00:00.395) 0:07:26.395 ******
2020-01-18 02:00:45,479 p=136626 u=mistral | ===============================================================================

It seems like auditd service can't be stopped via systemctl and it has to be done via "service auditd stop".

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/queens
Review: https://review.opendev.org/703445

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/703445
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=702988471854dfd0f49e13fd79d860646978be85
Submitter: Zuul
Branch: stable/queens

commit 702988471854dfd0f49e13fd79d860646978be85
Author: Jose Luis Franco Arza <email address hidden>
Date: Mon Jan 20 17:36:37 2020 +0100

    [Queens only] Change auditd stopping upgrade task.

    When upgradring from non-containerized to containerized we
    required to stop the baremetal service. For most of the
    cases using systemctl stop should suffice. However, the
    auditd service can't be stopped via systemctl [0].

    This patch changes the systemctl stop auditd into
    service auditd stop.

    [0] - https://access.redhat.com/solutions/2664811

    Change-Id: If4e4444f5d563049c75d71471c7aefcadf415228
    Closes-Bug: #1860349