[Rocky/Queens] Pacemaker managed templates ovn-dbs and manila-share fail due to wrong Jinja filter

Bug #1860328 reported by Jose Luis Franco
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
tripleo
Fix Released
High
Jose Luis Franco

Bug Description

This Launchpad bug is created to track the issue upstream based on these two BZs:

https://bugzilla.redhat.com/show_bug.cgi?id=1792901 [OSP14]
https://bugzilla.redhat.com/show_bug.cgi?id=1792890 [OSP13]

During the upgrade of the controllers from PIke to Queens, one of the upgrade tasks failed with the following error:

2020-01-18 01:59:07,802 p=136626 u=mistral | TASK [Disable the Manila-Share cluster resource before container upgrade] ******
2020-01-18 01:59:07,802 p=136626 u=mistral | Saturday 18 January 2020 01:59:07 +0000 (0:00:00.372) 0:05:48.717 ******
2020-01-18 01:59:07,895 p=136626 u=mistral | skipping: [fws-shk01-fcn03] => {"changed": false, "skip_reason": "Conditional result was False"}
2020-01-18 01:59:07,991 p=136626 u=mistral | skipping: [fws-shk01-fcn02] => {"changed": false, "skip_reason": "Conditional result was False"}
2020-01-18 01:59:08,005 p=136626 u=mistral | [DEPRECATION WARNING]: Using tests as filters is deprecated. Instead of using
`result|succeeded` use `result is succeeded`. This feature will be removed in
version 2.9. Deprecation warnings can be disabled by setting
deprecation_warnings=False in ansible.cfg.
2020-01-18 01:59:08,009 p=136626 u=mistral | fatal: [fws-shk01-fcn01]: FAILED! => {"msg": "The conditional check 'manila_share_pcs_res|succeeded' failed. The error was: The failed test expects a dictionary\n\nThe error appears to have been in '/var/lib/mistral/527eac46-145c-4244-a399-e8f20cb697e8/Controller/upgrade_tasks.yaml': line 1010, column 5, but may\nbe elsewhere in the file depending on the exact syntax problem.\n\nThe offending line appears to be:\n\n- block:\n - name: Disable the Manila-Share cluster resource before container upgrade\n ^ here\n"}
2020-01-18 01:59:08,096 p=136626 u=mistral | TASK [Update the Manila-Share bundle to use the new container image name] ******
2020-01-18 01:59:08,096 p=136626 u=mistral | Saturday 18 January 2020 01:59:08 +0000 (0:00:00.294) 0:05:49.011 ******

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to tripleo-heat-templates (stable/rocky)

Related fix proposed to branch: stable/rocky
Review: https://review.opendev.org/703367

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tripleo-heat-templates (stable/queens)

Fix proposed to branch: stable/queens
Review: https://review.opendev.org/703368

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-heat-templates (stable/queens)

Reviewed: https://review.opendev.org/703368
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=c13d3fdd0209eba110b64e99baa759a2a357c24e
Submitter: Zuul
Branch: stable/queens

commit c13d3fdd0209eba110b64e99baa759a2a357c24e
Author: Jose Luis Franco Arza <email address hidden>
Date: Mon Jan 20 12:08:56 2020 +0100

    [Queens only] Wrong jinja filter for ovndbs and manila_share _pcs_res facts.

    The ovndbs_pcs_res and manila_share_pcs_res variable stores
    a boolean value as the succeeded filter is being used when
    creating the facts.
    Therefore, the filter in this condition should be bool instead
    of succeeded.

    Change-Id: Ia1b3809a8daf2c6cbb54f9d302b880c6ddb41d45
    Closes-Bug: #1860328

tags: added: in-stable-queens
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on tripleo-heat-templates (stable/rocky)

Change abandoned by Jose Luis Franco (<email address hidden>) on branch: stable/rocky
Review: https://review.opendev.org/703367
Reason: rocky is eol

wes hayutin (weshayutin)
Changed in tripleo:
milestone: ussuri-2 → ussuri-3
wes hayutin (weshayutin)
Changed in tripleo:
milestone: ussuri-3 → ussuri-rc3
Changed in tripleo:
status: Triaged → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/tripleo-heat-templates queens-eol

This issue was fixed in the openstack/tripleo-heat-templates queens-eol release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.