nuage integration broken by assuming existence of standard openvswitch packges

Bug #1858640 reported by Brent Eagles
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
tripleo
Fix Released
Medium
Brent Eagles

Bug Description

Nuage integration replaces stock openvswitch with a package "nuage-openvswitch". This breaks current update/upgrading because of special handling of openvswitch which assumes certain packages are installed (openvswitch/rhosp-openvswitch/openvswitchN.M/etc)

ansible logs:

TASK [Get current OpenvSwitch package name] ************************************
Thursday 26 December 2019 12:37:20 -0500 (0:00:00.121) 0:07:24.640 *****
changed: [overcloud-controller-0] => {"changed": true, "cmd": "rpm -qa | awk -F- '/^(openvswitch[0-9]+\\.[0-9]+-|openvswitch-2)/{print $1}'", "delta": "0:00:01.002803", "end": "2019-12-26 17:37:19.232520", "rc": 0, "start": "2019-12-26 17:37:18.229717", "stderr": "", "stderr_lines": [], "stdout": "", "stdout_lines": []}

TASK [Get version from current OpenvSwitch package] ****************************
Thursday 26 December 2019 12:37:21 -0500 (0:00:01.433) 0:07:26.073 *****
changed: [overcloud-controller-0] => {"changed": true, "cmd": "rpm -qi \"\" | awk '/^Version/{print $NF}'", "delta": "0:00:00.034623", "end": "2019-12-26 17:37:19.550037", "rc": 0, "start": "2019-12-26 17:37:19.515414", "stderr": "", "stderr_lines": [], "stdout": "", "stdout_lines": []}

TASK [split numeric version for OpenvSwitch into parts] ************************
Thursday 26 December 2019 12:37:22 -0500 (0:00:00.340) 0:07:26.414 *****
ok: [overcloud-controller-0] => {"ansible_facts": {"ovs_version_parts": [""]}, "changed": false}

TASK [get major minor version for OpenvSwitch package naming] ******************
Thursday 26 December 2019 12:37:22 -0500 (0:00:00.129) 0:07:26.544 *****
fatal: [overcloud-controller-0]: FAILED! => {"msg": "The task includes an option with an undefined variable. The error was: list object has no element 1\n\nThe error appears to have been in '/var/lib/mistral/0babf1d0-a548-4fd5-b2f5-4a64cad073b0/Controller/update_tasks.yaml': line 367, column 5, but may\nbe elsewhere in the file depending on the exact syntax problem.\n\nThe offending line appears to be:\n\n ovs_version_parts: '{{ ovs_version_out.stdout.split(''.'') }}'\n - name: get major minor version for OpenvSwitch package naming\n ^ here\n"}

PLAY RECAP *********************************************************************
overcloud-controller-0 : ok=81 changed=41 unreachable=0 failed=1

This special handling should probably just be skipped if openvswitch is non-standard (or at least unexpected)

Source RedHat Bugzilla https://bugzilla.redhat.com/show_bug.cgi?id=1787073

Brent Eagles (beagles)
Changed in tripleo:
milestone: none → ussuri-1
status: New → Triaged
importance: Undecided → Medium
assignee: nobody → Brent Eagles (beagles)
tags: added: train-backport-potential
tags: added: queens-backport-potential rocky-backport-potential stein-backport-potential
Changed in tripleo:
status: Triaged → In Progress
Changed in tripleo:
milestone: ussuri-1 → ussuri-2
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-heat-templates (master)

Reviewed: https://review.opendev.org/701383
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=f907d061ba1d8cf6fbd15fc242b162c618a70154
Submitter: Zuul
Branch: master

commit f907d061ba1d8cf6fbd15fc242b162c618a70154
Author: Brent Eagles <email address hidden>
Date: Tue Jan 7 11:27:19 2020 -0330

    Bypass openvswitch update logic if expected packages are not present

    The nuage integration uses a different package name for openvswitch,
    breaking the update steps. This patch bypasses the update logic if the
    expected packages are not present allowing nuage deployments to manage
    the openvswitch package some other other way.

    Closes-Bug: #1858640
    Change-Id: I8c116aba50cc7f1cb7cd3fd32cf8aec868e074ec

Changed in tripleo:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tripleo-heat-templates (stable/train)

Fix proposed to branch: stable/train
Review: https://review.opendev.org/702677

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tripleo-heat-templates (stable/queens)

Fix proposed to branch: stable/queens
Review: https://review.opendev.org/703089

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-heat-templates (stable/train)

Reviewed: https://review.opendev.org/702677
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=4d21352e3004b2ef94fc5309b6225b538eaab46e
Submitter: Zuul
Branch: stable/train

commit 4d21352e3004b2ef94fc5309b6225b538eaab46e
Author: Brent Eagles <email address hidden>
Date: Tue Jan 7 11:27:19 2020 -0330

    Bypass openvswitch update logic if expected packages are not present

    The nuage integration uses a different package name for openvswitch,
    breaking the update steps. This patch bypasses the update logic if the
    expected packages are not present allowing nuage deployments to manage
    the openvswitch package some other other way.

    Closes-Bug: #1858640
    Change-Id: I8c116aba50cc7f1cb7cd3fd32cf8aec868e074ec
    (cherry picked from commit f907d061ba1d8cf6fbd15fc242b162c618a70154)

tags: added: in-stable-train
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tripleo-heat-templates (stable/rocky)

Fix proposed to branch: stable/rocky
Review: https://review.opendev.org/703795

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-heat-templates (stable/queens)

Reviewed: https://review.opendev.org/703089
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=d3607bcb7a1a85e49af986c878903b9592472373
Submitter: Zuul
Branch: stable/queens

commit d3607bcb7a1a85e49af986c878903b9592472373
Author: Brent Eagles <email address hidden>
Date: Fri Jan 17 10:31:05 2020 -0330

    Bypass openvswitch update logic if expected packages are not present

    The nuage integration uses a different package name for openvswitch,
    breaking the update steps. This patch bypasses the update logic if the
    expected packages are not present allowing nuage deployments to manage
    the openvswitch package some other other way.

    Note:
        Due to path restructuring and file renaming, this is a semantic
        backport of https://review.opendev.org/#/c/702677/. This patch also
        includes similar modifications in the update_tasks for layered
        packaging on queens.
        Original commit: f907d061ba1d8cf6fbd15fc242b162c618a70154

    Change-Id: I282b8b44db5b29b4b9a995b2f2938719ce04a077
    Closes-Bug: #1858640

tags: added: in-stable-queens
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/tripleo-heat-templates 12.1.0

This issue was fixed in the openstack/tripleo-heat-templates 12.1.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/tripleo-heat-templates 11.4.0

This issue was fixed in the openstack/tripleo-heat-templates 11.4.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on tripleo-heat-templates (stable/rocky)

Change abandoned by "Elod Illes <email address hidden>" on branch: stable/rocky
Review: https://review.opendev.org/c/openstack/tripleo-heat-templates/+/703795
Reason: abandoning as tripleo-heat-templates' stable/rocky is End of Life, and to be able to delete the branch all open patches need to be abandoned.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/tripleo-heat-templates queens-eol

This issue was fixed in the openstack/tripleo-heat-templates queens-eol release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.