Error with pre_deployment/post_deployment vars if config-download is disabled

[Emilien Macchi]

The (pre|post)_deployments_'role' variables are only set in group vars when config download is enabled.

It was lately renamed from 'Role'_(pre|post)_deployments and since it has been failing when the variable can't be found.

It's a problem with the default [] which can't be set.

2019-12-12 21:31:55 | TASK [include_tasks] ***********************************************************
2019-12-12 21:31:55 | Thursday 12 December 2019 21:31:55 -0500 (0:00:00.491) 0:00:13.548 *****
2019-12-12 21:31:55 | fatal: [controller-2]: FAILED! => {"msg": "No variable found with this name: pre_deployments_ControllerOpenstack"}
2019-12-12 21:31:55 | fatal: [controller-1]: FAILED! => {"msg": "No variable found with this name: pre_deployments_ControllerOpenstack"}
2019-12-12 21:31:55 | fatal: [controller-0]: FAILED! => {"msg": "No variable found with this name: pre_deployments_ControllerOpenstack"}

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/698893

[OpenStack Infra (hudson-openstack)]

Change abandoned by Emilien Macchi (<email address hidden>) on branch: master
Review: https://review.opendev.org/698893

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/stein
Review: https://review.opendev.org/698907

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/698907
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=44d2502383bc539287cf42ca488773242ad6be9f
Submitter: Zuul
Branch: stable/stein

commit 44d2502383bc539287cf42ca488773242ad6be9f
Author: Emilien Macchi <email address hidden>
Date: Fri Dec 13 08:59:26 2019 -0500

    deploy-steps: use lookup() to get pre|post_deployments_role variables

    Note: this patch is only for Stein and its previous versions.
    Train and master are fine.

    The syntax in place didn't allow to have an empty default for these 2
    vars; which can happen in Queens if config-download is disabled.

    Using the lookup module allows to set a default.

    Change-Id: I38c658e0b0f2e334bd529fe66f937465036cc205
    Closes-Bug: #1856314

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/rocky
Review: https://review.opendev.org/699072

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/queens
Review: https://review.opendev.org/699073

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/699073
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=619228361608b176430a83db66bc350af24110b4
Submitter: Zuul
Branch: stable/queens

commit 619228361608b176430a83db66bc350af24110b4
Author: Emilien Macchi <email address hidden>
Date: Fri Dec 13 08:59:26 2019 -0500

    deploy-steps: use lookup() to get pre|post_deployments_role variables

    Note: this patch is only for Stein and its previous versions.
    Train and master are fine.

    The syntax in place didn't allow to have an empty default for these 2
    vars; which can happen in Queens if config-download is disabled.

    Using the lookup module allows to set a default.

    Change-Id: I38c658e0b0f2e334bd529fe66f937465036cc205
    Closes-Bug: #1856314
    (cherry picked from commit 44d2502383bc539287cf42ca488773242ad6be9f)

[OpenStack Infra (hudson-openstack)]

Change abandoned by Emilien Macchi (<email address hidden>) on branch: stable/rocky
Review: https://review.opendev.org/699072
Reason: Clearing the gate now, see https://bugs.launchpad.net/tripleo/+bug/1856864
Do not restore the patch yet, I'll take care of it when the gate is back online.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/699072
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=c8912671511b570bc997356000b94ee9a0b326e6
Submitter: Zuul
Branch: stable/rocky

commit c8912671511b570bc997356000b94ee9a0b326e6
Author: Emilien Macchi <email address hidden>
Date: Fri Dec 13 08:59:26 2019 -0500

    deploy-steps: use lookup() to get pre|post_deployments_role variables

    Note: this patch is only for Stein and its previous versions.
    Train and master are fine.

    The syntax in place didn't allow to have an empty default for these 2
    vars; which can happen in Queens if config-download is disabled.

    Using the lookup module allows to set a default.

    Change-Id: I38c658e0b0f2e334bd529fe66f937465036cc205
    Closes-Bug: #1856314
    (cherry picked from commit 44d2502383bc539287cf42ca488773242ad6be9f)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates rocky-eol release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates queens-eol release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates stein-eol release.