tuned fails if using --dry-run

Bug #1855502 reported by Alex Schultz
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
tripleo
Fix Released
High
Alex Schultz

Bug Description

TASK [tuned : include_tasks] ***************************************************
fatal: [controller-0]: FAILED! => {"msg": "The conditional check 'tuned_check.rc == 0' failed. The error was: error while evaluating conditional (tuned_check.rc == 0): 'dict object' has no attribute 'rc'\n\nThe error appears to be in '/usr/share/ansible/roles/tuned/tasks/main.yml': line 47, column 3, but may\nbe elsewhere in the file depending on the exact syntax problem.\n\nThe offending line appears to be:\n\n\n- include_tasks: tuned_config.yml\n ^ here\n"}
fatal: [controller-1]: FAILED! => {"msg": "The conditional check 'tuned_check.rc == 0' failed. The error was: error while evaluating conditional (tuned_check.rc == 0): 'dict object' has no attribute 'rc'\n\nThe error appears to be in '/usr/share/ansible/roles/tuned/tasks/main.yml': line 47, column 3, but may\nbe elsewhere in the file depending on the exact syntax problem.\n\nThe offending line appears to be:\n\n\n- include_tasks: tuned_config.yml\n ^ here\n"}
fatal: [controller-2]: FAILED! => {"msg": "The conditional check 'tuned_check.rc == 0' failed. The error was: error while evaluating conditional (tuned_check.rc == 0): 'dict object' has no attribute 'rc'\n\nThe error appears to be in '/usr/share/ansible/roles/tuned/tasks/main.yml': line 47, column 3, but may\nbe elsewhere in the file depending on the exact syntax problem.\n\nThe offending line appears to be:\n\n\n- include_tasks: tuned_config.yml\n ^ here\n"}
skipping: [compute-0]
skipping: [compute-1]

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tripleo-ansible (master)

Fix proposed to branch: master
Review: https://review.opendev.org/697732

Changed in tripleo:
assignee: nobody → Alex Schultz (alex-schultz)
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-ansible (master)

Reviewed: https://review.opendev.org/697732
Committed: https://git.openstack.org/cgit/openstack/tripleo-ansible/commit/?id=08c965dcaae295e67ea68e98930b98a4aa4a1d50
Submitter: Zuul
Branch: master

commit 08c965dcaae295e67ea68e98930b98a4aa4a1d50
Author: Alex Schultz <email address hidden>
Date: Fri Dec 6 15:35:24 2019 -0700

    Don't include tuned tasks when checkmode

    We don't get a tuned_check when in check mode so we should just skip the
    config include.

    Change-Id: Ic9d364d0f440b9308d57c2ebf07fbc12f6403c66
    Closes-Bug: #1855502

Changed in tripleo:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tripleo-ansible (stable/train)

Fix proposed to branch: stable/train
Review: https://review.opendev.org/697837

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-ansible (stable/train)

Reviewed: https://review.opendev.org/697837
Committed: https://git.openstack.org/cgit/openstack/tripleo-ansible/commit/?id=aacb8c3daafa1ca4c8ad48c7c0b889f764d930d4
Submitter: Zuul
Branch: stable/train

commit aacb8c3daafa1ca4c8ad48c7c0b889f764d930d4
Author: Alex Schultz <email address hidden>
Date: Fri Dec 6 15:35:24 2019 -0700

    Don't include tuned tasks when checkmode

    We don't get a tuned_check when in check mode so we should just skip the
    config include.

    Change-Id: Ic9d364d0f440b9308d57c2ebf07fbc12f6403c66
    Closes-Bug: #1855502
    (cherry picked from commit 08c965dcaae295e67ea68e98930b98a4aa4a1d50)

tags: added: in-stable-train
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/tripleo-ansible 0.4.1

This issue was fixed in the openstack/tripleo-ansible 0.4.1 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/tripleo-ansible 1.1.0

This issue was fixed in the openstack/tripleo-ansible 1.1.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.