tripleo container image push fails with a traceback

[Alex Schultz]

Traceback (most recent call last):
  File "/usr/lib/python3.6/site-packages/osc_lib/shell.py", line 136, in run
    ret_val = super(OpenStackShell, self).run(argv)
  File "/usr/lib/python3.6/site-packages/cliff/app.py", line 281, in run
    result = self.run_subcommand(remainder)
  File "/usr/lib/python3.6/site-packages/osc_lib/shell.py", line 176, in run_subcommand
    ret_value = super(OpenStackShell, self).run_subcommand(argv)
  File "/usr/lib/python3.6/site-packages/cliff/app.py", line 401, in run_subcommand
    result = cmd.run(parsed_args)
  File "/usr/lib/python3.6/site-packages/tripleoclient/command.py", line 32, in run
    super(Command, self).run(parsed_args)
  File "/usr/lib/python3.6/site-packages/osc_lib/command/command.py", line 41, in run
    return super(Command, self).run(parsed_args)
  File "/usr/lib/python3.6/site-packages/cliff/command.py", line 185, in run
    return_code = self.take_action(parsed_args) or 0
  File "/usr/lib/python3.6/site-packages/tripleoclient/v1/container_image.py", line 647, in take_action
    uploader.run_tasks()
  File "/usr/lib/python3.6/site-packages/tripleo_common/image/image_uploader.py", line 2197, in run_tasks
    for result in p.map(upload_task, self.upload_tasks):
  File "/usr/lib64/python3.6/concurrent/futures/_base.py", line 586, in result_iterator
    yield fs.pop().result()
  File "/usr/lib64/python3.6/concurrent/futures/_base.py", line 432, in result
    return self.__get_result()
  File "/usr/lib64/python3.6/concurrent/futures/_base.py", line 384, in __get_result
    raise self._exception
  File "/usr/lib64/python3.6/concurrent/futures/thread.py", line 56, in run
    result = self.fn(*self.args, **self.kwargs)
  File "/usr/lib/python3.6/site-packages/tripleo_common/image/image_uploader.py", line 2256, in upload_task
    return uploader.upload_image(task)
  File "/usr/lib/python3.6/site-packages/tripleo_common/image/image_uploader.py", line 1326, in upload_image
    session=target_session)
  File "/usr/lib/python3.6/site-packages/tenacity/__init__.py", line 292, in wrapped_f
    return self.call(f, *args, **kw)
  File "/usr/lib/python3.6/site-packages/tenacity/__init__.py", line 358, in call
    do = self.iter(retry_state=retry_state)
  File "/usr/lib/python3.6/site-packages/tenacity/__init__.py", line 319, in iter
    return fut.result()
  File "/usr/lib64/python3.6/concurrent/futures/_base.py", line 425, in result
    return self.__get_result()
  File "/usr/lib64/python3.6/concurrent/futures/_base.py", line 384, in __get_result
    raise self._exception
  File "/usr/lib/python3.6/site-packages/tenacity/__init__.py", line 361, in call
    result = fn(*args, **kwargs)
  File "/usr/lib/python3.6/site-packages/tripleo_common/image/image_uploader.py", line 917, in _cross_repo_mount
    uploaded_layers=cls._global_view_proxy())
  File "/usr/lib/python3.6/site-packages/tripleo_common/image/image_export.py", line 174, in cross_repo_mount
    uploaded_layers, layer, scope='local')
  File "/usr/lib/python3.6/site-packages/tripleo_common/utils/image.py", line 22, in uploaded_layers_details
    known_layer = uploaded_layers.get(layer, None)
AttributeError: 'NoneType' object has no attribute 'get'

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/697372

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/697372
Committed: https://git.openstack.org/cgit/openstack/python-tripleoclient/commit/?id=94f8ef1df8d2a642c89fcb2838d0b8666aac0b08
Submitter: Zuul
Branch: master

commit 94f8ef1df8d2a642c89fcb2838d0b8666aac0b08
Author: Alex Schultz <email address hidden>
Date: Wed Dec 4 14:27:42 2019 -0700

    Add locks to container image commands

    Ie5ef4045b7e22c06551e886f9f9b6f22c8d4bd21 added some additional
    processing when uploading images. This unfortunately broke the
    'openstack tripleo container image push' command because it assumes a
    lock is always available. This change adds a process lock to the
    ImageManagers used by the cli to ensure we are locking correctly when
    doing any multiprocessing

    Change-Id: I2d661682b3ee4d82d9f445a04e930c2fb328ef80
    Closes-Bug: #1855184

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/train
Review: https://review.opendev.org/697615

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/697615
Committed: https://git.openstack.org/cgit/openstack/python-tripleoclient/commit/?id=1a49259357a58900dd4c9e620d7e0dacbfab2f07
Submitter: Zuul
Branch: stable/train

commit 1a49259357a58900dd4c9e620d7e0dacbfab2f07
Author: Alex Schultz <email address hidden>
Date: Wed Dec 4 14:27:42 2019 -0700

    Add locks to container image commands

    Ie5ef4045b7e22c06551e886f9f9b6f22c8d4bd21 added some additional
    processing when uploading images. This unfortunately broke the
    'openstack tripleo container image push' command because it assumes a
    lock is always available. This change adds a process lock to the
    ImageManagers used by the cli to ensure we are locking correctly when
    doing any multiprocessing

    Change-Id: I2d661682b3ee4d82d9f445a04e930c2fb328ef80
    Closes-Bug: #1855184
    (cherry picked from commit 94f8ef1df8d2a642c89fcb2838d0b8666aac0b08)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/python-tripleoclient 12.3.1 release.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/stein
Review: https://review.opendev.org/701568

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/701568
Committed: https://git.openstack.org/cgit/openstack/python-tripleoclient/commit/?id=fe332308f037d43420d2535161e504b93c89c396
Submitter: Zuul
Branch: stable/stein

commit fe332308f037d43420d2535161e504b93c89c396
Author: Alex Schultz <email address hidden>
Date: Wed Dec 4 14:27:42 2019 -0700

    Add locks to container image commands

    Ie5ef4045b7e22c06551e886f9f9b6f22c8d4bd21 added some additional
    processing when uploading images. This unfortunately broke the
    'openstack tripleo container image push' command because it assumes a
    lock is always available. This change adds a process lock to the
    ImageManagers used by the cli to ensure we are locking correctly when
    doing any multiprocessing

    Change-Id: I2d661682b3ee4d82d9f445a04e930c2fb328ef80
    Closes-Bug: #1855184
    (cherry picked from commit 94f8ef1df8d2a642c89fcb2838d0b8666aac0b08)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/python-tripleoclient 13.1.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/python-tripleoclient stein-eol release.