paunch pulls the image even when it exists when using podman

[Michele Baldessari]

paunch seems to be calling podman pull even when podman image exists returns 0. This creates unneeded IO pressure.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/697302

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/697302
Committed: https://git.openstack.org/cgit/openstack/paunch/commit/?id=14fa098fcb6a36eff0c7e965e86c5ec6ce112c81
Submitter: Zuul
Branch: master

commit 14fa098fcb6a36eff0c7e965e86c5ec6ce112c81
Author: Michele Baldessari <email address hidden>
Date: Wed Dec 4 15:52:25 2019 +0100

    Do not always needlessly pull the images via podman

    Via https://review.opendev.org/#/c/665731/ there was a tentative
    reduction of podman inspect calls. The problem was that a podman
    pull was performed even when the image already existed due to
    a wrong if check, since image_exist() returns true/false and not
    the return code of the podman image shell command.

    Closes-Bug: #1855128
    Co-Authored-By: Damien Ciabrini <email address hidden>

    Change-Id: Ia0c71de6a0a1fe243a39dbd7b1458610b81bd6be

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/train
Review: https://review.opendev.org/697414

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/697414
Committed: https://git.openstack.org/cgit/openstack/paunch/commit/?id=912a5743584c4fc7ff453bf06bebf48da8553efc
Submitter: Zuul
Branch: stable/train

commit 912a5743584c4fc7ff453bf06bebf48da8553efc
Author: Michele Baldessari <email address hidden>
Date: Wed Dec 4 15:52:25 2019 +0100

    Do not always needlessly pull the images via podman

    Via https://review.opendev.org/#/c/665731/ there was a tentative
    reduction of podman inspect calls. The problem was that a podman
    pull was performed even when the image already existed due to
    a wrong if check, since image_exist() returns true/false and not
    the return code of the podman image shell command.

    Closes-Bug: #1855128
    Co-Authored-By: Damien Ciabrini <email address hidden>

    Change-Id: Ia0c71de6a0a1fe243a39dbd7b1458610b81bd6be
    (cherry picked from commit 14fa098fcb6a36eff0c7e965e86c5ec6ce112c81)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/697560
Committed: https://git.openstack.org/cgit/openstack/paunch/commit/?id=a4bac4834fe918fcfa14007aba972ed823a98464
Submitter: Zuul
Branch: stable/stein

commit a4bac4834fe918fcfa14007aba972ed823a98464
Author: Michele Baldessari <email address hidden>
Date: Wed Dec 4 15:52:25 2019 +0100

    Do not always needlessly pull the images via podman

    Via https://review.opendev.org/#/c/665731/ there was a tentative
    reduction of podman inspect calls. The problem was that a podman
    pull was performed even when the image already existed due to
    a wrong if check, since image_exist() returns true/false and not
    the return code of the podman image shell command.

    Closes-Bug: #1855128
    Co-Authored-By: Damien Ciabrini <email address hidden>

    Change-Id: Ia0c71de6a0a1fe243a39dbd7b1458610b81bd6be
    (cherry picked from commit 14fa098fcb6a36eff0c7e965e86c5ec6ce112c81)
    (cherry picked from commit 912a5743584c4fc7ff453bf06bebf48da8553efc)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/paunch 5.3.1 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/paunch 6.0.1 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/paunch stein-eol release.