overcloudrc ends up with an invalid no_proxy

Bug #1854868 reported by Alex Schultz
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
tripleo
Fix Released
Low
Alex Schultz

Bug Description

If the system no_proxy configuration contains spaces, the resulting overcloudrc file ends up being incorrectly generated.

# cat /etc/profile.d/proxy.sh
PROXY_ENABLED="yes"
export http_proxy="http://myhost.com:8080"
export https_proxy="http://myhost.com:8080"
export no_proxy="localhost, 127.0.0.1, myhost.com"

Follows overcloudrc file after the deployment
# cat overcloudrc | grep proxy
export no_proxy=localhost, 127.0.0.1, myhost.com

Follows when I source the overcloudrc file.
source overcloudrc
bash: export: `127.0.0.1,': not a valid identifier
bash: export: `myhost.com': not a valid identifier

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tripleo-common (master)

Fix proposed to branch: master
Review: https://review.opendev.org/696985

Changed in tripleo:
assignee: nobody → Alex Schultz (alex-schultz)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-common (master)

Reviewed: https://review.opendev.org/696985
Committed: https://git.openstack.org/cgit/openstack/tripleo-common/commit/?id=5d44457ae16ebb3298143e04dbf0c0c5e5249553
Submitter: Zuul
Branch: master

commit 5d44457ae16ebb3298143e04dbf0c0c5e5249553
Author: Alex Schultz <email address hidden>
Date: Mon Dec 2 16:20:30 2019 -0700

    Quote output values for overcloudrc

    If the overcloudrc values have spaces, we need to quote them to ensure
    it gets parsed correctly.

    Change-Id: I06995dee0ec7eabda16793aa42cae7197c4959f5
    Closes-Bug: #1854868

Changed in tripleo:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tripleo-common (stable/train)

Fix proposed to branch: stable/train
Review: https://review.opendev.org/697481

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tripleo-common (stable/stein)

Fix proposed to branch: stable/stein
Review: https://review.opendev.org/697482

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tripleo-common (stable/rocky)

Fix proposed to branch: stable/rocky
Review: https://review.opendev.org/697483

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tripleo-common (stable/queens)

Fix proposed to branch: stable/queens
Review: https://review.opendev.org/697484

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-common (stable/queens)

Reviewed: https://review.opendev.org/697484
Committed: https://git.openstack.org/cgit/openstack/tripleo-common/commit/?id=e6938afd5c6bdf800b8945a30c162b594a96b0c3
Submitter: Zuul
Branch: stable/queens

commit e6938afd5c6bdf800b8945a30c162b594a96b0c3
Author: Alex Schultz <email address hidden>
Date: Mon Dec 2 16:20:30 2019 -0700

    Quote output values for overcloudrc

    If the overcloudrc values have spaces, we need to quote them to ensure
    it gets parsed correctly.

    Change-Id: I06995dee0ec7eabda16793aa42cae7197c4959f5
    Closes-Bug: #1854868
    (cherry picked from commit 5d44457ae16ebb3298143e04dbf0c0c5e5249553)

tags: added: in-stable-queens
tags: added: in-stable-stein
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-common (stable/stein)

Reviewed: https://review.opendev.org/697482
Committed: https://git.openstack.org/cgit/openstack/tripleo-common/commit/?id=d5d85db409478b07fe4392314f8d9b72142e9a9f
Submitter: Zuul
Branch: stable/stein

commit d5d85db409478b07fe4392314f8d9b72142e9a9f
Author: Alex Schultz <email address hidden>
Date: Mon Dec 2 16:20:30 2019 -0700

    Quote output values for overcloudrc

    If the overcloudrc values have spaces, we need to quote them to ensure
    it gets parsed correctly.

    Change-Id: I06995dee0ec7eabda16793aa42cae7197c4959f5
    Closes-Bug: #1854868
    (cherry picked from commit 5d44457ae16ebb3298143e04dbf0c0c5e5249553)

tags: added: in-stable-train
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-common (stable/train)

Reviewed: https://review.opendev.org/697481
Committed: https://git.openstack.org/cgit/openstack/tripleo-common/commit/?id=79e457cf86899cef7096d58b5031c33b99fba424
Submitter: Zuul
Branch: stable/train

commit 79e457cf86899cef7096d58b5031c33b99fba424
Author: Alex Schultz <email address hidden>
Date: Mon Dec 2 16:20:30 2019 -0700

    Quote output values for overcloudrc

    If the overcloudrc values have spaces, we need to quote them to ensure
    it gets parsed correctly.

    Change-Id: I06995dee0ec7eabda16793aa42cae7197c4959f5
    Closes-Bug: #1854868
    (cherry picked from commit 5d44457ae16ebb3298143e04dbf0c0c5e5249553)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-common (stable/rocky)

Reviewed: https://review.opendev.org/697483
Committed: https://git.openstack.org/cgit/openstack/tripleo-common/commit/?id=2756402cb181303801518abffc89bb0a90446b55
Submitter: Zuul
Branch: stable/rocky

commit 2756402cb181303801518abffc89bb0a90446b55
Author: Alex Schultz <email address hidden>
Date: Mon Dec 2 16:20:30 2019 -0700

    Quote output values for overcloudrc

    If the overcloudrc values have spaces, we need to quote them to ensure
    it gets parsed correctly.

    Depends-On: https://review.opendev.org/#/c/699010/
    Change-Id: I06995dee0ec7eabda16793aa42cae7197c4959f5
    Closes-Bug: #1854868
    (cherry picked from commit 5d44457ae16ebb3298143e04dbf0c0c5e5249553)

tags: added: in-stable-rocky
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/tripleo-common 11.3.2

This issue was fixed in the openstack/tripleo-common 11.3.2 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/tripleo-common 12.1.0

This issue was fixed in the openstack/tripleo-common 12.1.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/tripleo-common rocky-eol

This issue was fixed in the openstack/tripleo-common rocky-eol release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/tripleo-common queens-eol

This issue was fixed in the openstack/tripleo-common queens-eol release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/tripleo-common stein-eol

This issue was fixed in the openstack/tripleo-common stein-eol release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.