Ironic Inspector dnsmasq incorrectly configured to do DHCPv6-stateful when IPv6 addressmode is DHCPv6-stateless

Bug #1853334 reported by Harald Jensås
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
tripleo
Fix Released
High
Harald Jensås

Bug Description

undercloud.conf
---------------
[DEFAULT]

templates = /home/centos/tripleo-heat-templates
container_images_file = /home/centos/containers-prepare-parameter.yaml

enable_routed_networks = true
enable_ui = false
overcloud_domain_name = localdomain
scheduler_max_attempts = 2
undercloud_ntp_servers = pool.ntp.org
undercloud_hostname = undercloud.rdocloud
local_interface = eth1
local_mtu = 1450
local_ip = fd12:3456:789a:1::1/64
undercloud_public_host = fd12:3456:789a:1::2
undercloud_admin_host = fd12:3456:789a:1::3
undercloud_nameservers = 8.8.8.8,8.8.4.4
local_subnet = ctlplane-subnet
subnets = ctlplane-subnet
ipv6_address_mode = dhcpv6-stateless

[ctlplane-subnet]
cidr = fd12:3456:789a:1::/64
gateway = fd12:3456:789a:1::fffe
dns_nameservers = fd12:3456:789a:1::1
inspection_iprange = fd12:3456:789a:1::aaaa,fd12:3456:789a:1::afff
masquerade = false

Reslting config:

[root@undercloud ~]# grep dhcp-range /var/lib/config-data/puppet-generated/ironic_inspector/etc/ironic-inspector/dnsmasq.conf
dhcp-range=set:ctlplane-subnet,fd12:3456:789a:1::aaaa,fd12:3456:789a:1::afff,64,10m

 ironic-inspector/dnsmasq.conf is configured for DHCPv6-stateful operation ^^. This is incorrect, the range should be:

 dhcp-range=set:ctlplane-subnet,fd12:3456:789a:1::,static

From : dnsmasq(8) manual page:

 A static-only subnet with address all zeros may be used as a "catch-all" address to enable replies to all Information-request packets on a subnet which is provided with stateless DHCPv6, ie --dhcp-range=::,static

description: updated
Revision history for this message
Harald Jensås (harald-jensas) wrote :

Looks like a config like below works, and fit's with what puppet-ironic can do ...
  dhcp-range=set:ctlplane-subnet,fd12:3456:789a:1::,static,64,10m

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-tripleoclient (master)

Fix proposed to branch: master
Review: https://review.opendev.org/695294

Changed in tripleo:
assignee: nobody → Harald Jensås (harald-jensas)
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-tripleoclient (master)

Reviewed: https://review.opendev.org/695294
Committed: https://git.openstack.org/cgit/openstack/python-tripleoclient/commit/?id=69eec5ce08a4adbeb315dda00dd2990657930506
Submitter: Zuul
Branch: master

commit 69eec5ce08a4adbeb315dda00dd2990657930506
Author: Harald Jensås <email address hidden>
Date: Wed Nov 20 20:13:34 2019 +0100

    Fix inspector ip range for dhcpv6-stateless

    When using dhcpv6-stateless a range should not be
    used. According to dnsmasq manual page:

      A static-only subnet with address all zeros may be
      used as a "catch-all" address to enable replies to
      all Information-request packets on a subnet which
      is provided with stateless DHCPv6, ie
      --dhcp-range=::,static

    Closes-Bug: #1853334
    Change-Id: I6627da48bc170f7ecccaf84c0fccda9e2edd5af3

Changed in tripleo:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-tripleoclient (stable/train)

Fix proposed to branch: stable/train
Review: https://review.opendev.org/696352

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-tripleoclient (stable/train)

Reviewed: https://review.opendev.org/696352
Committed: https://git.openstack.org/cgit/openstack/python-tripleoclient/commit/?id=46c5fb4bd7138038e8ebf9aaf3a2690d5922f6fe
Submitter: Zuul
Branch: stable/train

commit 46c5fb4bd7138038e8ebf9aaf3a2690d5922f6fe
Author: Harald Jensås <email address hidden>
Date: Wed Nov 20 20:13:34 2019 +0100

    Fix inspector ip range for dhcpv6-stateless

    When using dhcpv6-stateless a range should not be
    used. According to dnsmasq manual page:

      A static-only subnet with address all zeros may be
      used as a "catch-all" address to enable replies to
      all Information-request packets on a subnet which
      is provided with stateless DHCPv6, ie
      --dhcp-range=::,static

    Closes-Bug: #1853334
    Change-Id: I6627da48bc170f7ecccaf84c0fccda9e2edd5af3
    (cherry picked from commit 69eec5ce08a4adbeb315dda00dd2990657930506)

tags: added: in-stable-train
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/python-tripleoclient 12.3.1

This issue was fixed in the openstack/python-tripleoclient 12.3.1 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/python-tripleoclient 13.1.0

This issue was fixed in the openstack/python-tripleoclient 13.1.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.