Config download with blacklisted nodes (DeploymentServerBlacklist) fails with KeyError for NetworkConfig

[Rabi Mishra]

Traceback from mistral logs:

2019-11-17 05:33:44.274 7 WARNING mistral.executors.default_executor [req-3b389857-c2ef-4223-b039-2cd72f275e2e 0253185b0727471ca2983c94ac019df1 355d8393d3ad4f51999dc6a24b753223 - default default] The action raised an exception [action_ex_id=27c39026-5a79-4acb-9400-bd1cc037e87e, msg=''networker-0'', action_cls='<class 'mistral.actions.action_factory.GetOvercloudConfig'>', attributes='{}', params='{'container': 'overcloud', 'container_config': 'overcloud-config'}']: KeyError: 'networker-0'
2019-11-17 05:33:44.274 7 ERROR mistral.executors.default_executor Traceback (most recent call last):
2019-11-17 05:33:44.274 7 ERROR mistral.executors.default_executor File "/usr/lib/python3.6/site-packages/mistral/executors/default_executor.py", line 114, in run_action
2019-11-17 05:33:44.274 7 ERROR mistral.executors.default_executor result = action.run(action_ctx)
2019-11-17 05:33:44.274 7 ERROR mistral.executors.default_executor File "/usr/lib/python3.6/site-packages/tripleo_common/actions/config.py", line 87, in run
2019-11-17 05:33:44.274 7 ERROR mistral.executors.default_executor commit_message=message)
2019-11-17 05:33:44.274 7 ERROR mistral.executors.default_executor File "/usr/lib/python3.6/site-packages/tripleo_common/utils/config.py", line 547, in download_config
2019-11-17 05:33:44.274 7 ERROR mistral.executors.default_executor self.write_config(stack, name, config_dir, config_type)
2019-11-17 05:33:44.274 7 ERROR mistral.executors.default_executor File "/usr/lib/python3.6/site-packages/tripleo_common/utils/config.py", line 524, in write_config
2019-11-17 05:33:44.274 7 ERROR mistral.executors.default_executor self.render_network_config(stack, config_dir, server_roles)
2019-11-17 05:33:44.274 7 ERROR mistral.executors.default_executor File "/usr/lib/python3.6/site-packages/tripleo_common/utils/config.py", line 207, in render_network_config
2019-11-17 05:33:44.274 7 ERROR mistral.executors.default_executor config_dir, server_roles[server], server)
2019-11-17 05:33:44.274 7 ERROR mistral.executors.default_executor KeyError: 'networker-0'
2019-11-17 05:33:44.274 7 ERROR mistral.executors.default_executor

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/695142

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/695142
Committed: https://git.openstack.org/cgit/openstack/tripleo-common/commit/?id=750a47956376b7e790744e3392d784aa8cfc3f86
Submitter: Zuul
Branch: master

commit 750a47956376b7e790744e3392d784aa8cfc3f86
Author: Rabi Mishra <email address hidden>
Date: Wed Nov 20 12:51:49 2019 +0530

    Ignore blacklisted nodes when rendering network config

    We don't include nodes blacklisted with 'DeploymentServerBlacklist'
    in 'ServerIdData' stack output, that is used to populate
    'server_roles' dict. Let's ignore writing NetworkConfig for those.

    Change-Id: I837ed2dd7937a87055a8acff686ca3165dba3837
    Closes-Bug: #1853247

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/train
Review: https://review.opendev.org/695348

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/695348
Committed: https://git.openstack.org/cgit/openstack/tripleo-common/commit/?id=b2142524fec4cce868d57e1561b19adea6f28b22
Submitter: Zuul
Branch: stable/train

commit b2142524fec4cce868d57e1561b19adea6f28b22
Author: Rabi Mishra <email address hidden>
Date: Wed Nov 20 12:51:49 2019 +0530

    Ignore blacklisted nodes when rendering network config

    We don't include nodes blacklisted with 'DeploymentServerBlacklist'
    in 'ServerIdData' stack output, that is used to populate
    'server_roles' dict. Let's ignore writing NetworkConfig for those.

    Change-Id: I837ed2dd7937a87055a8acff686ca3165dba3837
    Closes-Bug: #1853247
    (cherry picked from commit 750a47956376b7e790744e3392d784aa8cfc3f86)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-common 12.0.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-common 11.3.2 release.