update of docker package causes network outage

[Lukas Bezdicka]

Stopping all containers is very bad idea especially during minor update.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/queens
Review: https://review.opendev.org/693571

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/693574

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/693571
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=3e2f5658413cd31dd54933d0aed93da0068aed7e
Submitter: Zuul
Branch: stable/queens

commit 3e2f5658413cd31dd54933d0aed93da0068aed7e
Author: Lukas Bezdicka <email address hidden>
Date: Fri Nov 8 19:19:51 2019 +0100

    [queens only] Keep ceph and neutron side containers running during Update

    If docker package gets updated we just stop docker containers. This
    causes minor outage in ceph which it recovers from but it also
    causes outage in neutron which it never recovers from unless the
    routers get recreated.

    Closes-Bug: #1851872
    Change-Id: I3457dd4c936798299e78fc13b2c06e158ed26f45

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/693574
Committed: https://git.openstack.org/cgit/openstack/ansible-role-container-registry/commit/?id=7a2a664a8431d5427bb20474a770dd4cbb5da2e3
Submitter: Zuul
Branch: master

commit 7a2a664a8431d5427bb20474a770dd4cbb5da2e3
Author: Lukas Bezdicka <email address hidden>
Date: Fri Nov 8 19:35:44 2019 +0100

    Don't stop containers before docker package update

    Back in Openstack Pike release we hit issue with docker having
    changes applied via puppet causing restart of docker service
    without --live-restore option. This approach was buggous from the
    begining and it's definetly obsolete here. We do only minor updates of
    OS during release so we do only patch level updates of docker.

    Change-Id: Iff4823d72c4d50838b6997398b23e76cec50ca56
    RefBug: #1747851
    Closes-Bug: #1851872

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates queens-eol release.