Description of problem:
When using an External LB the update playbook are still created with the haproxy resources. This creates issues for updates as the haproxy plays are still added to the Controller/update_tasks.yaml file which will fail since there is no haproxy-bundle.
Minor updates fail in the Controller/update_tasks.yaml playbook. When it tries to work with haproxy-bundle. Which doesn't exist because we're using a External LB.
Version-Release number of selected component (if applicable):
RHOSP13
How reproducible:
Easily with enough resources
Steps to Reproduce:
1. Deploy the Overcloud with external LB as per the above document
2. Run the update prepare
3. Run the update on the controllers openstack overcloud update run --node Controller
Actual results:
TASK [Disable the haproxy cluster resource] ************************************
Friday 01 November 2019 20:56:22 -0400 (0:00:00.373) 0:37:50.310 *******
FAILED - RETRYING: Disable the haproxy cluster resource (5 retries left).
FAILED - RETRYING: Disable the haproxy cluster resource (4 retries left).
FAILED - RETRYING: Disable the haproxy cluster resource (3 retries left).
FAILED - RETRYING: Disable the haproxy cluster resource (2 retries left).
FAILED - RETRYING: Disable the haproxy cluster resource (1 retries left).
fatal: [controller-0]: FAILED! => {"attempts": 5, "changed": false, "error": "Error: bundle/clone/group/master/resource 'haproxy-bundle' does not exist\n", "msg": "
Failed, to set the resource haproxy-bundle to the state disable", "output": "", "rc": 1}
PLAY RECAP *********************************************************************
controller-0 : ok=22 changed=3 unreachable=0 failed=1
Expected results:
If we include EnableLoadBalancer: False in the templates, we should be skipping the update_tasks related to haproxy
Fix proposed to branch: master
Review: https:/