Standalone with push_destination: true errors: Error: unable to pull localhost:8787/tripleomaster...

[Harald Jensås]

"2019-10-24 02:56:08,869 ERROR: 20177 -- ['/usr/bin/podman', 'run', '--user', 'root', '--name', u'container-puppet-keystone', '--env', u'PUPPET_TAGS=file,file_line,concat,augeas,cron,keystone_config,keystone_domain_config', '--env', u'NAME=keystone', '--env', u'HOSTNAME=leafs', '--env', 'NO_ARCHIVE=', '--env', 'STEP=6', '--env', 'NET_HOST=true', '--env', 'DEBUG=False', '--volume', '/etc/localtime:/etc/localtime:ro', '--volume', '/tmp/tmp8HC3ZR:/etc/config.pp:ro', '--volume', '/etc/puppet/:/tmp/puppet-etc/:ro', '--volume', '/etc/pki/ca-trust/extracted:/etc/pki/ca-trust/extracted:ro', '--volume', '/etc/pki/tls/certs/ca-bundle.crt:/etc/pki/tls/certs/ca-bundle.crt:ro', '--volume', '/etc/pki/tls/certs/ca-bundle.trust.crt:/etc/pki/tls/certs/ca-bundle.trust.crt:ro', '--volume', '/etc/pki/tls/cert.pem:/etc/pki/tls/cert.pem:ro', '--volume', '/var/lib/config-data:/var/lib/config-data/:rw', '--volume', '/var/lib/container-puppet/puppetlabs/facter.conf:/etc/puppetlabs/facter/facter.conf:ro', '--volume', '/var/lib/container-puppet/puppetlabs/:/opt/puppetlabs/:ro', '--volume', '/dev/log:/dev/log:rw', '--rm', '--log-driver', 'k8s-file', '--log-opt', u'path=/var/log/containers/stdouts/container-puppet-keystone.log', '--security-opt', 'label=disable', '--volume', '/usr/share/openstack-puppet/modules/:/usr/share/openstack-puppet/modules/:ro', '--entrypoint', '/var/lib/container-puppet/container-puppet.sh', '--net', 'host', '--volume', '/etc/hosts:/etc/hosts:ro', '--volume', '/var/lib/container-puppet/container-puppet.sh:/var/lib/container-puppet/container-puppet.sh:ro', u'localhost:8787/tripleomaster/centos-binary-keystone:current-tripleo-devel'] run failed after Trying to pull localhost:8787/tripleomaster/centos-binary-keystone:current-tripleo-devel...",

"Error: unable to pull localhost:8787/tripleomaster/centos-binary-keystone:current-tripleo-devel: unable to pull image: Error initializing source docker://localhost:8787/tripleomaster/centos-binary-keystone:current-tripleo-devel: pinging docker registry returned: Get https://localhost:8787/v2/: http: server gave HTTP response to HTTPS client"

get_undercloud_registry() returns 'localhost:8787' when tripleo_common.image.kolla_builder.container_images_prepare was called by tripleoclient.v1.tripleo_deploy.Deploy._prepare_container_images.

(This was true also prior to: https://review.opendev.org/687305, since br-ctlplane does not exist when that is called.)

When deploying standalone with push_destination: true this fails on the first run.

Re-running the deployment works because either hosts are present or br-ctlplane was present.

First run
---------
Standalone/docker_config.yaml: image: localhost:8787/tripleomaster/centos-binary-keystone:current-tripleo-devel

Second run
----------
Standalone/docker_config.yaml: image: 172.20.0.50:8787/tripleomaster/centos-binary-keystone:current-tripleo-devel

[Harald Jensås (harald-jensas)]

It would be trivial to add the entry to /etc/hosts before tripleoclient.v1.tripleo_deploy.Deploy._prepare_container_images executes. But, this would not fix the issue with only having the IP in DockerInsecureRegistryAddress, unless we always fall back to the IP in https://review.opendev.org/690780 (i.e not verify if the IP is in insecure registry, simply assume it is ...)

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/690805

[Alex Schultz (alex-schultz)]

This bug has had a related patch abandoned and has been automatically un-assigned due to inactivity. Please re-assign yourself if you are continuing work or adjust the state as appropriate if it is no longer valid.

[OpenStack Infra (hudson-openstack)]

Change abandoned by Alex Schultz (<email address hidden>) on branch: master
Review: https://review.opendev.org/690805
Reason: This review is > 90 days without comment, and failed Zuul the last time it was checked. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and leaving a 'recheck' comment to get fresh test results. For more details check policy https://specs.openstack.org/openstack/tripleo-specs/specs/policy/patch-abandonment.html