'update' RemovalPoliciesMode can lead to undesired results with node delete
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
tripleo |
Fix Released
|
High
|
Rabi Mishra |
Bug Description
Suppose you've count=3, nodes=['0', '1', '2'], blacklist=[], policy=append
a. node delete ['0']
count=2, nodes=['1', '2'], blacklist=['0'], mode=append, *RemovalPolicies: [{"resource_list": ["0"]}]
b. node delete ['1']
count=1, nodes=['2'], blacklist=['0', '1'], mode=append, *RemovalPolicies: [{"resource_list": ["1"]}]
c. overcloud update with policy mode change to 'update' (It will use count=3 in template)
count=3, nodes=['0', '2', '3'], blacklist=['1'], mode=update, *RemovalPolicies: [{"resource_list": ["1"]}]
d. node delete ['3']
count=2, nodes=['0', '1'], blacklist=['3'], mode=update, *RemovalPolicies: [{"resource_list": ["3"]}]
both 2, 3 would be deleted and '1' would be created. This seems logical as you're only asking for 2 nodes and to flush the blacklist history.
However, we should force mode=append with 'node delete' to avoid it.
count=2, nodes=['0', '2'], blacklist=['1', '3'], mode=append, *RemovalPolicies: [{"resource_list": ["3"]}]
Changed in tripleo: | |
assignee: | nobody → Rabi Mishra (rabi) |
importance: | Undecided → High |
Fix proposed to branch: master /review. opendev. org/689326
Review: https:/