Locking layers currently is not working for image uploader

[Bogdan Dobrelya]

The original change I477219b7dca1e6cfa02a278c55a0cc1a9833d007
introduced locking of layers. Later the dynamic split
I60507eba9884a0660fe269da5ad27b0e57a70ca8 came for the multi-process vs
multi-threading execution pools and introduced the lock variable that
must be passed through all of the locking-mode (MP/MT) dependent
places to never confuse it with the ongoing SMP work types.

That happend it is not passed currently into the very single call we do for layers locking in the image uploader. That makes the code effectively dead. Quite easy to check that for any CI job: grep the container images prepare logs for the "Locking layer" messages, you'll see none of it. Instead there is only "No lock information provided for layer" plus the useless unlocking events logged all the way.

We should either revert I477219b7dca1e6cfa02a278c55a0cc1a9833d007 or fix it like here https://review.opendev.org/#/c/688660.

[Bogdan Dobrelya (bogdando)]

Additionally https://review.opendev.org/#/c/687288 might provide an alternative to the layers locking.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/690111

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/690111
Committed: https://git.openstack.org/cgit/openstack/tripleo-common/commit/?id=d4ce2054ccb9764b9c17d45709a73405b64836c9
Submitter: Zuul
Branch: master

commit d4ce2054ccb9764b9c17d45709a73405b64836c9
Author: Alex Schultz <email address hidden>
Date: Tue Oct 22 09:35:31 2019 -0600

    Fix missing lock

    The lock got dropped when we had to rebase
    https://review.opendev.org/#/c/686181/ due to
    https://review.opendev.org/#/c/687027/

    Change-Id: I3686531ab383951edef60ac62dc259d39155704a
    Closes-Bug: #1848532

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/train
Review: https://review.opendev.org/690975

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/stein
Review: https://review.opendev.org/690976

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/690976
Committed: https://git.openstack.org/cgit/openstack/tripleo-common/commit/?id=264def3473f0ffe24dbd77e5a08d02cc0430ebee
Submitter: Zuul
Branch: stable/stein

commit 264def3473f0ffe24dbd77e5a08d02cc0430ebee
Author: Alex Schultz <email address hidden>
Date: Tue Oct 22 09:35:31 2019 -0600

    Fix missing lock

    The lock got dropped when we had to rebase
    https://review.opendev.org/#/c/686181/ due to
    https://review.opendev.org/#/c/687027/

    NOTE: this includes I336642272f7ff95174b0be80fb368ae2de76c13c due to the
    conflict.

    Change-Id: I3686531ab383951edef60ac62dc259d39155704a
    Closes-Bug: #1848532
    (cherry picked from commit d4ce2054ccb9764b9c17d45709a73405b64836c9)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/690975
Committed: https://git.openstack.org/cgit/openstack/tripleo-common/commit/?id=8ae8262be810f9b529312a116f3ef0870f10fde8
Submitter: Zuul
Branch: stable/train

commit 8ae8262be810f9b529312a116f3ef0870f10fde8
Author: Alex Schultz <email address hidden>
Date: Tue Oct 22 09:35:31 2019 -0600

    Fix missing lock

    The lock got dropped when we had to rebase
    https://review.opendev.org/#/c/686181/ due to
    https://review.opendev.org/#/c/687027/

    Change-Id: I3686531ab383951edef60ac62dc259d39155704a
    Closes-Bug: #1848532
    (cherry picked from commit d4ce2054ccb9764b9c17d45709a73405b64836c9)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-common 12.0.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-common 10.8.2 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-common 11.3.2 release.