Undercloud upgrade failed taks tripleo-upgrade : remove ceph_osd from ceph env, Invalid data passed to 'loop'

[Jose Luis Franco]

Description of problem:

The undercloud upgrade FFU is failing on undercloud upgrade:

TASK [tripleo-upgrade : remove ceph_osd from ceph env.] ************************
task path: /home/rhos-ci/jenkins/workspace/DFG-upgrades-ffu-ffu-upgrade-10-13_director-rhel-virthost-3cont_2comp_3ceph-ipv4-vlan-monolithic/infrared/plugins/tripleo-upgrade/infrared_plugin/roles/tripleo-upgrade/tasks/common/convert_ceph_params.yaml:85
Sunday 22 September 2019 17:19:18 +0000 (0:00:00.625) 0:01:45.951 ******
fatal: [undercloud-0]: FAILED! => {}

MSG:

Invalid data passed to 'loop', it requires a list, got this instead: {'/dev/vdc': {}, '/dev/vdb': {}, '/dev/vdf': {}, '/dev/vde': {}, '/dev/vdd': {}}. Hint: If you passed a list/dict of just one element, try adding wantlist=True to your lookup invocation or use q/query instead of lookup.

How reproducible:
100%

Steps to Reproduce:
1. deploy RHOS10
2. start FFU undercloud upgrade
3.

Actual results:
Failed to upgrade the undercloud

Expected results:
no errors

Additional info:

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/683868

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/queens
Review: https://review.opendev.org/684656

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/683868
Committed: https://git.openstack.org/cgit/openstack/tripleo-upgrade/commit/?id=75290252d7bd22540a10a47ba6f5477d85c5a542
Submitter: Zuul
Branch: master

commit 75290252d7bd22540a10a47ba6f5477d85c5a542
Author: Jose Luis Franco Arza <email address hidden>
Date: Mon Sep 23 10:10:49 2019 +0200

    Handle when ceph_osds is a dictionary or a list.

    The ceph_osds variable is obtained from the ceph configuration
    and it seems it can be a dictionary formed by the osds directories
    as keys, example {'/dev/vdc': {}, '/dev/vdb': {}, '/dev/vdf': {},
    '/dev/vde': {}, '/dev/vdd': {}} .
    For that reason, we need to differentiate when the variable is
    a list or a dictionary, as otherwise the loop variable won't be
    able to iterate over the values.

    Change-Id: Ib7aded0ff3668079dbe43cc3fbfa6a7e067cec83
    Closes-Bug: #1844974

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/stein
Review: https://review.opendev.org/684725

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/684725
Committed: https://git.openstack.org/cgit/openstack/tripleo-upgrade/commit/?id=b70b3e0a2b5596dc51fc4d5a342ae424af93d27f
Submitter: Zuul
Branch: stable/stein

commit b70b3e0a2b5596dc51fc4d5a342ae424af93d27f
Author: Jose Luis Franco Arza <email address hidden>
Date: Mon Sep 23 10:10:49 2019 +0200

    Handle when ceph_osds is a dictionary or a list.

    The ceph_osds variable is obtained from the ceph configuration
    and it seems it can be a dictionary formed by the osds directories
    as keys, example {'/dev/vdc': {}, '/dev/vdb': {}, '/dev/vdf': {},
    '/dev/vde': {}, '/dev/vdd': {}} .
    For that reason, we need to differentiate when the variable is
    a list or a dictionary, as otherwise the loop variable won't be
    able to iterate over the values.

    Change-Id: Ib7aded0ff3668079dbe43cc3fbfa6a7e067cec83
    Closes-Bug: #1844974
    (cherry picked from commit 75290252d7bd22540a10a47ba6f5477d85c5a542)

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/rocky
Review: https://review.opendev.org/685231

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/685231
Committed: https://git.openstack.org/cgit/openstack/tripleo-upgrade/commit/?id=997ab864cd841d76d5c28948309f618da5cfa4ac
Submitter: Zuul
Branch: stable/rocky

commit 997ab864cd841d76d5c28948309f618da5cfa4ac
Author: Jose Luis Franco Arza <email address hidden>
Date: Mon Sep 23 10:10:49 2019 +0200

    Handle when ceph_osds is a dictionary or a list.

    The ceph_osds variable is obtained from the ceph configuration
    and it seems it can be a dictionary formed by the osds directories
    as keys, example {'/dev/vdc': {}, '/dev/vdb': {}, '/dev/vdf': {},
    '/dev/vde': {}, '/dev/vdd': {}} .
    For that reason, we need to differentiate when the variable is
    a list or a dictionary, as otherwise the loop variable won't be
    able to iterate over the values.

    Change-Id: Ib7aded0ff3668079dbe43cc3fbfa6a7e067cec83
    Closes-Bug: #1844974
    (cherry picked from commit 75290252d7bd22540a10a47ba6f5477d85c5a542)
    (cherry picked from commit b70b3e0a2b5596dc51fc4d5a342ae424af93d27f)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/684656
Committed: https://git.openstack.org/cgit/openstack/tripleo-upgrade/commit/?id=bfaa256e5da2f3833662a34651207ae8ccb263a8
Submitter: Zuul
Branch: stable/queens

commit bfaa256e5da2f3833662a34651207ae8ccb263a8
Author: Jose Luis Franco Arza <email address hidden>
Date: Mon Sep 23 10:10:49 2019 +0200

    Handle when ceph_osds is a dictionary or a list.

    The ceph_osds variable is obtained from the ceph configuration
    and it seems it can be a dictionary formed by the osds directories
    as keys, example {'/dev/vdc': {}, '/dev/vdb': {}, '/dev/vdf': {},
    '/dev/vde': {}, '/dev/vdd': {}} .
    For that reason, we need to differentiate when the variable is
    a list or a dictionary, as otherwise the loop variable won't be
    able to iterate over the values.

    Change-Id: Ib7aded0ff3668079dbe43cc3fbfa6a7e067cec83
    Closes-Bug: #1844974
    (cherry picked from commit 75290252d7bd22540a10a47ba6f5477d85c5a542)
    (cherry picked from commit b70b3e0a2b5596dc51fc4d5a342ae424af93d27f)
    (cherry picked from commit 997ab864cd841d76d5c28948309f618da5cfa4ac)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-upgrade 5.0.0 release.