ceph runs the tripleo-ceph-{work-dir,fetch-dir,common} roles more than once in the deployment steps

[Alex Schultz]

Because tripleo-ceph-common, tripleo-ceph-work-dir are dependencies in some of the tripleo-ceph-* roles in tripleo-ansible, they are getting rerun more than once in a deployment. The dependencies should either be handled in THT when we include them or cleaned up such that it we don't keep rerunning these roles.

https://logs.rdoproject.org/25/683425/1/openstack-check/tripleo-ci-rhel-8-scenario001-standalone-rdo/0015380/logs/undercloud/home/zuul/standalone_deploy.log.txt.gz#_2019-09-20_16_16_50
http://paste.openstack.org/show/778229/

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/709250

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/709250
Committed: https://git.openstack.org/cgit/openstack/tripleo-ansible/commit/?id=f3c8c59fe0bf11108a23f2bcecf9e44db41fb3ce
Submitter: Zuul
Branch: master

commit f3c8c59fe0bf11108a23f2bcecf9e44db41fb3ce
Author: John Fulton <email address hidden>
Date: Fri Feb 21 21:48:00 2020 +0000

    Remove tripleo_ceph_fetch_dir role

    The state information in the ceph-ansible fetch directory
    is no longer necessary to replace a Ceph monitor as of
    ceph-ansible 4.0.14-1. Stein, Train, Ussuri and newer
    should be using this version of ceph-ansible or newer.
    TripleO does not need to do extra work to maintain the
    fetch directory. Remove tripleo_ceph_fetch_dir role and
    modify code flow so that it's no longer used.

    Also, remove unnecessary dependencies in tripleo-ceph-*
    roles as described in LP #1844837.

    Change-Id: Ic292dcc1bcf1e7575285ad56d56df2966e968b6d
    Depends-On: I3f8c2571a6dd35029d71dd42df637a962d9b3235
    Related-Bug: #1863809
    Closes-Bug: #1844837

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/train
Review: https://review.opendev.org/710651

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/710651
Committed: https://git.openstack.org/cgit/openstack/tripleo-ansible/commit/?id=ed21e70f76be2760c168dc6811a834780da2c718
Submitter: Zuul
Branch: stable/train

commit ed21e70f76be2760c168dc6811a834780da2c718
Author: John Fulton <email address hidden>
Date: Fri Feb 21 21:48:00 2020 +0000

    Remove tripleo_ceph_fetch_dir role

    The state information in the ceph-ansible fetch directory
    is no longer necessary to replace a Ceph monitor as of
    ceph-ansible 4.0.14-1. Stein, Train, Ussuri and newer
    should be using this version of ceph-ansible or newer.
    TripleO does not need to do extra work to maintain the
    fetch directory. Remove tripleo_ceph_fetch_dir role and
    modify code flow so that it's no longer used.

    Also, remove unnecessary dependencies in tripleo-ceph-*
    roles as described in LP #1844837.

    Unlclean cherry pick; required manual changes

    Change-Id: Ic292dcc1bcf1e7575285ad56d56df2966e968b6d
    Depends-On: I3f8c2571a6dd35029d71dd42df637a962d9b3235
    Related-Bug: #1863809
    Closes-Bug: #1844837
    (cherry picked from commit f3c8c59fe0bf11108a23f2bcecf9e44db41fb3ce)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-ansible 0.5.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-ansible 1.3.0 release.