Stein upgrades job fails, syntax error in deploy-steps playbook

[Sagi (Sergey) Shnaidman]

periodic-tripleo-ci-centos-7-standalone-upgrade-stein job fails, syntax error in common/deploy-steps.j2

http://logs.rdoproject.org/openstack-periodic-latest-released/opendev.org/openstack/tripleo-ci/master/periodic-tripleo-ci-centos-7-standalone-upgrade-stein/4d814af/logs/undercloud/home/zuul/standalone_upgrade.log.txt.gz

[-] ** Running ansible online-upgrade tasks
2019-09-08 17:15:30 | 2019-09-08 17:15:30.468 116211 WARNING tripleoclient.v1.tripleo_upgrade.Upgrade [-] ERROR! Syntax Error while loading YAML.
2019-09-08 17:15:30 | 2019-09-08 17:15:30.468 116211 WARNING tripleoclient.v1.tripleo_upgrade.Upgrade [-] did not find expected '-' indicator
2019-09-08 17:15:30 | 2019-09-08 17:15:30.469 116211 WARNING tripleoclient.v1.tripleo_upgrade.Upgrade [-]
2019-09-08 17:15:30 | 2019-09-08 17:15:30.469 116211 WARNING tripleoclient.v1.tripleo_upgrade.Upgrade [-] The error appears to be in '/home/zuul/undercloud-ansible-FehRMI/external_upgrade_steps_playbook.yaml': line 125, column 2, but may
2019-09-08 17:15:30 | 2019-09-08 17:15:30.469 116211 WARNING tripleoclient.v1.tripleo_upgrade.Upgrade [-] be elsewhere in the file depending on the exact syntax problem.
2019-09-08 17:15:30 | 2019-09-08 17:15:30.469 116211 WARNING tripleoclient.v1.tripleo_upgrade.Upgrade [-]
2019-09-08 17:15:30 | 2019-09-08 17:15:30.469 116211 WARNING tripleoclient.v1.tripleo_upgrade.Upgrade [-] The offending line appears to be:
2019-09-08 17:15:30 | 2019-09-08 17:15:30.469 116211 WARNING tripleoclient.v1.tripleo_upgrade.Upgrade [-]
2019-09-08 17:15:30 | 2019-09-08 17:15:30.470 116211 WARNING tripleoclient.v1.tripleo_upgrade.Upgrade [-] - import_tasks: external_deploy_steps_tasks.yaml
2019-09-08 17:15:30 | 2019-09-08 17:15:30.470 116211 WARNING tripleoclient.v1.tripleo_upgrade.Upgrade [-] tags:
2019-09-08 17:15:30 | 2019-09-08 17:15:30.470 116211 WARNING tripleoclient.v1.tripleo_upgrade.Upgrade [-] ^ here
2019-09-08 17:15:30 | 2019-09-08 17:15:30.493 116211 ERROR tripleoclient.v1.tripleo_upgrade.Upgrade [-] Exception: Online Upgrade failed: DeploymentError: Online Upgrade failed
2019-09-08 17:15:30 | Traceback (most recent call last):
2019-09-08 17:15:30 | File "/usr/lib/python2.7/site-packages/tripleoclient/v1/tripleo_deploy.py", line 1268, in _standalone_deploy
2019-09-08 17:15:30 | 'Online Upgrade failed')
2019-09-08 17:15:30 | DeploymentError: Online Upgrade failed

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/stein
Review: https://review.opendev.org/680882

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/680882
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=ac5f18c7eb0b5f6d367a0b8861742a395f17828b
Submitter: Zuul
Branch: stable/stein

commit ac5f18c7eb0b5f6d367a0b8861742a395f17828b
Author: Sagi Shnaidman <email address hidden>
Date: Sun Sep 8 21:21:22 2019 +0300

    Fix indent in deploy-steps playbook

    "tags" is indented wrong in playbook, which causes playbook fail
    Closes-Bug: #1843188
    Change-Id: Ic76aa09b5e5fd5711afa00608156f3f947d29ee1

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 10.6.1 release.