Race sometimes causes successful deployments to return failed
Bug #1842987 reported by
Steve Baker
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
tripleo |
Fix Released
|
High
|
Steve Baker |
Bug Description
These lines[1] have a race condition where the fetched execution is state:SUCCESS but the last payload is status:RUNNING. This leads to the status:SUCCESS payload never being returned to the caller, and the deployment failing even though it succeeded.
Even though triggering this seems to be rare, it does happen. And the same issue appears to go back to Queens.
Changed in tripleo: | |
status: | Triaged → In Progress |
tags: | added: queens-backport-potential |
To post a comment you must log in.
Reviewed: https:/ /review. opendev. org/679873 /git.openstack. org/cgit/ openstack/ python- tripleoclient/ commit/ ?id=b5b5cab61da 98c8bcf2c4e52a6 d8ce0108dcfc64
Committed: https:/
Submitter: Zuul
Branch: master
commit b5b5cab61da98c8 bcf2c4e52a6d8ce 0108dcfc64
Author: Steve Baker <email address hidden>
Date: Wed Sep 4 10:09:04 2019 +1200
Fix race in execution finishing
An execution state can go from RUNNING to SUCCESS between fetching the
last message from the websocket and polling the execution state. This
means the SUCCESS payload is never returned and the overcloud
deployment fails at the end with no indication as to why.
This change turns the output of the execution into the last payload,
allowing the calling SUCCESS logic to run.
Change-Id: Ic22021ba9a2717 de199629e361c65 6e2f562fb38
Closes-Bug: #1842987