notifications needed for novajoin not working when telemetry is disabled

[Ade Lee]

A recent change disabled notifications when telemetry is disabledby setting the driver to noop.

This breaks novajoin-notifier which listens for notifications from nova and neutron.
Specifically,

https://opendev.org/x/novajoin/src/branch/master/novajoin/notifications.py#L112

We need this fixed or tls-everywhere is broken.

[Ade Lee (alee-3)]

Change is -- https://review.opendev.org/#/c/674639/

[Alex Schultz (alex-schultz)]

We did this change all the way back to Queens so we'll have to have similar logic in instack-undercloud

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/rocky
Review: https://review.opendev.org/678087

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/678087
Committed: https://git.openstack.org/cgit/openstack/instack-undercloud/commit/?id=5f1b6c6e5001ed917d474bed33ca88103031de94
Submitter: Zuul
Branch: stable/rocky

commit 5f1b6c6e5001ed917d474bed33ca88103031de94
Author: Alex Schultz <email address hidden>
Date: Thu Aug 22 12:50:05 2019 -0600

    Explicitly set notification driver for novajoin

    Novajoin is reliant on some notifications from nova. We recently
    merged an update to the undercloud installation that disables
    the notification drvier across the board if telemetry is disabled. This
    change adds logic for nova to force the notification driver to
    messagingv2.

    Change-Id: I75bb75092fa348dc1c2dc465446cb91d4882cf15
    Closes-Bug: #1841100

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/queens
Review: https://review.opendev.org/678236

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/stein
Review: https://review.opendev.org/678288

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/678236
Committed: https://git.openstack.org/cgit/openstack/instack-undercloud/commit/?id=97b77d1d13321833c82fded6b817105e2624ab78
Submitter: Zuul
Branch: stable/queens

commit 97b77d1d13321833c82fded6b817105e2624ab78
Author: Alex Schultz <email address hidden>
Date: Thu Aug 22 12:50:05 2019 -0600

    Explicitly set notification driver for novajoin

    Novajoin is reliant on some notifications from nova. We recently
    merged an update to the undercloud installation that disables
    the notification drvier across the board if telemetry is disabled. This
    change adds logic for nova to force the notification driver to
    messagingv2.

    Change-Id: I75bb75092fa348dc1c2dc465446cb91d4882cf15
    Closes-Bug: #1841100
    (cherry picked from commit 5f1b6c6e5001ed917d474bed33ca88103031de94)

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/rocky
Review: https://review.opendev.org/678316

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/678083
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=7c9c363c789811d54353d769aab86774eb5c96f8
Submitter: Zuul
Branch: master

commit 7c9c363c789811d54353d769aab86774eb5c96f8
Author: Alex Schultz <email address hidden>
Date: Thu Aug 22 12:36:49 2019 -0600

    Explicitly set notification driver for novajoin

    Novajoin is reliant on some notifications from nova. We recently merged
    an update to the undercloud installation that disables the notification
    drvier across the board if telemetry is disabled. This change adds a
    service_config_setting for nova to force the notification driver to
    messagingv2. This should be merged with the service configurations and
    override the value that is normally set via NotificationDriver.

    Change-Id: Ifee8f7f50fc2ef99605cbbcaa89016514b80b561
    Closes-Bug: #1841100

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/678288
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=2ed88dbcd5c7ea19c935aa71155c8e7824b59f7f
Submitter: Zuul
Branch: stable/stein

commit 2ed88dbcd5c7ea19c935aa71155c8e7824b59f7f
Author: Alex Schultz <email address hidden>
Date: Thu Aug 22 12:36:49 2019 -0600

    Explicitly set notification driver for novajoin

    Novajoin is reliant on some notifications from nova. We recently merged
    an update to the undercloud installation that disables the notification
    drvier across the board if telemetry is disabled. This change adds a
    service_config_setting for nova to force the notification driver to
    messagingv2. This should be merged with the service configurations and
    override the value that is normally set via NotificationDriver.

    Change-Id: Ifee8f7f50fc2ef99605cbbcaa89016514b80b561
    Closes-Bug: #1841100
    (cherry picked from commit 7c9c363c789811d54353d769aab86774eb5c96f8)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/678316
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=973ae3e83cbe80e2e4858903c10eab257bad52a2
Submitter: Zuul
Branch: stable/rocky

commit 973ae3e83cbe80e2e4858903c10eab257bad52a2
Author: Alex Schultz <email address hidden>
Date: Thu Aug 22 12:36:49 2019 -0600

    Explicitly set notification driver for novajoin

    Novajoin is reliant on some notifications from nova. We recently merged
    an update to the undercloud installation that disables the notification
    drvier across the board if telemetry is disabled. This change adds a
    service_config_setting for nova to force the notification driver to
    messagingv2. This should be merged with the service configurations and
    override the value that is normally set via NotificationDriver.

    Change-Id: Ifee8f7f50fc2ef99605cbbcaa89016514b80b561
    Closes-Bug: #1841100
    (cherry picked from commit 7c9c363c789811d54353d769aab86774eb5c96f8)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 10.6.1 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/instack-undercloud 9.5.1 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 9.4.1 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/instack-undercloud 8.4.9 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 11.2.0 release.