create_or_find_kernel_and_ramdisk inaccurately named

Bug #1840709 reported by Jeremy Freudberg
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
tripleo
Invalid
Low
Jeremy Freudberg

Bug Description

After [0] merged, the function create_or_find_kernel_and_ramdisk is inaccurately named: there is no creation of images, only finding. Moreover its docstring refers to some arguments that have been removed.

[0] https://opendev.org/openstack/tripleo-common/src/commit/314917b2a9effbf26460ce6ca786362dd9dd2a4f/tripleo_common/utils/glance.py#L22

Recently these inaccuracies were a point of confusion for me. Perhaps the function should be renamed. I am personally able to at least contribute some docstring enhancements to make things a bit more clear and accurate. Reporting this so that the work can be tracked.

Changed in tripleo:
assignee: nobody → Jeremy Freudberg (jfreud)
tags: added: tripleo-common
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tripleo-common (master)

Fix proposed to branch: master
Review: https://review.opendev.org/680116

Changed in tripleo:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-common (master)

Reviewed: https://review.opendev.org/680116
Committed: https://git.openstack.org/cgit/openstack/tripleo-common/commit/?id=07ead6bb2b1041ab1a446009977774b32c504a0c
Submitter: Zuul
Branch: master

commit 07ead6bb2b1041ab1a446009977774b32c504a0c
Author: Jeremy Freudberg <email address hidden>
Date: Wed Sep 4 14:17:29 2019 -0400

    create_or_find_kernel_and_ramdisk docstring fixes

    Some modest docstring fixes will serve to alleviate developer confusion
    (personally I have already been confused) as this function is no longer
    accurately named.

    Change-Id: If536f22755e24cdd67cbd83ac45fae69ed1c05b2
    Partial-Bug: #1840709

Revision history for this message
Sandeep Yadav (sandeepyadav93) wrote :

We don't have glance in the undercloud since victoria. glance related utility methods are removed in [1]

https://review.opendev.org/c/openstack/tripleo-common/+/779424

Closing this bug as this is not valid anymore.

Changed in tripleo:
importance: Undecided → Low
status: In Progress → Invalid
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.