[Update] Task Run tripleo-container-image-prepare does not run

[Piotr Kopec]

Description
===========

During our test of cells_v2 update when following the guide [1] new images are not updated during `openstack overcloud external-update run --tags container_image_prepare` step.

Task `TASK [Run tripleo-container-image-prepare logged to /var/log/tripleo-container-image-prepare.log]` is skipped as seen in `external-update-run-output.log` and by looking at the logfile where the task should write:

```
 [root@undercloud config-download-latest]# ls -latr /var/log/tripleo-container-image-prepare.log
-rw-r--r--. 1 root root 1195802 Aug 16 22:22 /var/log/tripleo-container-image-prepare.log
 [root@undercloud config-download-latest]# date
Sun Aug 18 22:25:56 UTC 2019
```

However, when `ansible-playbook-command.sh` is run directly the task is executed as seen in `ansible-playbook-command-output.log` and the log file of the task is updated:

```
 [root@undercloud config-download-latest]# ls -latr /var/log/tripleo-container-image-prepare.log
-rw-r--r--. 1 root root 1205478 Aug 18 22:30 /var/log/tripleo-container-image-prepare.log
 [root@undercloud config-download-latest]# date
Sun Aug 18 22:32:38 UTC 2019
```

and new images are downloaded:

```
[stack@undercloud v2]$ cat ./tripleomaster/centos-binary-nova-compute/tags/list
{"name": "tripleomaster/centos-binary-nova-compute", "tags": ["current-tripleo-rdo", "current-tripleo"]}
```

[1]: https://docs.openstack.org/tripleo-docs/latest/upgrade/minor_update.html#updating-your-overcloud-queens-and-beyond

Steps to reproduce
==================
* Deploy overcloud
* Follow update procedure [1]
* Run `openstack overcloud external-update run --tags container_image_prepare`

This occurred for both cell's stack and overcloud stack.

Expected result
===============
Container images are updated

Actual result
=============
Task that updates container images is skipped

Environment
===========
(undercloud) [stack@undercloud ~]$ rpm -qa | grep tripleo
python2-tripleo-common-11.1.1-0.20190809171503.84d1fcd.el7.noarch
openstack-tripleo-heat-templates-11.1.1-0.20190811122053.25698eb.el7.noarch
openstack-tripleo-puppet-elements-11.1.1-0.20190809141928.d155a90.el7.noarch
openstack-tripleo-image-elements-10.5.1-0.20190808105953.d51d61a.el7.noarch
python2-tripleoclient-12.1.1-0.20190808110321.a8e8165.el7.noarch
openstack-tripleo-validations-11.1.1-0.20190809021945.741b363.el7.noarch
tripleo-ansible-0.2.1-0.20190809142241.9204dbc.el7.noarch
openstack-tripleo-common-11.1.1-0.20190809171503.84d1fcd.el7.noarch
python2-tripleoclient-heat-installer-12.1.1-0.20190808110321.a8e8165.el7.noarch
ansible-role-tripleo-modify-image-1.1.1-0.20190711163349.eabaed0.el7.noarch
puppet-tripleo-11.1.1-0.20190809142740.ddc1d9d.el7.noarch
openstack-tripleo-common-containers-11.1.1-0.20190809171503.84d1fcd.el7.noarch
ansible-tripleo-ipsec-9.1.1-0.20190513182517.ffe104c.el7.noarch

[yatin (yatinkarel)]

Seems duplicate of https://bugs.launchpad.net/tripleo/+bug/1844109 (this is against upgrade but symptoms are same.), Can u check the bug and it's proposed fix.