tripleo

pre-commit fails for tripleo-common trying to fetch flake8

Bug #1836761 reported by Alex Schultz
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
tripleo
Fix Released
High
Alex Schultz
tripleo train-2

Bug Description

https://review.opendev.org/#/c/665445/ added this.

$ tox -e pep8
pep8 create: /home/aschultz/Documents/workspace/tripleo/tripleo-common/.tox/pep8
pep8 installed: tripleo-common==11.0.1.dev111
pep8 run-test-pre: PYTHONHASHSEED='3731525063'
pep8 run-test: commands[0] | tox -e linters -- flake8
linters create: /home/aschultz/Documents/workspace/tripleo/tripleo-common/.tox/linters
linters installdeps: pre-commit
linters installed: aspy.yaml==1.3.0,cfgv==2.0.0,identify==1.4.5,importlib-metadata==0.18,importlib-resources==1.0.2,nodeenv==1.3.3,pre-commit==1.17.0,PyYAML==5.1.1,six==1.12.0,toml==0.10.0,tripleo-common==11.0.1.dev111,virtualenv==16.6.2,zipp==0.5.2
linters run-test-pre: PYTHONHASHSEED='2224523270'
linters run-test: commands[0] | python -m pre_commit run -a flake8
[INFO] Initializing environment for https://gitlab.com/pycqa/flake8.
An unexpected error has occurred: CalledProcessError: Command: ('/usr/bin/git', 'fetch', 'origin', '--tags')
Return code: 128
Expected return code: 0
Output: (none)
Errors:
    error: RPC failed; result=22, HTTP code = 404
    fatal: The remote end hung up unexpectedly

Check the log at /home/aschultz/.cache/pre-commit/pre-commit.log
ERROR: InvocationError for command /home/aschultz/Documents/workspace/tripleo/tripleo-common/.tox/linters/bin/python -m pre_commit run -a flake8 (exited with code 1)
___________________________________________________________________________ summary ___________________________________________________________________________
ERROR: linters: commands failed
ERROR: InvocationError for command /home/aschultz/.virtualenvs/tripleo-common/bin/tox -e linters -- flake8 (exited with code 1)
___________________________________________________________________________ summary ___________________________________________________________________________
ERROR: pep8: commands failed

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to tripleo-common (master)

Related fix proposed to branch: master
Review: https://review.opendev.org/671056

Revision history for this message
Alex Schultz (alex-schultz) wrote :

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/home/aschultz/Documents/workspace/tripleo/tripleo-common/.tox/linters/lib/python3.6/site-packages/pre_commit/error_handler.py", line 46, in error_handler
    yield
  File "/home/aschultz/Documents/workspace/tripleo/tripleo-common/.tox/linters/lib/python3.6/site-packages/pre_commit/main.py", line 294, in main
    return run(args.config, store, args)
  File "/home/aschultz/Documents/workspace/tripleo/tripleo-common/.tox/linters/lib/python3.6/site-packages/pre_commit/commands/run.py", line 282, in run
    for hook in all_hooks(config, store)
  File "/home/aschultz/Documents/workspace/tripleo/tripleo-common/.tox/linters/lib/python3.6/site-packages/pre_commit/repository.py", line 221, in all_hooks
    for repo in root_config['repos']
  File "/home/aschultz/Documents/workspace/tripleo/tripleo-common/.tox/linters/lib/python3.6/site-packages/pre_commit/repository.py", line 222, in <genexpr>
    for hook in _repository_hooks(repo, store, root_config)
  File "/home/aschultz/Documents/workspace/tripleo/tripleo-common/.tox/linters/lib/python3.6/site-packages/pre_commit/repository.py", line 197, in _repository_hooks
    return _cloned_repository_hooks(repo_config, store, root_config)
  File "/home/aschultz/Documents/workspace/tripleo/tripleo-common/.tox/linters/lib/python3.6/site-packages/pre_commit/repository.py", line 166, in _cloned_repository_hooks
    manifest_path = os.path.join(store.clone(repo, rev), C.MANIFEST_FILE)
  File "/home/aschultz/Documents/workspace/tripleo/tripleo-common/.tox/linters/lib/python3.6/site-packages/pre_commit/store.py", line 176, in clone
    return self._new_repo(repo, ref, deps, clone_strategy)
  File "/home/aschultz/Documents/workspace/tripleo/tripleo-common/.tox/linters/lib/python3.6/site-packages/pre_commit/store.py", line 128, in _new_repo
    make_strategy(directory)
  File "/home/aschultz/Documents/workspace/tripleo/tripleo-common/.tox/linters/lib/python3.6/site-packages/pre_commit/store.py", line 174, in clone_strategy
    self._complete_clone(ref, _git_cmd)
  File "/home/aschultz/Documents/workspace/tripleo/tripleo-common/.tox/linters/lib/python3.6/site-packages/pre_commit/store.py", line 141, in _complete_clone
    git_cmd('fetch', 'origin', '--tags')
  File "/home/aschultz/Documents/workspace/tripleo/tripleo-common/.tox/linters/lib/python3.6/site-packages/pre_commit/store.py", line 166, in _git_cmd
    cmd_output('git', *args, cwd=directory, env=env)
  File "/home/aschultz/Documents/workspace/tripleo/tripleo-common/.tox/linters/lib/python3.6/site-packages/pre_commit/util.py", line 153, in cmd_output
    returncode, cmd, retcode, output=(stdout, stderr),
pre_commit.util.CalledProcessError: Command: ('/usr/bin/git', 'fetch', 'origin', '--tags')
Return code: 128
Expected return code: 0
Output: (none)
Errors:
    error: RPC failed; result=22, HTTP code = 404
    fatal: The remote end hung up unexpectedly

Revision history for this message
Sorin Sbarnea (ssbarnea) wrote :

Alex, this mostly seems like an issue with gitlab.com hosting.

We already have similar dependencies in other places, any insights?

Revision history for this message
Alex Schultz (alex-schultz) wrote :

I think it's probably an issue with git + gitlab. I'm using a stock rhel for testing which is why if it fails, we need to revert this

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tripleo-common (master)

Fix proposed to branch: master
Review: https://review.opendev.org/672345

Changed in tripleo:
assignee: nobody → Alex Schultz (alex-schultz)
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on tripleo-common (master)

Change abandoned by Alex Schultz (<email address hidden>) on branch: master
Review: https://review.opendev.org/671056
Reason: https://review.opendev.org/672345

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-common (master)

Reviewed: https://review.opendev.org/672345
Committed: https://git.openstack.org/cgit/openstack/tripleo-common/commit/?id=86c6b3eca84dc064b59f9e66429e26a3ed4095f3
Submitter: Zuul
Branch: master

commit 86c6b3eca84dc064b59f9e66429e26a3ed4095f3
Author: Alex Schultz <email address hidden>
Date: Tue Jul 23 13:15:42 2019 -0600

    Fix flake8 git repo location

    The correct gitlab url ends in .git.

    Change-Id: I504512eb9e4ff8f21c8de1146528352926df2b3d
    Closes-Bug: #1836761

Changed in tripleo:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/tripleo-common 11.2.0

This issue was fixed in the openstack/tripleo-common 11.2.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.