RFE: Remove etc/puppet/hieradata/service_names.json

[Emilien Macchi]

Extract service_names from THT/puppet/role.role.j2.yaml and use tripleo-hieradata ansible role to configure that file.

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.opendev.org/669414

[Emilien Macchi (emilienm)]

in fact we can remove that file, it's not useful anyway.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/669424

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/669414
Committed: https://git.openstack.org/cgit/openstack/puppet-tripleo/commit/?id=7970733cf1483fab466f205e57c9ea224f051c94
Submitter: Zuul
Branch: master

commit 7970733cf1483fab466f205e57c9ea224f051c94
Author: Emilien Macchi <email address hidden>
Date: Fri Jul 5 13:25:34 2019 -0400

    Replace hiera('service_names') by hiera('enabled_services')

    In the effort of reducing the number of Hieradata files, the
    service_names parameter previously consummed in puppet-tripleo can be
    replaced by enabled_services which contains the same list.

    It will allow us later to remove the service_names hieradata file.

    Change-Id: I457f2c81a2cf6cc2f42dc4585b41b0d91dacc059
    Related-Bug: #1835551

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/669424
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=55ad2258449bbdcb62edb2f849ab9ab0244c6dac
Submitter: Zuul
Branch: master

commit 55ad2258449bbdcb62edb2f849ab9ab0244c6dac
Author: Emilien Macchi <email address hidden>
Date: Fri Jul 5 13:38:56 2019 -0400

    Remove service_names hieradata file

    The service_names isn't useful anymore:

    - hiera('service_names') has been replaced by hiera('enabled_services')
    - sensu::subscriptions moved under the {{role.name.lower()}}_extraconfig
      hieradata file.

    This is part of the effort which aims to reduce the number of hieradata
    files.

    Depends-On: I457f2c81a2cf6cc2f42dc4585b41b0d91dacc059
    Change-Id: I22081888541e059cd9f258d15990f58df78c38d2
    Closes-Bug: #1835551

[Cédric Jeanneret (cjeanner)]

Apparently puppet-tripleo package as shipped using "master" isn't up-to-date and still points to the old "service_names" hiera key, while it's not set anymore.

See this LP: https://bugs.launchpad.net/tripleo/+bug/1836696

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 11.1.0 release.