OVB promotion jobs - introspection fails nputException: Invalid input mistral.actions.openstack.actions.BaremetalIntrospectionAction missing node_id

[Sagi (Sergey) Shnaidman]

http://logs.rdoproject.org/openstack-periodic-master/opendev.org/openstack/tripleo-ci/master/periodic-tripleo-ci-centos-7-ovb-1ctlr_1comp-featureset002-master-upload/26786c3/logs/undercloud/home/zuul/overcloud_prep_images.log.txt.gz

http://logs.rdoproject.org/openstack-periodic-master/opendev.org/openstack/tripleo-ci/master/periodic-tripleo-ci-centos-7-ovb-1ctlr_1comp-featureset002-master-upload/1347f18/logs/undercloud/home/zuul/overcloud_prep_images.log.txt.gz

Exception introspecting nodes: {u'result': u'Failed to run task [error=Invalid input [name=baremetal_introspection.get_status, class=mistral.actions.openstack.actions.BaremetalIntrospectionAction, missing=[\'node_id\']], wf=tripleo.baremetal.v1.introspect, task=get_introspection_status]:
Traceback (most recent call last):
  File "/usr/lib/python2.7/site-packages/mistral/engine/task_handler.py", line 63, in run_task
    task.run()
  File "/usr/lib/python2.7/site-packages/osprofiler/profiler.py", line 160, in wrapper
    result = f(*args, **kwargs)
  File "/usr/lib/python2.7/site-packages/mistral/engine/tasks.py", line 487, in run
    self._run_new()
  File "/usr/lib/python2.7/site-packages/osprofiler/profiler.py", line 160, in wrapper
    result = f(*args, **kwargs)
  File "/usr/lib/python2.7/site-packages/mistral/engine/tasks.py", line 519, in _run_new
    self._schedule_actions()
  File "/usr/lib/python2.7/site-packages/mistral/engine/tasks.py", line 783, in _schedule_actions
    action.validate_input(input_dict)
  File "/usr/lib/python2.7/site-packages/mistral/engine/actions.py", line 349, in validate_input
    self.action_def.action_class
  File "/usr/lib/python2.7/site-packages/mistral/engine/utils.py", line 66, in validate_input
    raise exc.InputException(msg % tuple(msg_props))
InputException: Invalid input [name=baremetal_introspection.get_status, class=mistral.actions.openstack.actions.BaremetalIntrospectionAction, missing=['node_id']
', u'introspection_attempt': 0}
2019-06-30 02:00:22 | Waiting for introspection to finish...
2019-06-30 02:00:22 | {u'result': u'Failed to run task [error=Invalid input [name=baremetal_introspection.get_status, class=mistral.actions.openstack.actions.BaremetalIntrospectionAction, missing=[\'node_id\']], wf=tripleo.baremetal.v1.introspect, task=get_introspection_status]:

Traceback (most recent call last):
  File "/usr/lib/python2.7/site-packages/mistral/engine/task_handler.py", line 63, in run_task
    task.run()
  File "/usr/lib/python2.7/site-packages/osprofiler/profiler.py", line 160, in wrapper
    result = f(*args, **kwargs)
  File "/usr/lib/python2.7/site-packages/mistral/engine/tasks.py", line 487, in run
    self._run_new()
  File "/usr/lib/python2.7/site-packages/osprofiler/profiler.py", line 160, in wrapper
    result = f(*args, **kwargs)
  File "/usr/lib/python2.7/site-packages/mistral/engine/tasks.py", line 519, in _run_new
    self._schedule_actions()
  File "/usr/lib/python2.7/site-packages/mistral/engine/tasks.py", line 783, in _schedule_actions
    action.validate_input(input_dict)
  File "/usr/lib/python2.7/site-packages/mistral/engine/actions.py", line 349, in validate_input
    self.action_def.action_class
  File "/usr/lib/python2.7/site-packages/mistral/engine/utils.py", line 66, in validate_input
    raise exc.InputException(msg % tuple(msg_props))
InputException: Invalid input [name=baremetal_introspection.get_status, class=mistral.actions.openstack.actions.BaremetalIntrospectionAction, missing=['node_id']]

[Sagi (Sergey) Shnaidman (sshnaidm)]

maybe because of https://github.com/openstack/python-tripleoclient/commit/eaced0d1c7a9eaa06d10e3afb0b548e961812a35 ?

[yatin (yatinkarel)]

<< maybe because of https://github.com/openstack/python-tripleoclient/commit/eaced0d1c7a9eaa06d10e3afb0b548e961812a35 ?

Some background:- This happened due to ironic-inspector patch https://review.opendev.org/#/c/642564/ released with 3.6.0 tag. Fixed with https://review.opendev.org/#/c/667531/. New tag 3.6.1 is released with https://review.opendev.org/#/c/667964/ and is updated in RDO with:- https://review.rdoproject.org/r/#/c/21296/.
Now it's stuck to get in RDO consistent repo as somehow gerrit replication of distgit project from review.rdo to github has stopped, need to check why it stopped, once it's fixed, the issue should be cleared. I will update here once cleared.

[Sagi (Sergey) Shnaidman (sshnaidm)]

Yes, really it's uuid is deprecated in favor of node_id in ironic inspector client: https://github.com/openstack/python-ironic-inspector-client/compare/9bb1150..f35599

[yatin (yatinkarel)]

Update:- replication started working in RDO after restarting gerrit and now the fix is available in RDO consistent repo:- https://trunk.rdoproject.org/centos7-master/consistent/python-ironic-inspector-client-3.6.1-0.20190629093801.81ae133.el7.src.rpm next periodic run should be fine.