Configuration of multipath daemon is incomplete

[Alan Bishop]

The Block Storage service supports multiple network paths using the Linux multipath daemon. Traditionally, tripleo did not support the feature, and users configured it by hand. In pike, a new Multipathd tripleo service was introduced, which runs the multipath daemon in a container. Unfortunately,

- The multipath daemon is not configured (no /etc/multipath.conf)
- The Multipathd service isn't bound to any tripleo roles (it never gets deployed)

These deficiencies must be addressed in order for the Multipathd service to function correctly.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/665455
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=b1726619959ac8e9cb1d0e2939e097c528a04c81
Submitter: Zuul
Branch: master

commit b1726619959ac8e9cb1d0e2939e097c528a04c81
Author: Alan Bishop <email address hidden>
Date: Fri Jun 14 13:39:27 2019 -0400

    Make Multipathd an optional service

    This is part 1 of a series of patches to properly deploy multipathd.

    This patch makes Multipathd an optional TripleO service (defaults to
    OS::Heat::None), and binds it to every role that might use the service.
    This is essentially any role that accesses cinder volumes. Previously,
    the service was not optional, but was not bound to any roles and so it
    was never deployed.

    Partial-Bug: #1834042
    Change-Id: I3bc7d8557f758103c35533a59e06e36cd15f98b9

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/665456
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=906d03ea19a4446ed198c321f68791b7fa6e0c47
Submitter: Zuul
Branch: master

commit 906d03ea19a4446ed198c321f68791b7fa6e0c47
Author: Alan Bishop <email address hidden>
Date: Mon Jun 24 12:03:55 2019 -0700

    Configure the Multipathd service

    This is part 2 of a series of patches to properly deploy multipathd.

    This patch configures /etc/multipath.conf, which is required by the
    multipath daemon. The config file contents are managed using the
    'mpathconf' tool instead of a puppet module, but a tiny puppet wrapper
    is employed to take advantage of the tripleo tooling (e.g. restarting
    the multipathd container whenever the config file changes).

    Other changes include:
    - Ensuring the multipath daemon isn't running on the host
    - Preparing the /etc/multipath directory that must be shared by all
      containers that use the service
    - Adding a volume mount to services that need access to /etc/multipath

    Closes-Bug: #1834042
    Change-Id: Ib3ce0a753f7220c3ee2556425e9798b0c4a906f3

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.opendev.org/672574

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 11.1.0 release.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/672574
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=2fb2d1204c9ada04c665d5a2aa6f7d5274eaac61
Submitter: Zuul
Branch: master

commit 2fb2d1204c9ada04c665d5a2aa6f7d5274eaac61
Author: Alan Bishop <email address hidden>
Date: Wed Jul 24 10:27:26 2019 -0700

    Provide multipath.conf to containers that need it

    With [1], /etc/multipath.conf is configured for use by the multipath
    daemon running in its own container. However, other containerized
    services (such as cinder-volume) execute commands that also require
    access to multipath.conf. This patch adds a volume mount to each
    container that needs access to the file.

    [1] https://review.opendev.org/665456

    Related-Bug: #1834042
    Change-Id: If76c935b288013c858e7d3e477021210d319547a