undercloud install breaks shell command line

Bug #1833302 reported by Alex Schultz
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
tripleo
Fix Released
High
Alex Schultz

Bug Description

Description of problem:
After installing the undercloud, the user's shell is left in a broken state such that a user needs to run a reset to be able to see what's being typed. This is likely caused by podman or ansible eating escape sequences during the installation.

Version-Release number of selected component (if applicable):

How reproducible:
Every time

Steps to Reproduce:
1. Run undercloud install to completion
2. attempt to type something on the command line
3.

Actual results:
The user's input is not shown and line breaks are ignored

Expected results:
Normal user input should appear

Additional info:

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-tripleoclient (master)

Fix proposed to branch: master
Review: https://review.opendev.org/666172

Changed in tripleo:
status: Triaged → In Progress
tags: added: stein-backport-potential
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-tripleoclient (master)

Reviewed: https://review.opendev.org/666172
Committed: https://git.openstack.org/cgit/openstack/python-tripleoclient/commit/?id=e1a051d6ac890cd68f5bf5fff251fa445d7ad8f9
Submitter: Zuul
Branch: master

commit e1a051d6ac890cd68f5bf5fff251fa445d7ad8f9
Author: Alex Schultz <email address hidden>
Date: Tue Jun 18 15:21:46 2019 -0600

    Send terminal erase sequence on tripleo deploy

    We're seeing some escape sequences being dropped when we run the
    deployment via the undercloud. This causes a user to have to run a reset
    after the undercloud installation in order to be able to use their shell
    command line again. We can avoid this if we send an terminal erase line
    sequence to trim the rest of the line at the end of the deploy.

    Change-Id: Ibb74bfebfaab2cd122abe1bc3cd5bbd2562ccfc5
    Closes-Bug: #1833302

Changed in tripleo:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-tripleoclient (stable/stein)

Fix proposed to branch: stable/stein
Review: https://review.opendev.org/668174

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-tripleoclient (stable/stein)

Reviewed: https://review.opendev.org/668174
Committed: https://git.openstack.org/cgit/openstack/python-tripleoclient/commit/?id=7d41f81ecad3d4692a5ca97d3ad7760d6287ca82
Submitter: Zuul
Branch: stable/stein

commit 7d41f81ecad3d4692a5ca97d3ad7760d6287ca82
Author: Alex Schultz <email address hidden>
Date: Tue Jun 18 15:21:46 2019 -0600

    Send terminal erase sequence on tripleo deploy

    We're seeing some escape sequences being dropped when we run the
    deployment via the undercloud. This causes a user to have to run a reset
    after the undercloud installation in order to be able to use their shell
    command line again. We can avoid this if we send an terminal erase line
    sequence to trim the rest of the line at the end of the deploy.

    Conflicts:
     tripleoclient/tests/v1/tripleo/test_tripleo_deploy.py

    Change-Id: Ibb74bfebfaab2cd122abe1bc3cd5bbd2562ccfc5
    Closes-Bug: #1833302
    (cherry picked from commit e1a051d6ac890cd68f5bf5fff251fa445d7ad8f9)

tags: added: in-stable-stein
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/python-tripleoclient 11.5.0

This issue was fixed in the openstack/python-tripleoclient 11.5.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/python-tripleoclient 12.1.0

This issue was fixed in the openstack/python-tripleoclient 12.1.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-tripleoclient (master)

Fix proposed to branch: master
Review: https://review.opendev.org/677296

Changed in tripleo:
status: Fix Released → In Progress
milestone: train-2 → train-3
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-tripleoclient (master)

Reviewed: https://review.opendev.org/677296
Committed: https://git.openstack.org/cgit/openstack/python-tripleoclient/commit/?id=fddcb9e0755beec8eff3b7246a3b7b799a8ec7f2
Submitter: Zuul
Branch: master

commit fddcb9e0755beec8eff3b7246a3b7b799a8ec7f2
Author: Alex Schultz <email address hidden>
Date: Mon Aug 19 14:43:31 2019 -0600

    Use reset to fix cmdline

    Reset is an application provided via ncurses which is useful in
    resetting a terminal when things go wrong. Since podman is eating some
    of the terminal output, it can leave the cmdline in a broken state at
    the end of the undercloud install. We tried to address it outselves but
    let's reuse an existing application instead. -I being passed to reset
    skips the initialization strings which can erase the output.

    Change-Id: Id9aa7910032588605977f4725385503cf0a235bc
    Closes-Bug: #1833302

Changed in tripleo:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-tripleoclient (stable/stein)

Fix proposed to branch: stable/stein
Review: https://review.opendev.org/677569

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-tripleoclient (stable/stein)

Reviewed: https://review.opendev.org/677569
Committed: https://git.openstack.org/cgit/openstack/python-tripleoclient/commit/?id=ffb86df96519357430a8bd38da5a58cd8789ccd7
Submitter: Zuul
Branch: stable/stein

commit ffb86df96519357430a8bd38da5a58cd8789ccd7
Author: Alex Schultz <email address hidden>
Date: Mon Aug 19 14:43:31 2019 -0600

    Use reset to fix cmdline

    Reset is an application provided via ncurses which is useful in
    resetting a terminal when things go wrong. Since podman is eating some
    of the terminal output, it can leave the cmdline in a broken state at
    the end of the undercloud install. We tried to address it outselves but
    let's reuse an existing application instead. -I being passed to reset
    skips the initialization strings which can erase the output.

    Conflicts:
     tripleoclient/tests/v1/tripleo/test_tripleo_deploy.py

    Change-Id: Id9aa7910032588605977f4725385503cf0a235bc
    Closes-Bug: #1833302
    (cherry picked from commit fddcb9e0755beec8eff3b7246a3b7b799a8ec7f2)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/python-tripleoclient 11.5.1

This issue was fixed in the openstack/python-tripleoclient 11.5.1 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/python-tripleoclient 12.2.0

This issue was fixed in the openstack/python-tripleoclient 12.2.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.