Openstack packages are not updated on overcloud nodes during Rocky minor upgrade

[Anton Antonov]

Description:

   The delorean repos are not defined on overcloud nodes when "openstack overcloud update run" is executed. Therefore, only packages from Centos repos are updated.

Steps to reproduce:

1. Update undercloud
```
yum install -y https://trunk.rdoproject.org/centos7/current/python2-tripleo-repos-0.0.1-0.20190612102512.9b3187e.el7.noarch.rpm

tripleo-repos -b rocky current ceph
yum -y update
openstack undercloud upgrade
```

2. Prepare images and overcloud update:
```

openstack overcloud update prepare ...
openstack overcloud external-update run --tags container_image_prepare

```

3. Update overcloud node(s)
```
openstack overcloud update run --nodes ...
```

Expected results:

  All packages and docker images are updated on overcloud node(s).

Actual results:

  Only packages from Centos repos are updated. For example:

On undecrloud node:
```
(undercloud) [stack@undercloud ~]$ yum repolist
Loaded plugins: fastestmirror, priorities
Determining fastest mirrors
 * base: centos.serverspace.co.uk
 * extras: mirror.econdc.com
 * updates: mirror.econdc.com
repo id repo name status
!base/7/x86_64 CentOS-7 - Base 10,019
!delorean-rocky delorean-os-net-config-f535a00522ef3476d7646e4c4460c041d73 762+328
!delorean-rocky-build-deps dlrn-rocky-build-deps 110+50
!delorean-rocky-testing dlrn-rocky-testing 745+680
!extras/7/x86_64 CentOS-7 - Extras 409
!rdo-qemu-ev/x86_64 RDO CentOS-7 - QEMU EV 75
!tripleo-centos-ceph-luminous tripleo-centos-ceph-luminous 224
!updates/7/x86_64 CentOS-7 - Updates 2,076

(undercloud) [stack@undercloud ~]$ rpm -qa|grep openv
openvswitch-2.11.0-4.el7.x86_64
```

On an updated Controller node:
```
[root@ap12-ctrl3 ~]# yum repolist
Loaded plugins: fastestmirror, priorities
Loading mirror speeds from cached hostfile
 * base: centos.serverspace.co.uk
 * extras: centos.serverspace.co.uk
 * updates: mirror.as29550.net
repo id repo name status
!base/7/x86_64 CentOS-7 - Base 10,019
!centos7-rt CentOS 7 - Realtime 150
!extras/7/x86_64 CentOS-7 - Extras 409
!updates/7/x86_64 CentOS-7 - Updates 2,076

[root@ap12-ctrl3 ~]# rpm -qa|grep openv
openvswitch-2.10.1-3.el7.x86_64
```

If I define the delorean repos on this node quite a few packages could be updated:
```
[root@ap12-ctrl3 ~]# yum update

...

Dependencies Resolved

================================================================================================
 Package Arch Version Repository Size
================================================================================================
Updating:
 openstack-heat-agents noarch 1.7.1-0.20190420000616.41c7faf.el7 delorean-rocky 3.1 k
 openstack-selinux noarch 0.8.19-0.20190606142428.06faac7.el7 delorean-rocky 182 k
 openvswitch x86_64 1:2.11.0-4.el7 delorean-rocky-testing
                                                                                          1.9 M
 os-apply-config noarch 9.1.2-0.20190420051110.ec6aaba.el7 delorean-rocky 46 k
 os-collect-config noarch 9.2.2-0.20190420031120.88a8631.el7 delorean-rocky 43 k
 os-net-config noarch 9.3.1-0.20190614124601.f535a00.el7 delorean-rocky 309 k
 os-refresh-config noarch 9.1.2-0.20190420064352.8b84e52.el7 delorean-rocky 15 k
 osops-tools-monitoring-oschecks
                              noarch 0.0.1-0.20190420093204.b797e26.el7 delorean-rocky 40 k
 puppet-aodh noarch 13.3.2-0.20190420085324.420bdb1.el7 delorean-rocky 46 k
 puppet-barbican noarch 13.3.2-0.20190420054600.c8465ca.el7 delorean-rocky 44 k
 puppet-ceilometer noarch 13.3.2-0.20190420081927.d294c49.el7 delorean-rocky 57 k
 puppet-ceph noarch 2.6.1-0.20190425104853.6d67b24.el7 delorean-rocky 51 k
 puppet-cinder noarch 13.3.3-0.20190420065552.c5967d5.el7 delorean-rocky 98 k
 puppet-congress noarch 13.3.2-0.20190420073042.3d5c716.el7 delorean-rocky 33 k
 puppet-designate noarch 13.3.2-0.20190420052654.714de4b.el7 delorean-rocky 53 k
 puppet-ec2api noarch 13.3.2-0.20190420062221.782a32d.el7 delorean-rocky 33 k
 puppet-glance noarch 13.3.2-0.20190420084238.45584f0.el7 delorean-rocky 70 k
 puppet-gnocchi noarch 13.3.2-0.20190420055557.9c16b41.el7 delorean-rocky 47 k
 puppet-heat noarch 13.3.2-0.20190420082829.e887081.el7 delorean-rocky 55 k
 puppet-horizon noarch 13.3.2-0.20190420060311.a0f8f78.el7 delorean-rocky 49 k
 puppet-ironic noarch 13.3.2-0.20190420083535.5847f5b.el7 delorean-rocky 93 k
 puppet-keystone noarch 13.3.2-0.20190420051956.8ccd27d.el7 delorean-rocky 113 k
 puppet-manila noarch 13.3.2-0.20190610133511.001ed33.el7 delorean-rocky 64 k
 puppet-midonet noarch 1:1.0.0-0.20190420095231.a8cec1d.el7 delorean-rocky 55 k
 puppet-mistral noarch 13.3.2-0.20190420084920.324f29a.el7 delorean-rocky 46 k
 puppet-n1k-vsm noarch 0.0.2-0.20190420100435.92401b8.el7 delorean-rocky 18 k
 puppet-neutron noarch 13.3.2-0.20190420052312.594ebd3.el7 delorean-rocky 175 k
 puppet-nova noarch 13.3.2-0.20190605101400.bad938f.el7 delorean-rocky 157 k
 puppet-octavia noarch 13.3.2-0.20190531002607.733344b.el7 delorean-rocky 50 k
 puppet-openstack_extras noarch 13.3.2-0.20190420072608.d650bd8.el7 delorean-rocky 40 k
 puppet-openstacklib noarch 13.3.2-0.20190420090713.05a84dd.el7 delorean-rocky 49 k
 puppet-oslo noarch 13.3.2-0.20190420074431.a4a4f52.el7 delorean-rocky 36 k
 puppet-ovn noarch 13.3.2-0.20190420053443.c236c46.el7 delorean-rocky 19 k
 puppet-panko noarch 13.3.2-0.20190420053740.ffd3163.el7 delorean-rocky 36 k
 puppet-qdr noarch 2.3.2-0.20190420050401.4d9494c.el7 delorean-rocky 24 k
 puppet-sahara noarch 13.3.2-0.20190420083852.229e3c0.el7 delorean-rocky 47 k
 puppet-swift noarch 13.3.2-0.20190420083150.f7a7cf7.el7 delorean-rocky 91 k
 puppet-tacker noarch 13.3.2-0.20190420045214.76b3615.el7 delorean-rocky 32 k
 puppet-tripleo noarch 9.4.1-0.20190608052722.b56985d.el7 delorean-rocky 252 k
 puppet-trove noarch 13.3.2-0.20190420055918.7bd85bc.el7 delorean-rocky 56 k
 puppet-vswitch noarch 9.3.2-0.20190521193334.e7582bb.el7 delorean-rocky 33 k
 puppet-zaqar noarch 13.3.2-0.20190420065858.cf6ae7c.el7 delorean-rocky 39 k
 python-heat-agent noarch 1.7.1-0.20190420000616.41c7faf.el7 delorean-rocky 12 k
 python-heat-agent-ansible noarch 1.7.1-0.20190420000616.41c7faf.el7 delorean-rocky 4.1 k
 python-heat-agent-apply-config
                              noarch 1.7.1-0.20190420000616.41c7faf.el7 delorean-rocky 3.3 k
 python-heat-agent-docker-cmd noarch 1.7.1-0.20190420000616.41c7faf.el7 delorean-rocky 3.9 k
 python-heat-agent-hiera noarch 1.7.1-0.20190420000616.41c7faf.el7 delorean-rocky 3.9 k
 python-heat-agent-json-file noarch 1.7.1-0.20190420000616.41c7faf.el7 delorean-rocky 3.2 k
 python-heat-agent-puppet noarch 1.7.1-0.20190420000616.41c7faf.el7 delorean-rocky 4.5 k
 python2-cinderclient noarch 4.0.2-0.20190515055500.44bcd69.el7 delorean-rocky 256 k
 qemu-img-ev x86_64 10:2.12.0-18.el7_6.5.1 rdo-qemu-ev 1.3 M

Transaction Summary
================================================================================================
Upgrade 51 Packages

Total download size: 6.3 M
```

Environment:
```
(undercloud) [stack@undercloud ~]$ rpm -qa|grep tripleo
ansible-role-tripleo-modify-image-1.0.1-0.20190612031350.367f3e0.el7.noarch
puppet-tripleo-9.4.1-0.20190608052722.b56985d.el7.noarch
openstack-tripleo-validations-9.3.2-0.20190611232838.8a84c01.el7.noarch
openstack-tripleo-image-elements-9.1.1-0.20190604163040.a66a60d.el7.noarch
openstack-tripleo-heat-templates-9.3.1-0.20190613210447.11e842d.el7.noarch
python-tripleoclient-heat-installer-10.6.2-0.20190607003405.8d9fa8a.el7.noarch
ansible-tripleo-ipsec-9.1.1-0.20190513182453.ffe104c.el7.noarch
python2-tripleo-common-9.5.1-0.20190611182931.83db258.el7.noarch
openstack-tripleo-puppet-elements-9.0.2-0.20190605172111.81729a1.el7.noarch
python2-tripleo-repos-0.0.1-0.20190612102607.9b3187e.el7.noarch
openstack-tripleo-common-containers-9.5.1-0.20190611182931.83db258.el7.noarch
openstack-tripleo-common-9.5.1-0.20190611182931.83db258.el7.noarch
python-tripleoclient-10.6.2-0.20190607003405.8d9fa8a.el7.noarch
```

[Paweł Kubica (pawel-kubica-ca)]

Are there plans to fix this error?