Upgrade failing because of pacemaker_node_ips not matching the node names

[Jiří Stránský]

When upgrading with the latest WIP patches:

pcmk_cluster_setup: node list and addr list should be of the same size when defined and not empty (file: /etc/puppet/modules/pacemaker/manifests/corosync.pp, line: 119, column: 35)

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/664869

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/664869
Committed: https://git.openstack.org/cgit/openstack/puppet-tripleo/commit/?id=42f07b25f784b8b8bb3e58fcbe5db79a0a3abaff
Submitter: Zuul
Branch: master

commit 42f07b25f784b8b8bb3e58fcbe5db79a0a3abaff
Author: Jiri Stransky <email address hidden>
Date: Wed Jun 12 14:17:17 2019 +0200

    Allow overriding pacemaker_node_ips for staged upgrade

    We already have pacemaker_short_node_names_override, and we need a
    matching pacemaker_node_ips_override as the two variables must be
    overriden together.

    Change-Id: Ibd95f4536c033af2094bd079cc81eeba18a36352
    Partial-Bug: #1832361

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/643056
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=cb8caaae4381e6a3de81a517dc7c6b23d272e024
Submitter: Zuul
Branch: master

commit cb8caaae4381e6a3de81a517dc7c6b23d272e024
Author: Sofer Athlan-Guyot <email address hidden>
Date: Wed Mar 13 13:15:56 2019 +0100

    Setup cluster definition based on the ansible limit option.

    During upgrade we're re-creating the pacemaker cluster one node at a
    time. So we need to override the cluster definition. We do this by
    collecting the ansible_limit variable and mapping the controller
    defined as member of the cluster.

    Co-Authored-By: Jose Luis Franco Arza <email address hidden>
    Co-Authored-By: Jiri Stransky <email address hidden>
    Implements: blueprint upgrades-with-os
    Closes-Bug: #1832361
    Depends-On: Ibd95f4536c033af2094bd079cc81eeba18a36352
    Depends-On: Ia108af3799dfd1be24c6ea738e42f0cde19c90c3
    Depends-On: I3fa0717203f3f6eae852d019bec71e97eb485aa2
    Change-Id: I3cfd4272449b207874723682903505d2bbdb435b

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/stein
Review: https://review.opendev.org/667145

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/stein
Review: https://review.opendev.org/667352

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/667352
Committed: https://git.openstack.org/cgit/openstack/puppet-tripleo/commit/?id=74a7262e2d689f9dc28a611fc5c417a7c9d23999
Submitter: Zuul
Branch: stable/stein

commit 74a7262e2d689f9dc28a611fc5c417a7c9d23999
Author: Jiri Stransky <email address hidden>
Date: Wed Jun 12 14:17:17 2019 +0200

    Allow overriding pacemaker_node_ips for staged upgrade

    We already have pacemaker_short_node_names_override, and we need a
    matching pacemaker_node_ips_override as the two variables must be
    overriden together.

    Change-Id: Ibd95f4536c033af2094bd079cc81eeba18a36352
    Partial-Bug: #1832361
    (cherry picked from commit 42f07b25f784b8b8bb3e58fcbe5db79a0a3abaff)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/667145
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=534a23576cd8820439d6e9a79b9c1e58362e6bcc
Submitter: Zuul
Branch: stable/stein

commit 534a23576cd8820439d6e9a79b9c1e58362e6bcc
Author: Sofer Athlan-Guyot <email address hidden>
Date: Wed Mar 13 13:15:56 2019 +0100

    Setup cluster definition based on the ansible limit option.

    During upgrade we're re-creating the pacemaker cluster one node at a
    time. So we need to override the cluster definition. We do this by
    collecting the ansible_limit variable and mapping the controller
    defined as member of the cluster.

    Co-Authored-By: Jose Luis Franco Arza <email address hidden>
    Co-Authored-By: Jiri Stransky <email address hidden>
    Implements: blueprint upgrades-with-os
    Closes-Bug: #1832361
    Depends-On: Ibd95f4536c033af2094bd079cc81eeba18a36352
    Depends-On: Ia108af3799dfd1be24c6ea738e42f0cde19c90c3
    Depends-On: I3fa0717203f3f6eae852d019bec71e97eb485aa2
    Change-Id: I3cfd4272449b207874723682903505d2bbdb435b
    (cherry picked from commit cb8caaae4381e6a3de81a517dc7c6b23d272e024)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 10.6.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 11.1.0 release.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/696708
Committed: https://git.openstack.org/cgit/openstack/puppet-tripleo/commit/?id=07c525c8d769842cb544f11fd7787bebef8e1254
Submitter: Zuul
Branch: master

commit 07c525c8d769842cb544f11fd7787bebef8e1254
Author: Michele Baldessari <email address hidden>
Date: Fri Nov 29 15:34:29 2019 +0100

    ovn_dbs override support

    These hiera keys are needed to support the upgrade-with-os
    blueprint. This support was added for other services already
    see LP#1832361

    Related-Bug: #1854519

    Tested-by: Jose Luis Franco Arza <email address hidden>

    Change-Id: I7bff96c0b0238e4aeaa33e0ec343a75e08b6a2f7

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/train
Review: https://review.opendev.org/697009

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/697009
Committed: https://git.openstack.org/cgit/openstack/puppet-tripleo/commit/?id=70385618140b47dd28cbf84cf9c496d8ccd3a77f
Submitter: Zuul
Branch: stable/train

commit 70385618140b47dd28cbf84cf9c496d8ccd3a77f
Author: Michele Baldessari <email address hidden>
Date: Fri Nov 29 15:34:29 2019 +0100

    ovn_dbs override support

    These hiera keys are needed to support the upgrade-with-os
    blueprint. This support was added for other services already
    see LP#1832361

    Related-Bug: #1854519

    Tested-by: Jose Luis Franco Arza <email address hidden>

    Change-Id: I7bff96c0b0238e4aeaa33e0ec343a75e08b6a2f7
    (cherry picked from commit 07c525c8d769842cb544f11fd7787bebef8e1254)

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/stein
Review: https://review.opendev.org/697415

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/697415
Committed: https://git.openstack.org/cgit/openstack/puppet-tripleo/commit/?id=b392eb655acb393d71dd2e5a4c1a55279d543cce
Submitter: Zuul
Branch: stable/stein

commit b392eb655acb393d71dd2e5a4c1a55279d543cce
Author: Michele Baldessari <email address hidden>
Date: Fri Nov 29 15:34:29 2019 +0100

    ovn_dbs override support

    These hiera keys are needed to support the upgrade-with-os
    blueprint. This support was added for other services already
    see LP#1832361

    Related-Bug: #1854519

    NB: Slight cherry-pick concflict in stein due to missing context
    Tested-by: Jose Luis Franco Arza <email address hidden>

    Change-Id: I7bff96c0b0238e4aeaa33e0ec343a75e08b6a2f7
    (cherry picked from commit 07c525c8d769842cb544f11fd7787bebef8e1254)
    (cherry picked from commit 70385618140b47dd28cbf84cf9c496d8ccd3a77f)