tripleo

keystone: -DFOREGROUND is dup'd on command line

Bug #1832090 reported by Dan Prince on 2019-06-08

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	tripleo	Fix Released	Low	Dan Prince	tripleo train-2

Bug Description

Just noticed we duplicate the args for apache:

/usr/sbin/httpd -DFOREGROUND -DFOREGROUND

No need to add them in t-h-t as Kolla does this automatically when using kolla_start.

Tags:

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2019-06-08: Fix proposed to tripleo-heat-templates (master)

Fix proposed to branch: master
Review: https://review.opendev.org/664135

Changed in tripleo:
assignee:	nobody → Dan Prince (dan-prince)
status:	New → In Progress

Dan Prince (dan-prince) on 2019-06-08

Changed in tripleo:
importance:	Undecided → Medium
milestone:	none → train-2

Bogdan Dobrelya (bogdando) on 2019-06-10

Changed in tripleo:
importance:	Medium → Low

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2019-06-13: Fix merged to tripleo-heat-templates (master)

Reviewed: https://review.opendev.org/664135
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=8eaac3026e54a057287301c8c844b54d2c310bc7
Submitter: Zuul
Branch: master

commit 8eaac3026e54a057287301c8c844b54d2c310bc7
Author: Dan Prince <email address hidden>
Date: Sat Jun 8 08:56:03 2019 -0400

keystone: drop duplicate -DFOREGROUND

No need to specify this as kolla adds this arg automatically
when using kolla_start.

Change-Id: Ib179e3bbc827cc438519b19e85bda4a9994376b9
Closes-bug: #1832090

Changed in tripleo:
status:	In Progress → Fix Released

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2019-07-26: Fix included in openstack/tripleo-heat-templates 11.1.0

This issue was fixed in the openstack/tripleo-heat-templates 11.1.0 release.

Revision history for this message

Keigo Noha (knoha) wrote on 2019-08-02:

Hi Dan,

Is it possible to backport it into stable/queens release?

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2019-08-05: Fix proposed to tripleo-heat-templates (stable/stein)

Fix proposed to branch: stable/stein
Review: https://review.opendev.org/674554

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2019-08-07: Fix merged to tripleo-heat-templates (stable/stein)

Reviewed: https://review.opendev.org/674554
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=f4a3563bc3e599f54281d6b3d20feb406e0a6920
Submitter: Zuul
Branch: stable/stein

commit f4a3563bc3e599f54281d6b3d20feb406e0a6920
Author: Dan Prince <email address hidden>
Date: Sat Jun 8 08:56:03 2019 -0400

keystone: drop duplicate -DFOREGROUND

No need to specify this as kolla adds this arg automatically
when using kolla_start.

    Change-Id: Ib179e3bbc827cc438519b19e85bda4a9994376b9
    Closes-bug: #1832090
    (cherry picked from commit 8eaac3026e54a057287301c8c844b54d2c310bc7)

tags:

added: in-stable-stein

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2019-08-16: Fix proposed to tripleo-heat-templates (stable/rocky)

Fix proposed to branch: stable/rocky
Review: https://review.opendev.org/676994

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2019-08-17: Fix merged to tripleo-heat-templates (stable/rocky)

Reviewed: https://review.opendev.org/676994
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=1c7b5ff95f0c6f2920aa6749b22e838736d600f0
Submitter: Zuul
Branch: stable/rocky

commit 1c7b5ff95f0c6f2920aa6749b22e838736d600f0
Author: Dan Prince <email address hidden>
Date: Sat Jun 8 08:56:03 2019 -0400

keystone: drop duplicate -DFOREGROUND

No need to specify this as kolla adds this arg automatically
when using kolla_start.

    Note that the commit this was cherry picked from does not apply
    cleanly, as docker/services/keystone.yaml is used in Rocky and
    earlier, while Stein and later use puppet/services/keystone.yaml.

Conflicts:
puppet/services/keystone.yaml

    Change-Id: Ib179e3bbc827cc438519b19e85bda4a9994376b9
    Closes-bug: #1832090
    (cherry picked from commit 8eaac3026e54a057287301c8c844b54d2c310bc7)

tags:

added: in-stable-rocky

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2019-08-20: Fix proposed to tripleo-heat-templates (stable/queens)

Fix proposed to branch: stable/queens
Review: https://review.opendev.org/677430

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2019-08-21: Fix merged to tripleo-heat-templates (stable/queens)

#10

Reviewed: https://review.opendev.org/677430
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=44581caf5bc676ae98ea0438a5d9f4afdbe5bdf7
Submitter: Zuul
Branch: stable/queens

commit 44581caf5bc676ae98ea0438a5d9f4afdbe5bdf7
Author: Dan Prince <email address hidden>
Date: Sat Jun 8 08:56:03 2019 -0400

keystone: drop duplicate -DFOREGROUND

No need to specify this as kolla adds this arg automatically
when using kolla_start.

Conflicts:
puppet/services/keystone.yaml

    Change-Id: Ib179e3bbc827cc438519b19e85bda4a9994376b9
    Closes-bug: #1832090
    (cherry picked from commit 8eaac3026e54a057287301c8c844b54d2c310bc7)
    (cherry picked from commit 1c7b5ff95f0c6f2920aa6749b22e838736d600f0)