EnablePackageInstall might be ignored for some packages manipulations for t-h-t

[Bogdan Dobrelya]

it's something that's slipped in, and we need to add checks around it to ensure it's handled correctly when EnablePackageInstall is set to false.

Like there is host_prep_tasks installing podman from RPMs.
Or upgrade_tasks wanting to pre-install some packages.

This all should be controlled by EnablePackageInstall and nooped if it is set to False.

[Bogdan Dobrelya (bogdando)]

15:29:41 - mwhahaha: upgrade tasks should be OK since those will be enablepackageinstall is true
15:29:57 - mwhahaha: it's really only the initiall installation of packages

[Alex Schultz (alex-schultz)]

upgrade tasks are fine since at that point the system must be registered to some repository. It's the initiall installation where we really should be honoring the EnablePackageInstall and skipping the package call. That being said we need to take into consideration logic where the package isn't actually installed in subsequent tasks and error if it's not.

[Kevin Carter (kevin-carter)]

Reviews to resolve this issue: https://review.opendev.org/#/q/topic:bug/1831246+(status:open+OR+status:merged)

[OpenStack Infra (hudson-openstack)]

Change abandoned by Kevin Carter (cloudnull) (<email address hidden>) on branch: master
Review: https://review.opendev.org/662496
Reason: no longer relevant