/etc/containers/registries.conf incorrectly populated

[Steve Baker]

buildah is now consuming /etc/containers/registries.conf and it is revealing a problem with how we're populating it. During prepare the following error is raised for each image:
Error pulling image:
buildah pull 192.168.24.1:8787/rhosp15/openstack-nova-compute:20190523.1
None
error checking if pulling from registry for "docker://192.168.24.1:8787/rhosp15/openstack-nova-compute:20190523.1" is blocked: unable to parse the registries configuration (/etc/containers/registries.conf): invalid URL '192.168.24.1:8787': parse 192.168.24.1:8787: first path segment in URL cannot contain colon

registries.conf contains:
[registries.insecure]
registries = ['192.168.24.1:8787']

but it should contain:
[registries.insecure]
registries = ['192.168.24.1']

I suggest we just drop the :8787 from the populated DockerInsecureRegistryAddress[1] since we no longer have to conform to what docker requires

[1] https://opendev.org/openstack/python-tripleoclient/src/branch/master/tripleoclient/v1/undercloud_config.py#L421-L424

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/662332

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/662332
Committed: https://git.openstack.org/cgit/openstack/python-tripleoclient/commit/?id=b44d6f84ed288281b628e75bc2ae8f952f2055d4
Submitter: Zuul
Branch: master

commit b44d6f84ed288281b628e75bc2ae8f952f2055d4
Author: Steve Baker <email address hidden>
Date: Fri May 31 09:02:48 2019 +1200

    Drop the port from DockerInsecureRegistryAddress

    This is causing a problem with buildah/podman when they consume the
    populated /etc/containers/registries.conf. When deployed with docker
    the original behaviour is maintained.

    Change-Id: I1f2f2690330af1f7b143c01affe088f954df8d7c
    Closes-Bug: #1831152

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/stein
Review: https://review.opendev.org/663010

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/python-tripleoclient 12.0.0 release.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/663010
Committed: https://git.openstack.org/cgit/openstack/python-tripleoclient/commit/?id=f36d899571a293dfd868bc4858db2eebe43f83e8
Submitter: Zuul
Branch: stable/stein

commit f36d899571a293dfd868bc4858db2eebe43f83e8
Author: Steve Baker <email address hidden>
Date: Fri May 31 09:02:48 2019 +1200

    Drop the port from DockerInsecureRegistryAddress

    This is causing a problem with buildah/podman when they consume the
    populated /etc/containers/registries.conf. When deployed with docker
    the original behaviour is maintained.

    Change-Id: I1f2f2690330af1f7b143c01affe088f954df8d7c
    Closes-Bug: #1831152
    (cherry picked from commit b44d6f84ed288281b628e75bc2ae8f952f2055d4)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/python-tripleoclient 11.5.0 release.