[stable [queens/pike] ] TypeError when using DeploymentServerBlacklist

[Rabi Mishra]

This only impacts stable/[queens/pike] as the minor update code has been removed from tht in rocky with https://review.opendev.org/#/c/553500/.

Scenario:

if a SoftwareDeployment is in UPDATE_FAILED state for some reason, heat would replace it. However, if the actions property is set to [] (as in the case with DeploymentServerBlacklist), heat would create a new resource, but not a new associated deployment and the resource_id would be None. Therefore other deployments referencing attributes would fail with TypeError. Though this can be be fixed in heat where it would return None, it would be bettter to reference those attributes conditionally too.

traceback:

2019-05-24 13:44:25Z [overcloud-Compute-7thtexunb44d-2-rkjsfpfgr6xj.SshHostPubKey]: UPDATE_COMPLETE state changed
2019-05-24 13:44:26Z [overcloud-Compute-7thtexunb44d-2-rkjsfpfgr6xj.NodeTLSCAData]: UPDATE_COMPLETE state changed
2019-05-24 13:44:26Z [overcloud-Compute-7thtexunb44d-2-rkjsfpfgr6xj.ComputeExtraConfigPre]: UPDATE_COMPLETE state changed
2019-05-24 13:44:26Z [overcloud-Compute-7thtexunb44d-2-rkjsfpfgr6xj.NodeExtraConfig]: UPDATE_IN_PROGRESS state changed
2019-05-24 13:44:26Z [overcloud-Controller-kcycaxnydj6r.1]: UPDATE_COMPLETE state changed
2019-05-24 13:44:26Z [overcloud-Compute-7thtexunb44d-0-gyigv4ejpfs7.NodeTLSCAData]: UPDATE_COMPLETE state changed
2019-05-24 13:44:26Z [overcloud-Compute-7thtexunb44d-0-gyigv4ejpfs7.ComputeExtraConfigPre]: UPDATE_COMPLETE state changed
2019-05-24 13:44:26Z [overcloud-Compute-7thtexunb44d-0-gyigv4ejpfs7.SshHostPubKey]: UPDATE_COMPLETE state changed
2019-05-24 13:44:26Z [overcloud-Compute-7thtexunb44d-0-gyigv4ejpfs7.NodeExtraConfig]: UPDATE_IN_PROGRESS state changed
2019-05-24 13:44:28Z [overcloud-Compute-7thtexunb44d-2-rkjsfpfgr6xj.NodeExtraConfig]: UPDATE_COMPLETE state changed
2019-05-24 13:44:29Z [overcloud-Compute-7thtexunb44d-0-gyigv4ejpfs7.NodeExtraConfig]: UPDATE_COMPLETE state changed
2019-05-24 13:44:29Z [overcloud-Compute-7thtexunb44d-1-javburr7q456]: UPDATE_COMPLETE Stack UPDATE completed successfully
2019-05-24 13:44:30Z [overcloud-Compute-7thtexunb44d.1]: UPDATE_COMPLETE state changed
2019-05-24 13:44:30Z [overcloud-CephStorage-b65htjta72u2-10-li7otlebc46i]: UPDATE_COMPLETE Stack UPDATE completed successfully
2019-05-24 13:44:30Z [overcloud-CephStorage-b65htjta72u2.10]: UPDATE_COMPLETE state changed
2019-05-24 13:44:30Z [overcloud-CephStorage-b65htjta72u2]: UPDATE_FAILED resources[1]: object of type 'NoneType' has no len()
Traceback (most recent call last):

  File "/usr/lib/python2.7/site-packages/oslo_messaging/rpc/server.py", line 160, in _process_incoming
    res = self.dispatcher.dispatch(message)

  File "/usr/lib/p
2019-05-24 13:44:31Z [overcloud.CephStorage]: UPDATE_FAILED resources.CephStorage: resources[1]: object of type 'NoneType' has no len()
Traceback (most recent call last):

  File "/usr/lib/python2.7/site-packages/oslo_messaging/rpc/server.py", line 160, in _process_incoming
    res = self.dispatcher.dispatch(messa
2019-05-24 13:44:32Z [overcloud-Controller-kcycaxnydj6r-3-hi5mnxmfcrwu]: UPDATE_COMPLETE Stack UPDATE completed successfully
2019-05-24 13:44:32Z [overcloud-Compute-7thtexunb44d-3-7r3fbbmftpli]: UPDATE_COMPLETE Stack UPDATE completed successfully
2019-05-24 13:44:33Z [overcloud-Compute-7thtexunb44d.3]: UPDATE_COMPLETE state changed
2019-05-24 13:44:33Z [overcloud-Controller-kcycaxnydj6r.3]: UPDATE_COMPLETE state changed
2019-05-24 13:44:33Z [overcloud-Controller-kcycaxnydj6r]: UPDATE_FAILED resources[2]: object of type 'NoneType' has no len()
Traceback (most recent call last):

  File "/usr/lib/python2.7/site-packages/oslo_messaging/rpc/server.py", line 160, in _process_incoming
    res = self.dispatcher.dispatch(message)

  File "/usr/lib/p
2019-05-24 13:44:34Z [overcloud.Controller]: UPDATE_FAILED resources.Controller: resources[2]: object of type 'NoneType' has no len()
Traceback (most recent call last):

  File "/usr/lib/python2.7/site-packages/oslo_messaging/rpc/server.py", line 160, in _process_incoming
    res = self.dispatcher.dispatch(messag
2019-05-24 13:44:36Z [overcloud-Compute-7thtexunb44d-2-rkjsfpfgr6xj]: UPDATE_COMPLETE Stack UPDATE completed successfully
2019-05-24 13:44:37Z [overcloud-Compute-7thtexunb44d.2]: UPDATE_COMPLETE state changed
2019-05-24 13:44:37Z [overcloud-Compute-7thtexunb44d-0-gyigv4ejpfs7]: UPDATE_COMPLETE Stack UPDATE completed successfully
2019-05-24 13:44:38Z [overcloud-Compute-7thtexunb44d.0]: UPDATE_COMPLETE state changed
2019-05-24 13:44:38Z [overcloud-Compute-7thtexunb44d]: UPDATE_COMPLETE Stack UPDATE completed successfully
2019-05-24 13:44:39Z [overcloud.Compute]: UPDATE_COMPLETE state changed
2019-05-24 13:45:08Z [overcloud]: UPDATE_FAILED resources.CephStorage: resources[1]: object of type 'NoneType' has no len()
Traceback (most recent call last):

  File "/usr/lib/python2.7/site-packages/oslo_messaging/rpc/server.py", line 160, in _process_incoming
    res = self.dispatcher.dispatch(messa

 Stack overcloud UPDATE_FAILED

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/queens
Review: https://review.opendev.org/661890

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/661890
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=2c4004d7ace1ee540d9770d5733e050a1a62fa34
Submitter: Zuul
Branch: stable/queens

commit 2c4004d7ace1ee540d9770d5733e050a1a62fa34
Author: Rabi Mishra <email address hidden>
Date: Wed May 29 10:08:08 2019 +0530

    [stable queens/pike] Use server_not_blacklisted condition

    If the 'actions' is set to [] for UpdateDeployment, doing get_attr
    would throw an error, as the deployment are not created in heat and
    resource_id would be None. Though this should be fixed in heat,
    it would be good to get attributes from UpdateDeployment conditionally.

    This minor update code has been removed since stable/rocky with
    change I6c5eafe76eb53bc38d100a9ba132dd8fe6dd2d5f.

    Change-Id: I86fc82e604fbdee2881c4ef0ad6602da412a7ee6
    Closes-Bug: #1830837

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/pike
Review: https://review.opendev.org/663495

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/663495
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=ebb5dde52f2c40f59c6a2cf9197a6d08f9898d28
Submitter: Zuul
Branch: stable/pike

commit ebb5dde52f2c40f59c6a2cf9197a6d08f9898d28
Author: Rabi Mishra <email address hidden>
Date: Wed May 29 10:08:08 2019 +0530

    [stable queens/pike] Use server_not_blacklisted condition

    If the 'actions' is set to [] for UpdateDeployment, doing get_attr
    would throw an error, as the deployment are not created in heat and
    resource_id would be None. Though this should be fixed in heat,
    it would be good to get attributes from UpdateDeployment conditionally.

    This minor update code has been removed since stable/rocky with
    change I6c5eafe76eb53bc38d100a9ba132dd8fe6dd2d5f.

    Change-Id: I86fc82e604fbdee2881c4ef0ad6602da412a7ee6
    Closes-Bug: #1830837
    (cherry picked from commit 2c4004d7ace1ee540d9770d5733e050a1a62fa34)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 8.4.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates pike-eol release.