This only impacts stable/[queens/pike] as the minor update code has been removed from tht in rocky with https://review.opendev.org/#/c/553500/.
Scenario:
if a SoftwareDeployment is in UPDATE_FAILED state for some reason, heat would replace it. However, if the actions property is set to [] (as in the case with DeploymentServerBlacklist), heat would create a new resource, but not a new associated deployment and the resource_id would be None. Therefore other deployments referencing attributes would fail with TypeError. Though this can be be fixed in heat where it would return None, it would be bettter to reference those attributes conditionally too.
traceback:
2019-05-24 13:44:25Z [overcloud-Compute-7thtexunb44d-2-rkjsfpfgr6xj.SshHostPubKey]: UPDATE_COMPLETE state changed
2019-05-24 13:44:26Z [overcloud-Compute-7thtexunb44d-2-rkjsfpfgr6xj.NodeTLSCAData]: UPDATE_COMPLETE state changed
2019-05-24 13:44:26Z [overcloud-Compute-7thtexunb44d-2-rkjsfpfgr6xj.ComputeExtraConfigPre]: UPDATE_COMPLETE state changed
2019-05-24 13:44:26Z [overcloud-Compute-7thtexunb44d-2-rkjsfpfgr6xj.NodeExtraConfig]: UPDATE_IN_PROGRESS state changed
2019-05-24 13:44:26Z [overcloud-Controller-kcycaxnydj6r.1]: UPDATE_COMPLETE state changed
2019-05-24 13:44:26Z [overcloud-Compute-7thtexunb44d-0-gyigv4ejpfs7.NodeTLSCAData]: UPDATE_COMPLETE state changed
2019-05-24 13:44:26Z [overcloud-Compute-7thtexunb44d-0-gyigv4ejpfs7.ComputeExtraConfigPre]: UPDATE_COMPLETE state changed
2019-05-24 13:44:26Z [overcloud-Compute-7thtexunb44d-0-gyigv4ejpfs7.SshHostPubKey]: UPDATE_COMPLETE state changed
2019-05-24 13:44:26Z [overcloud-Compute-7thtexunb44d-0-gyigv4ejpfs7.NodeExtraConfig]: UPDATE_IN_PROGRESS state changed
2019-05-24 13:44:28Z [overcloud-Compute-7thtexunb44d-2-rkjsfpfgr6xj.NodeExtraConfig]: UPDATE_COMPLETE state changed
2019-05-24 13:44:29Z [overcloud-Compute-7thtexunb44d-0-gyigv4ejpfs7.NodeExtraConfig]: UPDATE_COMPLETE state changed
2019-05-24 13:44:29Z [overcloud-Compute-7thtexunb44d-1-javburr7q456]: UPDATE_COMPLETE Stack UPDATE completed successfully
2019-05-24 13:44:30Z [overcloud-Compute-7thtexunb44d.1]: UPDATE_COMPLETE state changed
2019-05-24 13:44:30Z [overcloud-CephStorage-b65htjta72u2-10-li7otlebc46i]: UPDATE_COMPLETE Stack UPDATE completed successfully
2019-05-24 13:44:30Z [overcloud-CephStorage-b65htjta72u2.10]: UPDATE_COMPLETE state changed
2019-05-24 13:44:30Z [overcloud-CephStorage-b65htjta72u2]: UPDATE_FAILED resources[1]: object of type 'NoneType' has no len()
Traceback (most recent call last):
File "/usr/lib/python2.7/site-packages/oslo_messaging/rpc/server.py", line 160, in _process_incoming
res = self.dispatcher.dispatch(message)
File "/usr/lib/p
2019-05-24 13:44:31Z [overcloud.CephStorage]: UPDATE_FAILED resources.CephStorage: resources[1]: object of type 'NoneType' has no len()
Traceback (most recent call last):
File "/usr/lib/python2.7/site-packages/oslo_messaging/rpc/server.py", line 160, in _process_incoming
res = self.dispatcher.dispatch(messa
2019-05-24 13:44:32Z [overcloud-Controller-kcycaxnydj6r-3-hi5mnxmfcrwu]: UPDATE_COMPLETE Stack UPDATE completed successfully
2019-05-24 13:44:32Z [overcloud-Compute-7thtexunb44d-3-7r3fbbmftpli]: UPDATE_COMPLETE Stack UPDATE completed successfully
2019-05-24 13:44:33Z [overcloud-Compute-7thtexunb44d.3]: UPDATE_COMPLETE state changed
2019-05-24 13:44:33Z [overcloud-Controller-kcycaxnydj6r.3]: UPDATE_COMPLETE state changed
2019-05-24 13:44:33Z [overcloud-Controller-kcycaxnydj6r]: UPDATE_FAILED resources[2]: object of type 'NoneType' has no len()
Traceback (most recent call last):
File "/usr/lib/python2.7/site-packages/oslo_messaging/rpc/server.py", line 160, in _process_incoming
res = self.dispatcher.dispatch(message)
File "/usr/lib/p
2019-05-24 13:44:34Z [overcloud.Controller]: UPDATE_FAILED resources.Controller: resources[2]: object of type 'NoneType' has no len()
Traceback (most recent call last):
File "/usr/lib/python2.7/site-packages/oslo_messaging/rpc/server.py", line 160, in _process_incoming
res = self.dispatcher.dispatch(messag
2019-05-24 13:44:36Z [overcloud-Compute-7thtexunb44d-2-rkjsfpfgr6xj]: UPDATE_COMPLETE Stack UPDATE completed successfully
2019-05-24 13:44:37Z [overcloud-Compute-7thtexunb44d.2]: UPDATE_COMPLETE state changed
2019-05-24 13:44:37Z [overcloud-Compute-7thtexunb44d-0-gyigv4ejpfs7]: UPDATE_COMPLETE Stack UPDATE completed successfully
2019-05-24 13:44:38Z [overcloud-Compute-7thtexunb44d.0]: UPDATE_COMPLETE state changed
2019-05-24 13:44:38Z [overcloud-Compute-7thtexunb44d]: UPDATE_COMPLETE Stack UPDATE completed successfully
2019-05-24 13:44:39Z [overcloud.Compute]: UPDATE_COMPLETE state changed
2019-05-24 13:45:08Z [overcloud]: UPDATE_FAILED resources.CephStorage: resources[1]: object of type 'NoneType' has no len()
Traceback (most recent call last):
File "/usr/lib/python2.7/site-packages/oslo_messaging/rpc/server.py", line 160, in _process_incoming
res = self.dispatcher.dispatch(messa
Stack overcloud UPDATE_FAILED
Fix proposed to branch: stable/queens /review. opendev. org/661890
Review: https:/