periodic-tripleo-standalone-upgrade-stein fails upgrade fetching new containers "Not found image: ... cinder-api:tripleo-ci-testing"

[Marios Andreou]

periodic-tripleo-ci-centos-7-standalone-upgrade-stein job was added to promotion critieria in [1] so blocks Stein promotion. It fails during upgrade when trying to pull new containers. There are two issues -

1. We should not be trying to pull from docker.io for periodic
2. We currently don't have the mnemonic TripleO ci names for tags (current/tripleo-ci-testing etc) in containers in periodic pipeline and so it fails as there is no 'tripleo-ci-testing':

Trace like the following in [2]

    2019-05-21 22:54:41 | 2019-05-21 22:54:41.403 115041 ERROR tripleoclient.v1.tripleo_upgrade.Upgrade [-] Exception: Not found image: docker://docker.io/tripleostein/centos-binary-cinder-api:tripleo-ci-testing: ImageNotFoundException: Not found image: docker://docker.io/tripleostein/centos-binary-cinder-api:tripleo-ci-testing
    2019-05-21 22:54:41 | Traceback (most recent call last):
    2019-05-21 22:54:41 | File "/usr/lib/python2.7/site-packages/tripleoclient/v1/tripleo_deploy.py", line 1207, in _standalone_deploy
    2019-05-21 22:54:41 | parsed_args)

[1] https://review.rdoproject.org/r/#/c/20720/
[2] http://logs.rdoproject.org/openstack-periodic-latest-released/opendev.org/openstack/tripleo-ci/master/periodic-tripleo-ci-centos-7-standalone-upgrade-stein/561fa01/logs/undercloud/home/zuul/standalone_upgrade.log.txt.gz

[Gabriele Cerami (gcerami)]

Fixed by parametrizing docker host in standalone upgrade role at

https://review.opendev.org/660379

[Marios Andreou (marios-b)]

related Add retag tripleo-ci-testing for promotion jobs https://review.opendev.org/660665

[Marios Andreou (marios-b)]

I updated the description so we are tracking both the docker.io issue and the mnemonic named tag in this bug. Related reviews:

https://review.opendev.org/#/c/660615/ standalone upgrade: use container_build_id as tag specifier
https://review.opendev.org/#/c/660379/ standalone upgrade: parametrize registry host
https://review.opendev.org/#/c/660665/ Add retag tripleo-ci-testing for promotion jobs

[Marios Andreou (marios-b)]

also a related bug see comment 4 at https://bugs.launchpad.net/tripleo/+bug/1819583

[Marios Andreou (marios-b)]

update again ... so panda did end up filing a new bug for the tag issue at https://bugs.launchpad.net/tripleo/+bug/1830025 - in any case that is fixed by https://review.opendev.org/#/c/660615/

the retag was abandoned no longer necessary ( https://review.opendev.org/#/c/660665/ )

closing this out. see +bug/1830025 for anything further