[Rocky/Queens Only] Remove pre-upgrade validation tasks

[Jose Luis Franco]

The pre-upgrade validation tasks were mostly thought to validate the right state of the environment before performing an upgrade. However, when they were implemented, they were validating the services as a systemd unit. Once the overcloud services were containerized, these validations didn't make much sense in the overcloud, as all the systemd services were now in containers. Anyway, the validations were left to be used during the undercloud upgrade, which was still non-containerized, but the upgrade approach taken for the undercloud was to skip those validations too: https://github.com/openstack/python-tripleoclient/blob/stable/rocky/tripleoclient/v1/tripleo_deploy.py#L833

So, in order to avoid unnecessary upgrade errors and having a cleaner upgrade (all the pre-upgrade validation tasks are being skipped), let's try to get rid of the pre-upgrade validation tasks for the containerized services.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/rocky
Review: https://review.opendev.org/660377

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/660377
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=7e0a4d0e5282e5e3bcced9368c724ffd6042643f
Submitter: Zuul
Branch: stable/rocky

commit 7e0a4d0e5282e5e3bcced9368c724ffd6042643f
Author: Jose Luis Franco Arza <email address hidden>
Date: Tue May 21 14:41:56 2019 +0200

    [Rocky/Queens Only] Remove pre-upgrade validation tasks in cont services.

    The pre-upgrade validation tasks in the containerized services made
    sense when upgrading from non-containerized to containerized overcloud
    (ocata to pike), however we kept them for queens and rocky
    release thinking about using them during the undercloud upgrade from
    non-containerized to containerized (queens to rocky) but they
    were skipped there too [0]. It's beeing observed in the current
    upgrades taken place by operators, that these validations are
    causing more issues than it was thought, so let's get rid of
    them from all the containerized services in Queens and Rocky.

    Closes-Bug: #1829858

    [0] - https://github.com/openstack/python-tripleoclient/blob/stable/rocky/tripleoclient/v1/tripleo_deploy.py#L833

    Change-Id: If99ea62b6cefb140a9c918b8f6a774658c52d54b

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/queens
Review: https://review.opendev.org/663016

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/663016
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=40467b0f3f187148b2b20562af56c0bbddca3a77
Submitter: Zuul
Branch: stable/queens

commit 40467b0f3f187148b2b20562af56c0bbddca3a77
Author: Jose Luis Franco Arza <email address hidden>
Date: Tue May 21 14:41:56 2019 +0200

    [Rocky/Queens Only] Remove pre-upgrade validation tasks in cont services.

    The pre-upgrade validation tasks in the containerized services made
    sense when upgrading from non-containerized to containerized overcloud
    (ocata to pike), however we kept them for queens and rocky
    release thinking about using them during the undercloud upgrade from
    non-containerized to containerized (queens to rocky) but they
    were skipped there too [0]. It's beeing observed in the current
    upgrades taken place by operators, that these validations are
    causing more issues than it was thought, so let's get rid of
    them from all the containerized services in Queens and Rocky.

    Closes-Bug: #1829858

    [0] - https://github.com/openstack/python-tripleoclient/blob/stable/rocky/tripleoclient/v1/tripleo_deploy.py#L833

    Change-Id: If99ea62b6cefb140a9c918b8f6a774658c52d54b
    (cherry picked from commit 7e0a4d0e5282e5e3bcced9368c724ffd6042643f)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 9.4.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 8.4.0 release.