clients no longer installed on the controllers by default

[Alex Schultz]

Prior to the switch to containers, we had all the service clients installed by default on the controllers. They were installed on the base overcloud image so they where available anywhere. We should still install the clients on the controllers for the operators usage.

They were removed unintentionally as part of https://review.opendev.org/#/c/521172/. We chose to leave the openstackclient, but we forgot to add in the various service related clients.

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.opendev.org/660156

[Bogdan Dobrelya (bogdando)]

nice to have this backported for Standalone environments on Stein

[Alex Schultz (alex-schultz)]

standalone should already have these

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/660156
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=885715855b19ec71ab362d92233478f3afb5a696
Submitter: Zuul
Branch: master

commit 885715855b19ec71ab362d92233478f3afb5a696
Author: Alex Schultz <email address hidden>
Date: Mon May 20 10:01:51 2019 -0600

    Ensure openstack clients are installed

    We need to ensure the openstack clients are installed on controllers for
    the deployed server case. This should be handled by the overcloud images
    themselves, however if the images are not used we should make sure the
    clients get installed with our OpenstackClients service.

    Change-Id: If7fad9f24c7294c2d749fc3838b1fb71182930fc
    Related-Bug: #1829769

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/660153
Committed: https://git.openstack.org/cgit/openstack/tripleo-puppet-elements/commit/?id=6a3c2b3e61923c82a3b95b6a1ec65f154021e42a
Submitter: Zuul
Branch: master

commit 6a3c2b3e61923c82a3b95b6a1ec65f154021e42a
Author: Alex Schultz <email address hidden>
Date: Mon May 20 09:43:12 2019 -0600

    Add element to install all openstack clients

    Let's add an element to ensure all the python openstack clients are
    properly installed on the controllers. These were previously being
    pulled in because we installed the actual services. Since we moved to
    containers, these clients are no longer installed by default.

    Closes-Bug: #1829769
    Change-Id: I551d6ac2d064bff05862b3ffa025240657fafd36

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/stein
Review: https://review.opendev.org/662609

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/rocky
Review: https://review.opendev.org/662610

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: stable/stein
Review: https://review.opendev.org/663035

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/662610
Committed: https://git.openstack.org/cgit/openstack/tripleo-puppet-elements/commit/?id=81729a1fd3b95b452ee6472e62ced36aab9ba249
Submitter: Zuul
Branch: stable/rocky

commit 81729a1fd3b95b452ee6472e62ced36aab9ba249
Author: Alex Schultz <email address hidden>
Date: Mon May 20 09:43:12 2019 -0600

    Add element to install all openstack clients

    Let's add an element to ensure all the python openstack clients are
    properly installed on the controllers. These were previously being
    pulled in because we installed the actual services. Since we moved to
    containers, these clients are no longer installed by default.

    Conflicts:
     elements/overcloud-controller/install.d/package-installs-overcloud-controller
     elements/overcloud-controller/pkg-map

    Closes-Bug: #1829769
    Change-Id: I551d6ac2d064bff05862b3ffa025240657fafd36
    (cherry picked from commit 6a3c2b3e61923c82a3b95b6a1ec65f154021e42a)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/663035
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=fd56198717e48fbffdbd867a0aa7173f5d0ed314
Submitter: Zuul
Branch: stable/stein

commit fd56198717e48fbffdbd867a0aa7173f5d0ed314
Author: Alex Schultz <email address hidden>
Date: Mon May 20 10:01:51 2019 -0600

    Ensure openstack clients are installed

    We need to ensure the openstack clients are installed on controllers for
    the deployed server case. This should be handled by the overcloud images
    themselves, however if the images are not used we should make sure the
    clients get installed with our OpenstackClients service.

    Change-Id: If7fad9f24c7294c2d749fc3838b1fb71182930fc
    Related-Bug: #1829769
    (cherry picked from commit 885715855b19ec71ab362d92233478f3afb5a696)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-puppet-elements 11.0.0 release.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/662609
Committed: https://git.openstack.org/cgit/openstack/tripleo-puppet-elements/commit/?id=79c0c760e89721899aba0de47721ae92a7ddeec0
Submitter: Zuul
Branch: stable/stein

commit 79c0c760e89721899aba0de47721ae92a7ddeec0
Author: Alex Schultz <email address hidden>
Date: Mon May 20 09:43:12 2019 -0600

    Add element to install all openstack clients

    Let's add an element to ensure all the python openstack clients are
    properly installed on the controllers. These were previously being
    pulled in because we installed the actual services. Since we moved to
    containers, these clients are no longer installed by default.

    NOTE: includes fix for pankoclient typo

    Closes-Bug: #1829769
    Change-Id: I551d6ac2d064bff05862b3ffa025240657fafd36
    (cherry picked from commit 6a3c2b3e61923c82a3b95b6a1ec65f154021e42a)

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: stable/rocky
Review: https://review.opendev.org/666459

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/666459
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=dcf0a74f9f77761ccc42af7d8923974f0d68ee5c
Submitter: Zuul
Branch: stable/rocky

commit dcf0a74f9f77761ccc42af7d8923974f0d68ee5c
Author: Alex Schultz <email address hidden>
Date: Mon May 20 10:01:51 2019 -0600

    Ensure openstack clients are installed

    We need to ensure the openstack clients are installed on controllers for
    the deployed server case. This should be handled by the overcloud images
    themselves, however if the images are not used we should make sure the
    clients get installed with our OpenstackClients service.

    This is not a clean cherry-pick from stable/stein. However,
    it retains the contents from master. Please see a bugfix
    committed via [1] for the cherry-pick to stable/stein.

    [1] https://review.opendev.org/#/c/665177/

    Change-Id: If7fad9f24c7294c2d749fc3838b1fb71182930fc
    Related-Bug: #1829769
    (cherry picked from commit 885715855b19ec71ab362d92233478f3afb5a696)
    (cherry picked from commit fd56198717e48fbffdbd867a0aa7173f5d0ed314)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-puppet-elements 9.1.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-puppet-elements 10.3.1 release.