Reproducer bash script sets USER_PYTHON_OVERRIDE=python2

Bug #1828098 reported by Ronelle Landy
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
tripleo
Fix Released
Medium
Ronelle Landy

Bug Description

When running the reproducer on rhel 8 and other platforms that support python3, we should not force a python2 install.

https://github.com/openstack/tripleo-quickstart-extras/blob/master/roles/create-zuul-based-reproducer/templates/reproducer-zuul-based-quickstart.sh.j2#L188

We can't only support python2.

Tags: ci
Ronelle Landy (rlandy)
tags: added: ci
Changed in tripleo:
status: New → Triaged
assignee: nobody → Ronelle Landy (rlandy)
milestone: none → train-1
Revision history for this message
Ronelle Landy (rlandy) wrote :

install-deps will force python_cmd to be python_2 unless it's set.
We need to set USER_PYTHON_OVERRIDE for rhel-8 to be python-3.

In fact, this can never work ...

python_cmd() {
    distribution=unknown
    distribution_major_version=unknown
    # we prefer python2 because on few systems python->python3
    python_cmd=${USER_PYTHON_OVERRIDE:=python2}

    if [ -f /etc/os-release ]; then
        . /etc/os-release
        distribution_major_version=${VERSION_ID%.*}
        case $NAME in
        "Red Hat"*) distribution="RedHat"
            if [ "$distribution_major_version" -ge "8" ]; then
                python_cmd=${USER_PYTHON_OVERRIDE:=python3}
            fi

If we don't export the override, python_cmd will be set to python2 and not be reset

Changed in tripleo:
importance: Undecided → Medium
Changed in tripleo:
milestone: train-1 → train-2
Changed in tripleo:
milestone: train-2 → train-3
Changed in tripleo:
milestone: train-3 → ussuri-1
Changed in tripleo:
milestone: ussuri-1 → ussuri-2
wes hayutin (weshayutin)
Changed in tripleo:
milestone: ussuri-2 → ussuri-3
Revision history for this message
Ronelle Landy (rlandy) wrote :

This is fixed through other patches

Changed in tripleo:
status: Triaged → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.