[stable/queens] Issues recovering after scaling out to more nodes than available

[Rabi Mishra]

If scale-out of overcloud fails for not having enough nodes, next deploy with correct count fails as it uses the heat parameter from the FAILED stack in pre-deploy validations, which is incorrect.

As pre-deploy validations have moved from tripleoclient(newton,octata)->tripleo-common(pike, queens)->tripleo-validations(rocky onwards), this has to be fixed in tripleo-common for stable/queens and stable/pike.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/queens
Review: https://review.opendev.org/656379

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/656379
Committed: https://git.openstack.org/cgit/openstack/tripleo-common/commit/?id=4fe901d2d079a71f0e1bb91aa3dfd0f486cba30c
Submitter: Zuul
Branch: stable/queens

commit 4fe901d2d079a71f0e1bb91aa3dfd0f486cba30c
Author: Rabi Mishra <email address hidden>
Date: Mon Apr 29 23:59:21 2019 +0530

    Don't use node count from failed stack parameters

    While checking node count in predeploy validations, if the stack
    is in FAILED state, parameters may not represent the actual nodes
    in stack. Don't use them for validations.

    Change-Id: I12213909a47e0a186bdb2e06c58784457bfe8d13
    Closes-Bug: #1826925

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/pike
Review: https://review.opendev.org/657063

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/657063
Committed: https://git.openstack.org/cgit/openstack/tripleo-common/commit/?id=f9801ec9bd0be9e24a274127f1d9849cc8aabf00
Submitter: Zuul
Branch: stable/pike

commit f9801ec9bd0be9e24a274127f1d9849cc8aabf00
Author: Rabi Mishra <email address hidden>
Date: Mon Apr 29 23:59:21 2019 +0530

    Don't use node count from failed stack parameters

    While checking node count in predeploy validations, if the stack
    is in FAILED state, parameters may not represent the actual nodes
    in stack. Don't use them for validations.

    Change-Id: I12213909a47e0a186bdb2e06c58784457bfe8d13
    Closes-Bug: #1826925
    (cherry picked from commit 4fe901d2d079a71f0e1bb91aa3dfd0f486cba30c)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-common 8.7.0 release.

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: stable/queens
Review: https://review.opendev.org/667134

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/667134
Committed: https://git.openstack.org/cgit/openstack/tripleo-common/commit/?id=19148898aabc58afb7c93957676c6cf408d0f962
Submitter: Zuul
Branch: stable/queens

commit 19148898aabc58afb7c93957676c6cf408d0f962
Author: Rabi Mishra <email address hidden>
Date: Mon Jun 24 20:49:28 2019 +0530

    Fix regression in validation action

    Regression with https://review.opendev.org/#/c/656379/

    self.stack is dict rather than a python object from action
    heat.stacks_get and is an input to this action.

    Change-Id: I92c9d0bb5ddac5b8a887a3acf3fc3314aab5867b
    Closes-Bug: #1834054
    Related-Bug: #1826925

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: stable/pike
Review: https://review.opendev.org/667502

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/667502
Committed: https://git.openstack.org/cgit/openstack/tripleo-common/commit/?id=eca1924ec3bde5cad4f6f8545669cc23f14b1997
Submitter: Zuul
Branch: stable/pike

commit eca1924ec3bde5cad4f6f8545669cc23f14b1997
Author: Rabi Mishra <email address hidden>
Date: Mon Jun 24 20:49:28 2019 +0530

    Fix regression in validation action

    Regression with https://review.opendev.org/#/c/656379/

    self.stack is dict rather than a python object from action
    heat.stacks_get and is an input to this action.

    Change-Id: I92c9d0bb5ddac5b8a887a3acf3fc3314aab5867b
    Closes-Bug: #1834054
    Related-Bug: #1826925
    (cherry picked from commit 19148898aabc58afb7c93957676c6cf408d0f962)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-common pike-eol release.