Overcloud with Nova NFS backend deployment failure due to InvalidSchemaError

Bug #1825374 reported by Archit Modi
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
tripleo
Fix Released
Undecided
Martin Schuppert

Bug Description

Description
===========
Due to a recent change [0] in storage.yaml, NovaNfsVersion is set to '4.2' if not set by user. There is an InvalidSchemaError when this yaml is validated, since it doesn't take the value as a string.

[0] https://github.com/openstack/tripleo-heat-templates/commit/393e89bfb6438781d6faaf5dfea2eb468341b451

Steps to reproduce
==================
Include the following params in custom THT:
NovaNfsEnabled: True
NovaNfsShare: "x.x.x.x:/nova/share/path/"

This sets the NovaNfsVersion to '4.2' from the sample-env-generator/sample_values

Expected result
===============
Deployment Succeeds

Actual result
=============
InvalidSchemaError

Environment
===========
1. Queens/Rocky

2. NovaNFS Storage backend

3. Neutron with OVS networking

Logs & Configs
==============
http://paste.openstack.org/show/749486/

Revision history for this message
Martin Schuppert (mschuppert) wrote :

This is only an issue with the sample file. Can be worked around with setting NovaNfsVersion in quotes in an environment file:

NovaNfsVersion: "4.2"

Fixes proposed
Master: https://review.openstack.org/#/c/653720/
Rocky: https://review.openstack.org/653721
Queens: https://review.openstack.org/653722

Changed in tripleo:
assignee: nobody → Martin Schuppert (mschuppert)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-heat-templates (stable/rocky)

Reviewed: https://review.opendev.org/653721
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=738bc3ca720d825643f7178061e54d3c39ceb1ba
Submitter: Zuul
Branch: stable/rocky

commit 738bc3ca720d825643f7178061e54d3c39ceb1ba
Author: Martin Schuppert <email address hidden>
Date: Thu Apr 18 13:43:50 2019 +0200

    fix storage.yaml to write environments/storage/nova-nfs.yaml

    753a3504184d966c63121ca95bc0135afbc83a75 removed ceph entries
    from sample-env-generator/storage.yaml which resulted in nova-nfs
    and cinder-netapp-config to be in the same section. Therefore
    environment_generator.py did not update the nova-nfs.yaml .

    Also add quotes to the nfs version as they are required in
    the resulting nova-nfs.yaml .

    Closes-Bug: #1825374

    Change-Id: I209480f209e3a8841362ea619b1c9b073c89f338
    (cherry picked from commit 693556f22388c4debb585213e0bb89d28b60c12e)

tags: added: in-stable-rocky
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-heat-templates (stable/queens)

Reviewed: https://review.opendev.org/653722
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=0fb8970bbd5e43c4241a384eeed9bce1232b88b5
Submitter: Zuul
Branch: stable/queens

commit 0fb8970bbd5e43c4241a384eeed9bce1232b88b5
Author: Martin Schuppert <email address hidden>
Date: Thu Apr 18 13:43:50 2019 +0200

    fix storage.yaml to write environments/storage/nova-nfs.yaml

    Also add quotes to the nfs version as they are required in
    the resulting nova-nfs.yaml .

    NOTE: partial cherry-pick as we only need the quotes fix in
          queens.

    Closes-Bug: #1825374

    Change-Id: I209480f209e3a8841362ea619b1c9b073c89f338
    (cherry picked from commit 693556f22388c4debb585213e0bb89d28b60c12e)
    (cherry picked from commit 27a454b7ad303569d650be29acfb232bfd340544)

tags: added: in-stable-queens
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-heat-templates (master)

Reviewed: https://review.opendev.org/653720
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=1c241362ff8df360a27b4fc06af0203d4e461c1f
Submitter: Zuul
Branch: master

commit 1c241362ff8df360a27b4fc06af0203d4e461c1f
Author: Martin Schuppert <email address hidden>
Date: Thu Apr 18 13:43:50 2019 +0200

    fix storage.yaml to write environments/storage/nova-nfs.yaml

    753a3504184d966c63121ca95bc0135afbc83a75 removed ceph entries
    from sample-env-generator/storage.yaml which resulted in nova-nfs
    and cinder-netapp-config to be in the same section. Therefore
    environment_generator.py did not update the nova-nfs.yaml .

    Also add quotes to the nfs version as they are required in
    the resulting nova-nfs.yaml .

    Closes-Bug: #1825374

    Change-Id: I209480f209e3a8841362ea619b1c9b073c89f338

Changed in tripleo:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tripleo-heat-templates (stable/stein)

Fix proposed to branch: stable/stein
Review: https://review.opendev.org/655883

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-heat-templates (stable/stein)

Reviewed: https://review.opendev.org/655883
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=a32d703190a8fd6eec737ea7c3cc20d72b3f8364
Submitter: Zuul
Branch: stable/stein

commit a32d703190a8fd6eec737ea7c3cc20d72b3f8364
Author: Martin Schuppert <email address hidden>
Date: Thu Apr 18 13:43:50 2019 +0200

    fix storage.yaml to write environments/storage/nova-nfs.yaml

    753a3504184d966c63121ca95bc0135afbc83a75 removed ceph entries
    from sample-env-generator/storage.yaml which resulted in nova-nfs
    and cinder-netapp-config to be in the same section. Therefore
    environment_generator.py did not update the nova-nfs.yaml .

    Also add quotes to the nfs version as they are required in
    the resulting nova-nfs.yaml .

    Closes-Bug: #1825374

    Change-Id: I209480f209e3a8841362ea619b1c9b073c89f338
    (cherry picked from commit 1c241362ff8df360a27b4fc06af0203d4e461c1f)

tags: added: in-stable-stein
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/tripleo-heat-templates 11.0.0

This issue was fixed in the openstack/tripleo-heat-templates 11.0.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/tripleo-heat-templates 9.4.0

This issue was fixed in the openstack/tripleo-heat-templates 9.4.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/tripleo-heat-templates 8.4.0

This issue was fixed in the openstack/tripleo-heat-templates 8.4.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/tripleo-heat-templates 10.6.0

This issue was fixed in the openstack/tripleo-heat-templates 10.6.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.