centosci queens failing at Property ControlPlaneDefaultRoute not assigned

[Quique Llorente]

https://ci.centos.org/artifacts/rdo/jenkins-tripleo-quickstart-promote-queens-rdo_trunk-minimal-199/undercloud/home/stack/overcloud_deploy.log.gz
2019-04-12 13:25:55 | 2019-04-12 13:25:51Z [overcloud.Controller]: CREATE_FAILED resources.Controller: Resource CREATE failed: resources[0]: Property error: resources.NetworkConfig.properties: Property ControlPlaneDefaultRoute not assigned
2019-04-12 13:25:55 | 2019-04-12 13:25:51Z [overcloud]: CREATE_FAILED Resource CREATE failed: resources.Controller: Resource CREATE failed: resources[0]: Property error: resources.NetworkConfig.properties: Property ControlPlaneDefaultRoute not assigned
2019-04-12 13:25:55 | 2019-04-12 13:25:51Z [overcloud.Compute]: CREATE_FAILED resources.Compute: Resource CREATE failed: resources[0]: Property error: resources.NetworkConfSTART with options: ['stack', 'failures', 'list', 'overcloud']
2019-04-12 13:25:55 | command: stack failures list -> heatclient.osc.v1.stack_failures.ListStackFailures (auth=True)
2019-04-12 13:25:55 | Using auth plugin: password
2019-04-12 13:26:00 | END return value: 0
2019-04-12 13:26:00 | Heat Stack create failed.
2019-04-12 13:26:00 | Heat Stack create failed.
2019-04-12 13:26:00 | END return value: 1
2019-04-12 13:26:00 | ig.properties: Property ControlPlaneDefaultRoute not assigned
2019-04-12 13:26:00 | 2019-04-12 13:25:51Z [overcloud]: CREATE_FAILED Resource CREATE failed: resources.Compute: Resource CREATE failed: resources[0]: Property error: resources.NetworkConfig.properties: Property ControlPlaneDefaultRoute not assigned
2019-04-12 13:26:00 |
2019-04-12 13:26:00 | Stack overcloud CREATE_FAILED
2019-04-12 13:26:00 |
2019-04-12 13:26:00 | overcloud.Controller.0:
2019-04-12 13:26:00 | resource_type: OS::TripleO::Controller
2019-04-12 13:26:00 | physical_resource_id:
2019-04-12 13:26:00 | status: CREATE_FAILED
2019-04-12 13:26:00 | status_reason: |
2019-04-12 13:26:00 | resources[0]: Property error: resources.NetworkConfig.properties: Property ControlPlaneDefaultRoute not assigned
2019-04-12 13:26:00 | overcloud.Compute.0:
2019-04-12 13:26:00 | resource_type: OS::TripleO::Compute
2019-04-12 13:26:00 | physical_resource_id:
2019-04-12 13:26:00 | status: CREATE_FAILED

[Quique Llorente (quiquell)]

Comparing with rocky looks like network-environment.yaml is missing ControlPlain config

rocky
https://ci.centos.org/artifacts/rdo/jenkins-tripleo-quickstart-promote-rocky-rdo_trunk-minimal-137/undercloud/home/stack/network-environment.yaml.gz

{
    "parameter_defaults": {
        "ControlPlaneDefaultRoute": "192.168.24.1",
        "ControlPlaneSubnetCidr": "24",
        "DnsServers": [
            "192.168.23.1"
        ],
        "EC2MetadataIp": "192.168.24.1",
        "ExternalAllocationPools": [
            {
                "end": "10.0.0.250",
                "start": "10.0.0.4"
            }
        ],
        "ExternalInterfaceDefaultRoute": "10.0.0.1",
        "ExternalNetCidr": "10.0.0.1/24",
        "NeutronExternalNetworkBridge": "",
        "PublicVirtualFixedIPs": [
            {
                "ip_address": "10.0.0.5"
            }
        ]
    }
}

queens
{
    "parameter_defaults": {
        "DnsServers": [
            "192.168.23.1"
        ],
        "EC2MetadataIp": "192.168.24.1",
        "ExternalAllocationPools": [
            {
                "end": "10.0.0.250",
                "start": "10.0.0.4"
            }
        ],
        "ExternalInterfaceDefaultRoute": "10.0.0.1",
        "ExternalNetCidr": "10.0.0.1/24",
        "NeutronExternalNetworkBridge": "",
        "PublicVirtualFixedIPs": [
            {
                "ip_address": "10.0.0.5"
            }
        ]
    }
}

[Quique Llorente (quiquell)]

Review causing the issue https://review.openstack.org/#/c/577786/8

[Cédric Jeanneret (cjeanner)]

Hmm, that change doesn't seem to be in Queens - it's for Master and was backported in Rocky... ?

[Quique Llorente (quiquell)]

So CI centos is using the "minimal" config and it's similar to fs001 except fs001 also read variables from https://github.com/openstack/tripleo-heat-templates/blob/stable/queens/ci/environments/network/multiple-nics/network-environment.yaml#L10-L11 and it include the variables

[Bogdan Dobrelya (bogdando)]

> Hmm, that change doesn't seem to be in Queens - it's for Master and was backported in Rocky... ?
@Cedric, quickstart extras is yet branched

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/652677

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/652677
Committed: https://git.openstack.org/cgit/openstack/tripleo-quickstart-extras/commit/?id=1cbafc9e8cf134f05f3a12392d619b015be398d1
Submitter: Zuul
Branch: master

commit 1cbafc9e8cf134f05f3a12392d619b015be398d1
Author: Bogdan Dobrelya <email address hidden>
Date: Mon Apr 15 14:41:07 2019 +0000

    Revert "Remove ctlplane data from CI network-environment"

    This reverts commit ebc09bd930a604ed83be326c2a521d74139b95f7.
    Closes-bug: #1824779

    Change-Id: I23632dab73165b8537a2293cef00b6b1675fc197

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-quickstart-extras 2.1.1 release.