ceph-ansible doesn't respect ContainerCli

[John Fulton]

If you deploy tripleo and pass "ContainerCli: podman" and both docker and podman are installed on the host OS, then ceph ends up getting deployed with docker. If docker isn't installed ceph-ansible will use podman, but it's picking the container container_binary based on what it finds, not what the user overrides.

A fix to this, should do something like this:

 https://review.openstack.org/#/c/631198/

but make it pass this:

 ContainerCli: podman

so ceph-ansible is told to use container_binary as per:

 https://github.com/ceph/ceph-ansible/blob/master/group_vars/all.yml.sample#L557

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/647504

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/647504
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=febab2bf8888ed1ad7d20ed4f3b2a7d6dd10b415
Submitter: Zuul
Branch: master

commit febab2bf8888ed1ad7d20ed4f3b2a7d6dd10b415
Author: fpantano <email address hidden>
Date: Mon Mar 25 16:05:46 2019 +0100

    ContainerCli param added to ceph-base heat template

    Added a new param to the heat template that allow operators
    to select the containercli used to handle ceph containers.
    This parameter is translated in an ansible extra-var passed to
    the ceph-ansible playbook, overriding the container_binary fact.
    Rebasing to reflect the new project tree.

    Change-Id: Ife44b0095b2328af0cae96057d5ba9306bacaf9d
    Related-Bug: #1821347

[John Fulton (jfulton-org)]

Fixed merged a while ago https://review.openstack.org/647504 not sure why this bug still open. Closing